EcommerceAssignOrdersExtension

Complexity

Total Complexity

15

Size/Duplication

Total Lines	87
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getAssignedAdminNice()	0	11	4
A	updateCMSFields()	0	8	1
A	scaffoldSearchFields()	0	4	1
A	getAssignedAdminDropdown()	0	11	2
B	onAfterWrite()	0	20	7

<?php

class EcommerceAssignOrdersExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $has_one = array(

The property $has_one is not used and could be removed.

        'AssignedAdmin' => 'Member'
    );

    private static $casting = array(

The property $casting is not used and could be removed.

        'AssignedAdminNice' => 'Varchar'
    );

    private static $summary_fields = array(

The property $summary_fields is not used and could be removed.

        'AssignedAdminNice' => 'Admin'
    );

    private static $searchable_fields = array(

The property $searchable_fields is not used and could be removed.

        "AssignedAdminID" => array(
            'field' => 'TextField',
            'filter' => 'ExactMatchFilter',
            'title' => 'Assigned Admin'
        )
    );

    private static $notify_by_email = true;

The property $notify_by_email is not used and could be removed.

    public function getAssignedAdminNice()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($this->owner->AssignedAdminID) {

The property AssignedAdminID does not seem to exist in SS_Object.

            if ($admin = $this->owner->AssignedAdmin()) {
                if ($admin->exists()) {
                    return $admin->getTitle();
                }
            }
        }
        return 'n/a';
    }

    /**
     * Update Fields
     * @return FieldList

Should the return type not be FieldList|null?

     */
    public function updateCMSFields(FieldList $fields)
    {
        $fields->addFieldToTab(
            'Root.Next',
            $this->getAssignedAdminDropdown(),
            'OrderSummary'
        );
    }

    public function scaffoldSearchFields($fieldList, $_params)

The parameter $_params is not used and could be removed.

    {
        $fieldList->push($this->getAssignedAdminDropdown());
    }

    protected function getAssignedAdminDropdown()
    {
        $shopAdminAndCurrentCustomerArray = EcommerceRole::list_of_admins(true);
        $titleArray = Config::inst()->get('EcommerceAssignOrdersExtension', 'searchable_fields');
        $title = isset($titleArray['AssignedAdminID']['title']) ? $titleArray['AssignedAdminID']['title'] : 'Admin';
        return DropdownField::create(
            'AssignedAdminID',
            $title,
            $shopAdminAndCurrentCustomerArray
        );
    }

    public function onAfterWrite()
    {
        if (Config::inst()->get('EcommerceAssignOrdersExtension', 'notify_by_email')) {
            if ($this->owner->AssignedAdminID) {
                if ($this->owner->isChanged('AssignedAdminID')) {
                    //$member = $this->owner->AssignedAdmin();

59% of this comment could be valid code. Did you maybe forget this after debugging?

                    $member = Member::get()->byID($this->owner->AssignedAdminID);

The property AssignedAdminID does not seem to exist in SS_Object.

                    if ($member && $member->exists() && $member->Email) {
                        $this->owner->sendEmail(
                            $emailClassName = 'Order_InvoiceEmail',
                            $subject = 'An order has been assigned to you on '.Director::absoluteURL('/'),
                            $message = '<p>An order has been assigned to you:</p> <h1><a href="'.$this->owner->CMSEditLink().'">Open Order</a></h1>',
                            $resend = true,
                            $adminOnlyOrToEmail = $member->Email
                        );
                    }
                }
            }
        }
    }
}