AnyPriceProductPage_ProductVariation - Code Metrics - sunnysideup/silverstripe-ecommerce_anypriceproduct - Measure and Improve Code Quality continuously with Scrutinizer

AnyPriceProductPage_ProductVariation A
last analyzed 2018-03-20 01:02 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	1
dl	0
loc	27
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	canPurchase()	4	1
A	TableSubTitle()	4	1
A	getTableSubTitle()	4	1

<?php


class AnyPriceProductPage_ProductVariation extends ProductVariation
namespace YourVendor;

class YourClass { }
{
    private static $db =array(

        "Description" => "Varchar(200)"
    );

    /**
     *
     * @var String
     */
    protected $defaultClassNameForOrderItem = "AnyPriceProductPage_ProductVariationOrderItem";

    public function canPurchase(Member $member = null, $checkPrice = true)
    {
        return true;
    }

    public function TableSubTitle()

    {
        return $this->getTableSubTitle();
    }

    public function getTableSubTitle()

    {
        return $this->Description;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3
4			class AnyPriceProductPage_ProductVariation extends ProductVariation
			0 ignored issues – show Coding Style Compatibility introduced 2017-04-27 09:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
5			{
6			private static $db =array(
			0 ignored issues – show Comprehensibility introduced 2017-04-27 09:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-04-27 09:26 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
7			"Description" => "Varchar(200)"
8			);
9
10			/**
11			*
12			* @var String
13			*/
14			protected $defaultClassNameForOrderItem = "AnyPriceProductPage_ProductVariationOrderItem";
15
16			public function canPurchase(Member $member = null, $checkPrice = true)
17			{
18			return true;
19			}
20
21			public function TableSubTitle()
			0 ignored issues – show Documentation introduced 2018-02-01 09:09 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
22			{
23			return $this->getTableSubTitle();
24			}
25
26			public function getTableSubTitle()
			0 ignored issues – show Documentation introduced 2018-02-01 09:09 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
27			{
28			return $this->Description;
			0 ignored issues – show Documentation introduced 2017-04-27 09:26 UTC by Report Bug Copy Issue Report The property `Description` does not exist on `object<AnyPriceProductPage_ProductVariation>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29			}
30			}
31

sunnysideup / silverstripe-ecommerce_anypriceproduct

AnyPriceProductPage_ProductVariation A last analyzed 2018-03-20 01:02 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

AnyPriceProductPage_ProductVariation A
last analyzed 2018-03-20 01:02 UTC