sunnysideup / silverstripe-ecommerce_alsorecommended

code/forms/RecommendedProductsModifier_Form.php

<?php

/**
 *
 * you can set
 * RecommendedProductsModifier_Form:
 *   product_template: "bla"
 *
 * in your configs to have a customised product display.
 *
 *
 */
class RecommendedProductsModifier_Form extends OrderModifierForm

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $image_width = 100;

The property $image_width is not used and could be removed.

    private static $something_recommended_text = "Recommended Additions";

The property $something_recommended_text is not used and could be removed.

    private static $add_button_text = "Add Selected Items";

The property $add_button_text is not used and could be removed.

    private static $order_item_classname = "Product_OrderItem";

The property $order_item_classname is not used and could be removed.

    private static $product_template = "";

The property $product_template is not used and could be removed.

    public function __construct($optionalController = null, $name, FieldList $fields, FieldList $actions, $optionalValidator = null, $recommendedBuyables)

Parameters which have default values should be placed at the end.

    {
        if (! ($fields instanceof FieldList)) {
            $fields = FieldList::create();
        }
        $fields->push(HeaderField::create($this->config()->get("something_recommended_text")));
        $productFieldList = new FieldList();
        foreach ($recommendedBuyables as $buyable) {
            $template = Config::inst()->get("RecommendedProductsModifier_Form", "product_template");
            if ($template) {
                $checkboxID = $buyable->ClassName."|".$buyable->ID;
                $arrayData = new ArrayData(
                    array(
                        "Buyable" => $buyable,
                        "CheckboxID" => $checkboxID,
                        "Checkbox" => new CheckboxField($checkboxID, _t("RecommendedProductsModifier_Form.ADD", "add"))
                    )
                );
                $productFieldList->push(new LiteralField("Buyable_".$buyable->ID, $arrayData->renderWith($template)));
            } else {
                //foreach product in cart get recommended products
                $imageID = $buyable->ImageID;

$imageID is not used, you could remove the assignment.

                $imagePart = '';
                if ($buyable && $buyable->ImageID > 0) {
                    $resizedImage = $buyable->Image()->SetWidth($this->Config()->get("image_width"));
                    if (is_object($resizedImage) && $resizedImage) {
                        $imageLink = $resizedImage->Filename;
                        $imagePart = '<span class="secondPart"><img src="'.$imageLink.'" alt="'.Convert::raw2att($buyable->Title).'" /></span>';
                    }
                }
                if (!$imagePart) {
                    $imagePart = '<span class="secondPart noImage">[no image available for '.$buyable->Title.']</span>';
                }
                $priceAsMoney = EcommerceCurrency::get_money_object_from_order_currency($buyable->calculatedPrice());
                $pricePart = '<span class="firstPart">'.$priceAsMoney->NiceLongSymbol().'</span>';
                $title = '<a href="'.$buyable->Link().'">'.$buyable->Title.'</a>'.$pricePart.$imagePart.'';
                $newField = new CheckboxField($buyable->ClassName."|".$buyable->ID, $title);
                $fields->push($newField);
            }
        }
        $fields->push(new CompositeField($productFieldList));
        if (! $actions instanceof FieldList) {
            $actions = FieldList::create();
        }
        $actions->push(FormAction::create('processOrderModifier', $this->config()->get("add_button_text")));
        // 6) Form construction
        parent::__construct($optionalController, $name, $fields, $actions, $optionalValidator);
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        //Requirements::block(THIRDPARTY_DIR."/jquery/jquery.js");

56% of this comment could be valid code. Did you maybe forget this after debugging?

        //Requirements::javascript(Director::protocol()."ajax.googleapis.com/ajax/libs/jquery/1.7.2/jquery.min.js");

62% of this comment could be valid code. Did you maybe forget this after debugging?

        Requirements::javascript("ecommerce_alsorecommended/javascript/RecommendedProductsModifier.js");
        Requirements::themedCSS("RecommendedProductsModifier", "ecommerce_alsrecommended");
    }

    public function processOrderModifier($data, $form)

The parameter $form is not used and could be removed.

    {
        $count = 0;
        $error = 0;
        foreach ($data as $key => $value) {
            if ($value == 1) {
                list($className, $id) = explode("|", $key);
                if (class_exists($className) && intval($id) == $id) {
                    $buyable = $className::get()->byID($id);
                    if ($buyable && $buyable->canPurchase()) {
                        $count++;
                        ShoppingCart::singleton()->addBuyable($buyable);
                    } else {
                        $error++;
                    }
                } else {
                    $error++;
                }
            }
        }
        if ($error) {
            ShoppingCart::singleton()->addMessage(_t("RecommendedProductsModifier_Form.ERROR_UPDATING", "There was an error updating the cart", "bad"));
        } elseif ($count) {
            ShoppingCart::singleton()->addMessage(_t("RecommendedProductsModifier_Form.CART_UPDATED", "Cart updated (".$count.")", "good"));
        } else {
            ShoppingCart::singleton()->addMessage(_t("RecommendedProductsModifier_Form.NOTHING_TO_ADD", "Nothing to add", "warning"));
        }
        Controller::curr()->redirectBack();
    }



}