EcommerceAlsoRecommendedDOD

Complexity

Total Complexity

15

Size/Duplication

Total Lines	95
Duplicated Lines	35.79 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	updateCMSFields()	0	28	2
C	onAfterWrite()	18	23	9
A	EcommerceRecommendedProductsForSale()	8	8	2
A	RecommendedForForSale()	8	8	2

<?php



class EcommerceAlsoRecommendedDOD extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $many_many = array(

The property $many_many is not used and could be removed.

        'EcommerceRecommendedProducts' => 'Product'
    );

    private static $belongs_many_many = array(

The property $belongs_many_many is not used and could be removed.

        'RecommendedFor' => 'Product'
    );

    public function updateCMSFields(FieldList $fields)
    {
        if ($this->owner instanceof Product) {
            $fields->addFieldToTab(
                'Root.Links',
                GridField::create(
                    'EcommerceRecommendedProducts',
                    'Also Recommended Products',
                    $this->owner->EcommerceRecommendedProducts(),
                    $config = GridFieldBasicPageRelationConfig::create()
                )
            );
            $component = $config->getComponentByType('GridFieldAddExistingAutocompleter');
            $component->setSearchFields(array("InternalItemID", "Title"));

            $fields->addFieldToTab(
                'Root.Links',
                GridField::create(
                    'RecommendedFor',
                    'Recommended For',
                    $this->owner->RecommendedFor(),
                    $config = GridFieldBasicPageRelationConfig::create()
                )
            );
            $component = $config->getComponentByType('GridFieldAddExistingAutocompleter');
            $component->setSearchFields(array("InternalItemID", "Title"));
        }
    }

    /**
     *
     * small cleanup
     */
    public function onAfterWrite()
    {
        $products = $this->owner->EcommerceRecommendedProducts();
        if ($products->count()) {

This code seems to be duplicated across your project.

            foreach ($products as $product) {
                if (!$product instanceof Product) {
                    $products->remove($product);
                } elseif (!$product->AllowPurchase) {
                    $products->remove($product);
                }
            }
        }
        $products = $this->owner->RecommendedFor();
        if ($products->count()) {

This code seems to be duplicated across your project.

            foreach ($products as $product) {
                if (!$product instanceof Product) {
                    $products->remove($product);
                } elseif (!$product->AllowPurchase) {
                    $products->remove($product);
                }
            }
        }
    }

    /**
     * only returns the products that are for sale
     * if only those need to be showing.
     * @return DataList
     */
    public function EcommerceRecommendedProductsForSale()

This method seems to be duplicated in your project.

    {
        if ($this->owner->EcomConfig()->OnlyShowProductsThatCanBePurchased) {
            return $this->owner->EcommerceRecommendedProducts()->filter(array("AllowPurchase" => 1));
        } else {
            return $this->owner->EcommerceRecommendedProducts();
        }
    }

    /**
     * only returns the products that are for sale
     * if only those need to be showing.
     * @return DataList
     */
    public function RecommendedForForSale()

This method seems to be duplicated in your project.

    {
        if ($this->owner->EcomConfig()->OnlyShowProductsThatCanBePurchased) {
            return $this->owner->RecommendedFor()->filter(array("AllowPurchase" => 1));
        } else {
            return $this->owner->RecommendedFor();
        }
    }
}