Issues in EcommerceMoney.php (master) - Issues in master - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2002)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/money/EcommerceMoney.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class EcommerceMoney extends Extension
{
    /**
     * returns the symbol for a currency, e.g. $.
     *
     * @param string $currency
     *
     * @return string
     */
    public static function get_default_symbol($currency)
    {
        $money = Money::create();

        return $money->getSymbol($currency);
    }

    /**
     * returns the short symbol for a currency
     * This is shorter than the default one.
     *
     * @param string $currency
     *
     * @return string

     */
    public static function get_short_symbol($currency)
    {
        $symbol = self::get_default_symbol($currency);
        if ($symbol) {
            $i = 0;
            while ($i < mb_strlen($symbol) && $symbol[$i] === $currency[$i]) {
                ++$i;
            }

            return substr($symbol, $i);
        }
    }

    /**
     * returns the long symbol for a currency.
     *
     * @param string $currency
     *
     * @return string
     */
    public static function get_long_symbol($currency)
    {
        $symbol = self::get_default_symbol($currency);
        if ($symbol && mb_strlen($symbol) < 3) {
            $symbol = substr($currency, 0, 3 - mb_strlen($symbol)).$symbol;
        }

        return $symbol;
    }

    /**
     * returns the default symbol for a site.
     * with or without html.
     *
     * @param bool $html
     *
     * @return string
     */
    public function NiceDefaultSymbol($html = true)
    {
        return self::get_default_symbol($this->owner->currency) == self::get_short_symbol($this->owner->currency) ? $this->NiceShortSymbol($html) : $this->NiceLongSymbol($html);

    }

    /**
     * returns the short symbol for a site.
     * with or without html.
     *
     * @param bool $html
     *
     * @return string
     */
    public function NiceShortSymbol($html = true)
    {
        $symbol = self::get_short_symbol($this->owner->currency);

        if ($html) {
            $symbol = "<span class=\"currencyHolder currencyHolderShort currency{$this->owner->currency}\"><span class=\"currencySymbol\">$symbol</span></span>";
        }
        $amount = $this->owner->getAmount();

        return (is_numeric($amount)) ? $this->owner->currencyLib->toCurrency($amount, array('symbol' => $symbol, 'display' => Zend_Currency::USE_SYMBOL)) : '';

    }

    /**
     * returns the long symbol for a site.
     * with or without html.
     *
     * @param bool $html
     *
     * @return string
     */
    public function NiceLongSymbol($html = true)
    {
        $symbol = self::get_long_symbol($this->owner->currency);

        $short = self::get_short_symbol($this->owner->currency);
        $pre = substr($symbol, 0, mb_strlen($symbol) - mb_strlen($short));
        if ($html) {
            $symbol = "<span class=\"currencyHolder currencyHolderLong currency{$this->owner->currency}\"><span class=\"currencyPreSymbol\">$pre</span><span class=\"currencySymbol\">$short</span></span>";
        } else {
            $symbol = $pre.$short;
        }
        $amount = $this->owner->getAmount();

        return (is_numeric($amount)) ? $this->owner->currencyLib->toCurrency($amount, array('symbol' => $symbol, 'display' => Zend_Currency::USE_SYMBOL)) : '';

    }

    /**
     * returns a currency like this: 8,001 usd / 12.12 nzd.
     *
     * @param bool $html
     *
     * @return string
     */
    public function SymbolNumberAndCode($html = true)
    {
        $symbol = self::get_short_symbol($this->owner->currency);

        if ($html) {
            $symbol = "<span class=\"currencySymbol\">$symbol</span>";
        }
        $code = strtolower($this->owner->currency);
        if ($html) {
            $code = "<span class=\"currencyHolder\">$code</span>";
        }
        $amount = $this->owner->getAmount();

        return (is_numeric($amount)) ?  $symbol.$this->owner->currencyLib->toCurrency($amount, array('symbol' => '', 'precision' => 0)).' '.$code : '';

    }

    /**
     * returns the default format for a site for currency.
     *
     * @param bool $html
     *
     * @return string
     */
    public function NiceDefaultFormat($html = true)
    {
        $function = EcommerceConfig::get('EcommerceMoney', 'default_format');

        return $this->owner->$function($html);
    }
}


1			<?php
2
3			class EcommerceMoney extends Extension
4			{
5			/**
6			* returns the symbol for a currency, e.g. $.
7			*
8			* @param string $currency
9			*
10			* @return string
11			*/
12			public static function get_default_symbol($currency)
13			{
14			$money = Money::create();
15
16			return $money->getSymbol($currency);
17			}
18
19			/**
20			* returns the short symbol for a currency
21			* This is shorter than the default one.
22			*
23			* @param string $currency
24			*
25			* @return string
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
26			*/
27			public static function get_short_symbol($currency)
28			{
29			$symbol = self::get_default_symbol($currency);
30			if ($symbol) {
31			$i = 0;
32			while ($i < mb_strlen($symbol) && $symbol[$i] === $currency[$i]) {
33			++$i;
34			}
35
36			return substr($symbol, $i);
37			}
38			}
39
40			/**
41			* returns the long symbol for a currency.
42			*
43			* @param string $currency
44			*
45			* @return string
46			*/
47			public static function get_long_symbol($currency)
48			{
49			$symbol = self::get_default_symbol($currency);
50			if ($symbol && mb_strlen($symbol) < 3) {
51			$symbol = substr($currency, 0, 3 - mb_strlen($symbol)).$symbol;
52			}
53
54			return $symbol;
55			}
56
57			/**
58			* returns the default symbol for a site.
59			* with or without html.
60			*
61			* @param bool $html
62			*
63			* @return string
64			*/
65			public function NiceDefaultSymbol($html = true)
66			{
67			return self::get_default_symbol($this->owner->currency) == self::get_short_symbol($this->owner->currency) ? $this->NiceShortSymbol($html) : $this->NiceLongSymbol($html);
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currency` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
68			}
69
70			/**
71			* returns the short symbol for a site.
72			* with or without html.
73			*
74			* @param bool $html
75			*
76			* @return string
77			*/
78			public function NiceShortSymbol($html = true)
79			{
80			$symbol = self::get_short_symbol($this->owner->currency);
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currency` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
81			if ($html) {
82			$symbol = "<span class=\"currencyHolder currencyHolderShort currency{$this->owner->currency}\"><span class=\"currencySymbol\">$symbol</span></span>";
83			}
84			$amount = $this->owner->getAmount();
85
86			return (is_numeric($amount)) ? $this->owner->currencyLib->toCurrency($amount, array('symbol' => $symbol, 'display' => Zend_Currency::USE_SYMBOL)) : '';
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currencyLib` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
87			}
88
89			/**
90			* returns the long symbol for a site.
91			* with or without html.
92			*
93			* @param bool $html
94			*
95			* @return string
96			*/
97			public function NiceLongSymbol($html = true)
98			{
99			$symbol = self::get_long_symbol($this->owner->currency);
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currency` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
100			$short = self::get_short_symbol($this->owner->currency);
101			$pre = substr($symbol, 0, mb_strlen($symbol) - mb_strlen($short));
102			if ($html) {
103			$symbol = "<span class=\"currencyHolder currencyHolderLong currency{$this->owner->currency}\"><span class=\"currencyPreSymbol\">$pre</span><span class=\"currencySymbol\">$short</span></span>";
104			} else {
105			$symbol = $pre.$short;
106			}
107			$amount = $this->owner->getAmount();
108
109			return (is_numeric($amount)) ? $this->owner->currencyLib->toCurrency($amount, array('symbol' => $symbol, 'display' => Zend_Currency::USE_SYMBOL)) : '';
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currencyLib` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
110			}
111
112			/**
113			* returns a currency like this: 8,001 usd / 12.12 nzd.
114			*
115			* @param bool $html
116			*
117			* @return string
118			*/
119			public function SymbolNumberAndCode($html = true)
120			{
121			$symbol = self::get_short_symbol($this->owner->currency);
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currency` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
122			if ($html) {
123			$symbol = "<span class=\"currencySymbol\">$symbol</span>";
124			}
125			$code = strtolower($this->owner->currency);
126			if ($html) {
127			$code = "<span class=\"currencyHolder\">$code</span>";
128			}
129			$amount = $this->owner->getAmount();
130
131			return (is_numeric($amount)) ? $symbol.$this->owner->currencyLib->toCurrency($amount, array('symbol' => '', 'precision' => 0)).' '.$code : '';
			0 ignored issues – show Bug introduced 2018-06-20 01:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `currencyLib` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
132			}
133
134			/**
135			* returns the default format for a site for currency.
136			*
137			* @param bool $html
138			*
139			* @return string
140			*/
141			public function NiceDefaultFormat($html = true)
142			{
143			$function = EcommerceConfig::get('EcommerceMoney', 'default_format');
144
145			return $this->owner->$function($html);
146			}
147			}
148

sunnysideup / silverstripe-ecommerce

Issues (2002)

Security Analysis not enabled

code/money/EcommerceMoney.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like