ModelAdminEcommerceBaseClass

Complexity

Total Complexity

5

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getManagedModels()	0	15	4
A	oneItemForm()	0	8	1

<?php

/**
 * @see: http://doc.silverstripe.org/framework/en/reference/ModelAdmin
 *
 * @author Nicolaas [at] sunnyside up . co .nz
 */
class ModelAdminEcommerceBaseClass extends ModelAdmin

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @return array Map of class name to an array of 'title' (see {@link $managed_models})

Should the return type not be array|integer|double|boolean?

     */
    public function getManagedModels()
    {
        $models = EcommerceConfig::get($this->class, 'managed_models');
        foreach ($models as $key => $model) {

The expression $models of type array|integer|double|string|boolean is not guaranteed to be traversable. How about adding an additional type check?

            if (is_array($model)) {
                $model = $key;
            }
            if (!class_exists($model)) {
                unset($models[$key]);
            }
        }
        Config::inst()->update('ModelAdminEcommerceBaseClass', 'managed_models', $models);

        return parent::getManagedModels();
    }

    /**
     * Change this variable if you don't want the Import from CSV form to appear.
     * This variable can be a boolean or an array.
     * If array, you can list className you want the form to appear on. i.e. array('myClassOne','myClasstwo').
     */
    public $showImportForm = false;

    /**
     *
     * @param DataObject $record
     *
     * @return Form

Should the return type not be SS_HTTPResponse|null|CMSForm?

     */
    function oneItemForm($record)

It is generally recommended to explicitly declare the visibility for methods.

    {
        Config::inst()->update('LeftAndMain', 'tree_class', $record->ClassName);
        $idField = HiddenField::create('ID')->setValue($record->ID);
        $form = LeftAndMain::getEditForm($record);

$record is of type object<DataObject>, but the function expects a integer|null.

        $form->Fields()->push($idField);

The method Fields does only exist in CMSForm, but not in SS_HTTPResponse.

        return $form;
    }


}