Completed
Push — master ( ee94a5...d975bd )
by Nicolaas
04:02
created
code/search/filters/OrderFilters_MustHaveAtLeastOnePayment.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 class OrderFilters_MustHaveAtLeastOnePayment extends ExactMatchFilter
12 12
 {
13 13
     /**
14
-     *@return SQLQuery
14
+     *@return DataQuery
15 15
      **/
16 16
     public function apply(DataQuery $query)
17 17
     {
Please login to merge, or discard this patch.
code/model/process/OrderSteps/OrderStep_Paid.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
      *
25 25
      * @see Order::doNextStatus
26 26
      *
27
-     * @param Order object
27
+     * @param Order Order
28 28
      *
29 29
      * @return bool - true if the current step is ready to be run...
30 30
      **/
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      *
42 42
      * @see Order::doNextStatus
43 43
      *
44
-     * @param Order object
44
+     * @param Order Order
45 45
      *
46 46
      * @return bool - true if run correctly.
47 47
      **/
Please login to merge, or discard this patch.
code/model/process/OrderSteps/OrderStep_SentReceipt.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      *
28 28
      * @see Order::doNextStatus
29 29
      *
30
-     * @param Order object
30
+     * @param Order Order
31 31
      *
32 32
      * @return bool - true if the current step is ready to be run...
33 33
      **/
Please login to merge, or discard this patch.
code/tasks/EcommerceTaskTryToFinaliseOrders.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -96,6 +96,11 @@
 block discarded – undo
96 96
     }
97 97
 
98 98
 
99
+    /**
100
+     * @param DataList $orders
101
+     * @param integer|null $limit
102
+     * @param integer|null $startAt
103
+     */
99 104
     protected function tryToFinaliseOrders($orders, $limit, $startAt)
100 105
     {
101 106
         $orders = $orders->limit($limit, $startAt);
Please login to merge, or discard this patch.
code/forms/OrderForm_Feedback.php 1 patch
Doc Comments   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     /**
47 47
      * @param array        $data The form request data submitted
48 48
      * @param Form         $form The {@link Form} this was submitted on
49
-     * @param HTTPRequest  $request The {@link Form} this was submitted on
49
+     * @param SS_HTTPRequest  $request The {@link Form} this was submitted on
50 50
      */
51 51
     public function dofeedback(array $data, Form $form, SS_HTTPRequest $request)
52 52
     {
@@ -77,7 +77,6 @@  discard block
 block discarded – undo
77 77
     /**
78 78
      * saves the form into session.
79 79
      *
80
-     * @param array $data - data from form.
81 80
      */
82 81
     public function saveDataToSession()
83 82
     {
@@ -85,6 +84,11 @@  discard block
 block discarded – undo
85 84
         Session::set("FormInfo.{$this->FormName()}.data", $data);
86 85
     }
87 86
 
87
+    /**
88
+     * @param string $value
89
+     *
90
+     * @return string
91
+     */
88 92
     protected function getValueFromOrderConfirmationPage($value)
89 93
     {
90 94
         if($page = $this->getOrderConfirmationPage()) {
Please login to merge, or discard this patch.
code/OrderConfirmationPage.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -296,7 +296,6 @@  discard block
 block discarded – undo
296 296
      * Return a link to view the order on this page.
297 297
      *
298 298
      * @param int|string $orderID                ID of the order
299
-     * @param string     $type                   - the type of email you want to send.
300 299
      * @param bool       $actuallySendEmail      - do we actually send the email
301 300
      * @param int        $alternativeOrderStepID - OrderStep to use
302 301
      *
@@ -335,7 +334,7 @@  discard block
 block discarded – undo
335 334
      *
336 335
      * @param bool $isCurrentStep
337 336
      *
338
-     * @return Checkout_StepDescription
337
+     * @return CheckoutPage_StepDescription
339 338
      */
340 339
     public function CurrentCheckoutStep($isCurrentStep = false)
341 340
     {
@@ -687,7 +686,7 @@  discard block
 block discarded – undo
687 686
      * checking to see if IsFeedbackEnabled is true
688 687
      * first of all.
689 688
      *
690
-     * @return OrderForm_Feedback
689
+     * @return OrderConfirmationPage_Controller|null
691 690
      */
692 691
     public function FeedbackForm()
693 692
     {
Please login to merge, or discard this patch.
code/api/ShoppingCart.php 1 patch
Doc Comments   +18 added lines, -17 removed lines patch added patch discarded remove patch
@@ -350,8 +350,8 @@  discard block
 block discarded – undo
350 350
      * Adds any number of items to the cart.
351 351
      * Returns the order item on succes OR false on failure.
352 352
      *
353
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
354
-     * @param float      $quantity   - number of items add.
353
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
354
+     * @param integer      $quantity   - number of items add.
355 355
      * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
356 356
      *                                 if you make it a form, it will save the form into the orderitem
357 357
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
      *
399 399
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
400 400
      *
401
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
401
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
402 402
      * @param float      $quantity   - number of items add.
403 403
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
404 404
      *
@@ -428,8 +428,8 @@  discard block
 block discarded – undo
428 428
      *
429 429
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
430 430
      *
431
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
432
-     * @param float      $quantity   - number of items add.
431
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
432
+     * @param integer      $quantity   - number of items add.
433 433
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
434 434
      *
435 435
      * @return false | OrderItem | null
@@ -467,7 +467,7 @@  discard block
 block discarded – undo
467 467
      *
468 468
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
469 469
      *
470
-     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart
470
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
471 471
      * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
472 472
      *
473 473
      * @return bool | item | null - successfully removed
@@ -494,9 +494,8 @@  discard block
 block discarded – undo
494 494
     /**
495 495
      * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
496 496
      *
497
-     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart
498
-     * @param float         $quantity            - number of items add.
499
-     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
497
+     * @param BuyableModel    $buyable             - the buyable (generally a product) being added to the cart
498
+     * @param bool          $mustBeExistingItem - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
500 499
      * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
501 500
      *                                           - form saved into item...
502 501
      *
@@ -564,7 +563,7 @@  discard block
 block discarded – undo
564 563
      * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
565 564
      * NOTE: does not write!
566 565
      *
567
-     * @param DataObject $buyable
566
+     * @param BuyableModel $buyable
568 567
      * @param array      $parameters
569 568
      *
570 569
      * @return OrderItem
@@ -626,7 +625,7 @@  discard block
 block discarded – undo
626 625
     /**
627 626
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
628 627
      *
629
-     * @return bool | null
628
+     * @return boolean|null | null
630 629
      */
631 630
     public function save()
632 631
     {
@@ -690,7 +689,7 @@  discard block
 block discarded – undo
690 689
      *
691 690
      * @param OrderModifier $modifier
692 691
      *
693
-     * @return bool | null
692
+     * @return boolean|null | null
694 693
      */
695 694
     public function removeModifier(OrderModifier $modifier)
696 695
     {
@@ -722,8 +721,9 @@  discard block
 block discarded – undo
722 721
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
723 722
      *
724 723
      * @param Int/ OrderModifier
724
+     * @param integer $modifier
725 725
      *
726
-     * @return bool
726
+     * @return boolean|null
727 727
      */
728 728
     public function addModifier($modifier)
729 729
     {
@@ -857,7 +857,7 @@  discard block
 block discarded – undo
857 857
      *
858 858
      * @param string - $countryCode
859 859
      *
860
-     * @return bool
860
+     * @return boolean|null
861 861
      **/
862 862
     public function setCountry($countryCode)
863 863
     {
@@ -879,6 +879,7 @@  discard block
 block discarded – undo
879 879
      * sets region in order so that modifiers can be recalculated, etc...
880 880
      *
881 881
      * @param int | String - $regionID you can use the ID or the code.
882
+     * @param integer $regionID
882 883
      *
883 884
      * @return bool
884 885
      **/
@@ -1021,7 +1022,7 @@  discard block
 block discarded – undo
1021 1022
     /**
1022 1023
      * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
1023 1024
      *
1024
-     * @param $message - the message, which could be a notification of successful action, or reason for failure
1025
+     * @param string $message - the message, which could be a notification of successful action, or reason for failure
1025 1026
      * @param $type - please use good, bad, warning
1026 1027
      */
1027 1028
     public function addMessage($message, $status = 'good')
@@ -1047,7 +1048,7 @@  discard block
 block discarded – undo
1047 1048
     /**
1048 1049
      * Gets an existing order item based on buyable and passed parameters.
1049 1050
      *
1050
-     * @param DataObject $buyable
1051
+     * @param BuyableModel $buyable
1051 1052
      * @param array      $parameters
1052 1053
      *
1053 1054
      * @return OrderItem | null
@@ -1073,7 +1074,7 @@  discard block
 block discarded – undo
1073 1074
     /**
1074 1075
      * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
1075 1076
      *
1076
-     * @param array $parameters
1077
+     * @param array $params
1077 1078
      *
1078 1079
      * @return cleaned array
1079 1080
      */
Please login to merge, or discard this patch.
code/model/process/OrderProcessQueue.php 1 patch
Doc Comments   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
      * META METHOD: Add an order to the job list if it does not exist already.
153 153
      *
154 154
      * @param Order $order
155
-     * @param Int   $deferInSeconds
155
+     * @param Int   $deferTimeInSeconds
156 156
      */
157 157
     public function AddOrderToQueue($order, $deferTimeInSeconds)
158 158
     {
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
      *
185 185
      *
186 186
      * @param  Order $order optional
187
-     * @return boolean | string
187
+     * @return boolean|string | string
188 188
      */
189 189
     public function process($order = null)
190 190
     {
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
      *
245 245
      * @param  Order $order
246 246
      *
247
-     * @return null |   OrderProcessQueue
247
+     * @return DataObject |   OrderProcessQueue
248 248
      */
249 249
     public function getQueueObject($order)
250 250
     {
@@ -301,7 +301,6 @@  discard block
 block discarded – undo
301 301
 
302 302
     /**
303 303
      * META METHOD: all orders with a queue object
304
-     * @param int $id force this Order to be processed
305 304
      * @param int $limit total number of orders that can be retrieved at any one time
306 305
      *
307 306
      * @return DataList (of orders)
@@ -467,7 +466,7 @@  discard block
 block discarded – undo
467 466
 
468 467
     /**
469 468
      * sort phrase for orders, based in order IDs...
470
-     * @param  array $orderIds
469
+     * @param  array $orderIDs
471 470
      * @return string
472 471
      */
473 472
     protected function sortPhraseForOrderIDs($orderIDs)
Please login to merge, or discard this patch.
code/tasks/EcommerceTaskArchiveAllOrdersWithItems.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -100,6 +100,11 @@
 block discarded – undo
100 100
         }
101 101
     }
102 102
 
103
+    /**
104
+     * @param DataObject $lastOrderStep
105
+     * @param string $orderStatusLogClassName
106
+     * @param integer $offset
107
+     */
103 108
     public function getOrdersForCreateSubmissionLogForArchivedOrders($lastOrderStep, $orderStatusLogClassName, $offset)
104 109
     {
105 110
         return Order::get()
Please login to merge, or discard this patch.