sunnysideup / silverstripe-ecommerce

code/CartPage.php

<?php

/**
 * @description: This is a page that shows the cart content,
 * without "leading to" checking out. That is, there is no "next step" functionality
 * or a way to submit the order.
 * NOTE: both the Account and the Checkout Page extend from this class as they
 * share some functionality.
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: Pages
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class CartPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $icon = 'ecommerce/images/icons/CartPage';

The property $icon is not used and could be removed.

    /**
     * Standard SS variable.
     *
     * @var array
     */
    private static $db = array(

The property $db is not used and could be removed.

        'ContinueShoppingLabel' => 'Varchar(100)',
        'ProceedToCheckoutLabel' => 'Varchar(100)',
        'ShowAccountLabel' => 'Varchar(100)',
        'CurrentOrderLinkLabel' => 'Varchar(100)',
        'LoginToOrderLinkLabel' => 'Varchar(100)',
        'SaveOrderLinkLabel' => 'Varchar(100)',
        'LoadOrderLinkLabel' => 'Varchar(100)',
        'DeleteOrderLinkLabel' => 'Varchar(100)',
        'NoItemsInOrderMessage' => 'HTMLText',
        'NonExistingOrderMessage' => 'HTMLText'
    );

    /**
     * Standard SS variable.
     *
     * @var array
     */
    private static $defaults = array(

The property $defaults is not used and could be removed.

        'ContinueShoppingLabel' => 'continue shopping',
        'ProceedToCheckoutLabel' => 'proceed to checkout',
        'ShowAccountLabel' => 'view account details',
        'CurrentOrderLinkLabel' => 'view current order',
        'LoginToOrderLinkLabel' => 'you must log in to view this order',
        'SaveOrderLinkLabel' => 'save current order',
        'DeleteOrderLinkLabel' => 'delete this order',
        'LoadOrderLinkLabel' => 'finalise this order',
        'NoItemsInOrderMessage' => '<p>You do not have any items in your current order.</p>',
        'NonExistingOrderMessage' => '<p>Sorry, the order you are trying to open does not exist.</p>',
    );

    /**
     * Standard SS variable.
     *
     * @var array
     */
    private static $casting = array(

The property $casting is not used and could be removed.

        'MenuTitle' => 'HTMLVarchar',
    );

    /**
     * Standard SS variable.
     */
    private static $singular_name = 'Cart Page';

The property $singular_name is not used and could be removed.

    public function i18n_singular_name()
    {
        return _t('CartPage.SINGULARNAME', 'Cart Page');
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = 'Cart Pages';

The property $plural_name is not used and could be removed.

    public function i18n_plural_name()
    {
        return _t('CartPage.PLURALNAME', 'Cart Pages');
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $description = 'A page where the customer can view the current order (cart) without finalising the order.';

The property $description is not used and could be removed.

    /***
     * override core function to turn "checkout" into "Checkout (1)"
     * @return DBField
     */
    public function obj($fieldName, $arguments = null, $forceReturnedObject = true, $cache = false, $cacheName = null)
    {
        if ($fieldName == 'MenuTitle' && !($this instanceof OrderConfirmationPage)) {
            return DBField::create_field('HTMLVarchar', strip_tags($this->EcommerceMenuTitle()), 'MenuTitle', $this);
        } else {
            return parent::obj($fieldName);
        }
    }

    /**
     * Standard SS function, we only allow for one CartPage page to exist
     * but we do allow for extensions to exist at the same time.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return CartPage::get()->Filter(array('ClassName' => 'CartPage'))->Count() ? false : $this->canEdit($member);
    }

    /**
     * Shop Admins can edit.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canEdit($member = null)
    {
        if (Permission::checkMember($member, Config::inst()->get('EcommerceRole', 'admin_permission_code'))) {
            return true;
        }

        return parent::canEdit($member);
    }

    /**
     * Standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canDelete($member = null)
    {
        return $this->canEdit($member);
    }

    /**
     * Standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canPublish($member = null)
    {
        return $this->canEdit($member);
    }

    /**
     *@return FieldList
     **/
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldsToTab(
            'Root.Messages',
            array(
                new TabSet(
                    'Messages',
                    Tab::create(
                        'Actions',
                        _t('CartPage.ACTIONS', 'Actions'),
                        new TextField('ContinueShoppingLabel', _t('CartPage.CONTINUESHOPPINGLABEL', 'Label on link to continue shopping - e.g. click here to continue shopping')),
                        new TextField('ProceedToCheckoutLabel', _t('CartPage.PROCEEDTOCHECKOUTLABEL', 'Label on link to proceed to checkout - e.g. click here to finalise your order')),
                        new TextField('ShowAccountLabel', _t('CartPage.SHOWACCOUNTLABEL', 'Label on the link \'view account details\' - e.g. click here to view your account details')),
                        new TextField('CurrentOrderLinkLabel', _t('CartPage.CURRENTORDERLINKLABEL', 'Label for the link pointing to the current order - e.g. click here to view current order')),
                        new TextField('LoginToOrderLinkLabel', _t('CartPage.LOGINTOORDERLINKLABEL', 'Label for the link pointing to the order which requires a log in - e.g. you must login to view this order')),
                        new TextField('SaveOrderLinkLabel', _t('CartPage.SAVEORDERLINKLABEL', 'Label for the saving an order - e.g. click here to save current order')),
                        new TextField('LoadOrderLinkLabel', _t('CartPage.LOADORDERLINKLABEL', 'Label for the loading an order into the cart - e.g. click here to finalise this order')),
                        new TextField('DeleteOrderLinkLabel', _t('CartPage.DELETEORDERLINKLABEL', 'Label for the deleting an order - e.g. click here to delete this order'))
                    ),
                    Tab::create(
                        'Errors',
                        _t('CartPage.ERRORS', 'Errors'),
                        $htmlEditorField1 = new HTMLEditorField('NoItemsInOrderMessage', _t('CartPage.NOITEMSINORDERMESSAGE', 'No items in order - shown when the customer tries to view an order without items.')),
                        $htmlEditorField2 = new HTMLEditorField('NonExistingOrderMessage', _t('CartPage.NONEXISTINGORDERMESSAGE', 'Non-existing Order - shown when the customer tries to load a non-existing order.'))
                    )
                ),
            )
        );
        $htmlEditorField1->setRows(3);
        $htmlEditorField2->setRows(3);

        return $fields;
    }

    /**
     * Returns the Link to the CartPage on this site.
     * @param string $action [optional]

Should the type for parameter $action not be string|null?

     * @return string (URLSegment)
     */
    public static function find_link($action = null)
    {
        $page = DataObject::get_one('CartPage', array('ClassName' => 'CartPage'));
        if ($page) {
            return $page->Link($action);
        } else {
            return CheckoutPage::find_link($action);
        }
    }

    /**
     * Returns the "new order" link.
     *
     * @param int | String $orderID - not used in CartPage
     *
     * @return string (URLSegment)
     */
    public static function new_order_link($orderID)
    {
        return self::find_link().'startneworder/';
    }

    /**
     * Returns the "copy order" link.
     *
     * @param int | String $orderID - not used in CartPage
     *
     * @return string (URLSegment)
     */
    public static function copy_order_link($orderID)
    {
        return OrderConfirmationPage::find_link().'copyorder/'.$orderID.'/';
    }

    /**
     * Return a link to view the order on this page.
     *
     * @param int|string $orderID ID of the order
     *
     * @return int | String (URLSegment)

Should the return type not be string?

     */
    public static function get_order_link($orderID)
    {
        return self::find_link().'showorder/'.$orderID.'/';
    }

    /**
     * Return a link to view the order on this page.
     *
     * @param int|string $orderID ID of the order
     *
     * @return string (URLSegment)
     */
    public function getOrderLink($orderID)
    {
        return self::get_order_link($orderID);
    }

    /**
     * tells us if the current page is part of e-commerce.
     *
     * @return bool
     */
    public function IsEcommercePage()
    {
        return true;
    }

    /**
     *@return string (HTML Snippet)
     **/
    public function EcommerceMenuTitle()
    {
        $count = 0;

$count is not used, you could remove the assignment.

        $order = ShoppingCart::current_order();
        if ($order) {
            $count = $order->TotalItems();
            $oldSSViewer = Config::inst()->get('SSViewer', 'source_file_comments');
            Config::inst()->update('SSViewer', 'source_file_comments', false);
            $this->customise(array('Count' => $count, 'OriginalMenuTitle' => $this->MenuTitle));
            $s = $this->renderWith('AjaxNumItemsInCart');
            Config::inst()->update('SSViewer', 'source_file_comments', $oldSSViewer);

            return $s;
        }

        return $this->OriginalMenuTitle();
    }

    /**
     * The original menu title of the page.
     *
     * @return string
     */
    public function OriginalMenuTitle()
    {
        return $this->MenuTite;
    }

    /***********************
     * For use in templates
     ***********************/

    /**
     * standard SS method for use in templates.
     *
     * @return string
     */
    public function LinkingMode()
    {
        return parent::LinkingMode().' cartlink cartlinkID_'.$this->ID;
    }

    /**
     * standard SS method for use in templates.
     *
     * @return string
     */
    public function LinkOrSection()
    {
        return parent::LinkOrSection().' cartlink';
    }

    /**
     * standard SS method for use in templates.
     *
     * @return string
     */
    public function LinkOrCurrent()
    {
        return parent::LinkOrCurrent().' cartlink';
    }
}

class CartPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @static array
     * standard SS variable
     * it is important that we list all the options here
     */
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        'saveorder',
        'CreateAccountForm',
        'retrieveorder',
        'loadorder',
        'deleteorder',
        'startneworder',
        'showorder',
        'share',
        'LoginForm'
    );

    /**
     * This ArraList holds DataObjects with a Link and Title each....
     *
     * @var ArraList
     **/
    protected $actionLinks = null;

    /**
     * to ensure messages and actions links are only worked out once...
     *
     * @var Boolean
     **/
    protected $workedOutMessagesAndActions = false;

    /**
     * order currently being shown on this page.
     *
     * @var DataObject
     **/
    protected $currentOrder = null;

    /**
     * Message shown (e.g. no current order, could not find order, order updated, etc...).
     *
     *@var String
     * @todo: check if we need this....!
     **/
    private $message = '';
    public static function set_message($s)
    {
        $sessionCode = EcommerceConfig::get('CartPage_Controller', 'session_code');
        Session::set($sessionCode, $s);
    }

    /**
     * show the order even if canView returns false.
     *
     * @var bool
     */
    protected $overrideCanView = false;

    /**
     * @standard SS method
     */
    public function init()

init uses the super-global variable $_REQUEST which is generally not recommended.

    {
        HTTP::set_cache_age(0);
        parent::init();
        // find the current order if any
        $orderID = 0;

$orderID is not used, you could remove the assignment.

        //WE HAVE THIS FOR SUBMITTING FORMS!
        if (isset($_REQUEST['OrderID'])) {
            $orderID = intval($_REQUEST['OrderID']);
            if ($orderID) {
                $this->currentOrder = Order::get()->byID($orderID);
            }
        } elseif ($this->request && $this->request->param('ID') && $this->request->param('Action')) {
            //we can not do intval here!
            $id = $this->request->param('ID');
            $action = $this->request->param('Action');
            $otherID = intval($this->request->param('OtherID'));
            //the code below is for submitted orders, but we still put it here so
            //we can do all the retrieval options at once.
            if (($action == 'retrieveorder') && $id && $otherID) {
                $sessionID = Convert::raw2sql($id);
                $retrievedOrder = Order::get()->filter(
                    array(
                        'SessionID' => $sessionID,
                        'ID' => $otherID,
                    )
                )->first();
                if ($retrievedOrder) {
                    $this->currentOrder = $retrievedOrder;
                    $this->overrideCanView = true;
                    $this->setRetrievalOrderID($this->currentOrder->ID);
                }
            } elseif (intval($id) && in_array($action, $this->stat('allowed_actions'))) {
                $this->currentOrder = Order::get()->byID(intval($id));
            }
        }
        if (!$this->currentOrder) {
            $this->currentOrder = ShoppingCart::current_order();
            if ($this->currentOrder) {
                if ($this->currentOrder->IsSubmitted()) {
                    $this->overrideCanView = true;
                }
            }
        }
        //redirect if we are viewing the order with the wrong page!
        if ($this->currentOrder) {
            if ($this->overrideCanView) {
                $canView = $this->currentOrder->canOverrideCanView();

The method canOverrideCanView() does not exist on DataObject. Did you maybe mean canView()?

            } else {
                $canView = $this->currentOrder->canView();
            }
            //IMPORTANT SECURITY QUESTION!
            if ($canView) {
                if ($this->currentOrder->IsSubmitted() && $this->onlyShowUnsubmittedOrders()) {
                    $this->redirect($this->currentOrder->Link());
                } elseif ((!$this->currentOrder->IsSubmitted()) && $this->onlyShowSubmittedOrders()) {
                    $this->redirect($this->currentOrder->Link());
                }
            } else {
                if (!$this->LoginToOrderLinkLabel) {
                    $this->LoginToOrderLinkLabel = _t('CartPage.LOGINFIRST', 'You will need to log in before you can access the requested order order. ');
                }
                $messages = array(
                    'default' => '<p class="message good">'.$this->LoginToOrderLinkLabel.'</p>',
                    'logInAgain' => _t('CartPage.LOGINAGAIN', 'You have been logged out. If you would like to log in again, please do so below.'),
                );
                Security::permissionFailure($this, $messages);

                return false;
            }
            if (!$this->currentOrder->IsSubmitted()) {
                //we always want to make sure the order is up-to-date.
                $this->currentOrder->init($force = false);
                $this->currentOrder->calculateOrderAttributes($force = true);
                $this->currentOrder->calculateOrderAttributes($force = true);
            }
        } else {
            $this->message = _t('CartPage.ORDERNOTFOUND', 'Order can not be found.');
        }
    }


    /**
     * We set sesssion ID for retrieval of order in non cart setting
     * @param int $orderID
     * @param int $validUntilTS timestamp (unix epoch) until which the current Order ID is valid

Should the type for parameter $validUntilTS not be integer|null?

     */
    protected function setRetrievalOrderID($orderID, $validUntilTS = null)
    {
        if (! $validUntilTS) {

The expression $validUntilTS of type integer|null is loosely compared to false; this is ambiguous if the integer can be zero. You might want to explicitly use === null instead.

            $validUntilTS = time() + 3600;
        }
        Session::set('CheckoutPageCurrentOrderID', $orderID);
        Session::set('CheckoutPageCurrentRetrievalTime', $validUntilTS);
        Session::save();
    }

    /**
     * we clear the retrieval Order ID
     */
    protected function clearRetrievalOrderID()
    {
        Session::clear('CheckoutPageCurrentOrderID');
        Session::set('CheckoutPageCurrentOrderID', 0);
        Session::clear('CheckoutPageCurrentRetrievalTime');
        Session::set('CheckoutPageCurrentRetrievalTime', 0);
        Session::save();
    }

    /***********************
     * Actions
     ***********************




    /**
     * shows an order and loads it if it is not submitted.
     * @todo: do we still need loadorder controller method????
     * @param SS_HTTPRequest
     * @return array just so that template shows
     **/
    public function showorder(SS_HTTPRequest $request)
    {
        if (!$this->currentOrder) {
            $this->message = _t('CartPage.ORDERNOTFOUND', 'Order can not be found.');
        } else {
            if (!$this->currentOrder->IsSubmitted()) {
                $shoppingCart = ShoppingCart::current_order();
                if ($shoppingCart->ID != $this->currentOrder->ID) {
                    if (ShoppingCart::singleton()->loadOrder($this->currentOrder)) {
                        $this->message = _t('CartPage.ORDERHASBEENLOADED', 'Order has been loaded.');
                    } else {
                        $this->message = _t('CartPage.ORDERNOTLOADED', 'Order could not be loaded.');
                    }
                }
            }
        }

        return array();
    }

    /**
     * share an order ...
     * @todo: do we still need loadorder controller method????
     * @param SS_HTTPRequest
     * @return array just so that template shows
     **/
    public function share(SS_HTTPRequest $request)
    {
        $codes = Convert::raw2sql($request->param('ID'));
        if (! $request->getVar('ready') && ! $request->getVar('done')) {
            return $this->redirect($this->Link('share/'.$codes).'?ready=1');
        }
        $titleAppendixArray = array();
        $buyables = explode('-', $codes);
        if (count($buyables)) {
            $sc = ShoppingCart::singleton();
            $order = $sc->currentOrder();
            foreach ($buyables as $buyable) {
                $details = explode(",", $buyable);
                if (count($details) == 3) {
                    $className = $details[0];
                    $className = class_exists($className) ? $className : null;
                    $id = intval($details[1]);
                    $quantity = floatval($details[2]);
                    if ($className && $id && $quantity) {
                        $buyable = $className::get()->byID($id);
                        if ($buyable && $buyable->canPurchase()) {
                            $sc->addBuyable($buyable, $quantity);
                            $sc->setQuantity($buyable, $quantity);
                            if ($request->getVar('done')) {
                                $titleAppendixArray[] = $buyable->getTitle();
                            }
                        }
                    }
                }
            }
            $order->calculateOrderAttributes(false);
            if (! $request->getVar('done')) {
                return $this->redirect($this->Link('share/'.$codes).'?done=1');
            }
        }
        $this->Title .= ': '.  implode(', ', $titleAppendixArray);
        if (strlen($this->Title) > 255) {
            $this->Title = substr($this->Title, 0, 255). ' ...';
        }
        return array();
    }

    /**
     * Loads either the "current order""into the shopping cart.
     *
     * TO DO: untested
     * TO DO: what to do with old order
     *
     * @param SS_HTTPRequest
     *
     * @return array
     */
    public function loadorder(SS_HTTPRequest $request)
    {
        self::set_message(_t('CartPage.ORDERLOADED', 'Order has been loaded.'));
        ShoppingCart::singleton()->loadOrder($this->currentOrder->ID);
        $this->redirect($this->Link());

        return array();
    }

    /**
     * save the order to a member. If no member exists then create the member first using the ShopAccountForm.
     *
     * @param SS_HTTPRequest
     *
     * @return array
     *               TO DO: untested
     */
    public function saveorder(SS_HTTPRequest $request)
    {
        $member = Member::currentUser();
        if (!$member) {
            $this->showCreateAccountForm = true;

            return array();
        }
        if ($this->currentOrder && $this->currentOrder->getTotalItems()) {
            $this->currentOrder->write();
            self::set_message(_t('CartPage.ORDERSAVED', 'Your order has been saved.'));
        } else {
            self::set_message(_t('CartPage.ORDERCOULDNOTBESAVED', 'Your order could not be saved.'));
        }
        $this->redirectBack();

        return array();
    }

    /**
     * Delete the currently viewed order.
     *
     * TO DO: untested
     *
     * @param SS_HTTPRequest
     *
     * @return array
     */
    public function deleteorder(SS_HTTPRequest $request)
    {
        if (!$this->CurrentOrderIsInCart()) {
            if ($this->currentOrder->canDelete()) {
                $this->currentOrder->delete();
                self::set_message(_t('CartPage.ORDERDELETED', 'Order has been deleted.'));
            }
        }
        self::set_message(_t('CartPage.ORDERNOTDELETED', 'Order could not be deleted.'));

        return array();
    }

    /**
     * Start a new order.
     *
     * @param SS_HTTPRequest
     *
     * @return array
     *               TO DO: untested
     */
    public function startneworder(SS_HTTPRequest $request)
    {
        ShoppingCart::singleton()->clear();
        self::set_message(_t('CartPage.NEWORDERSTARTED', 'New order has been started.'));
        $this->redirect($this->Link());

        return array();
    }

    /**
     * This returns a ArraList, each dataobject has two vars: Title and Link.
     *
     * @return ArraList

Should the return type not be ArraList|null?

     **/
    public function ActionLinks()
    {
        $this->workOutMessagesAndActions();
        if ($this->actionLinks && $this->actionLinks->count()) {
            return $this->actionLinks;
        }

        return;
    }


    /**
     * The link that Google et al. need to index.
     * @return string
     */
    public function CanonicalLink()
    {
        $link = $checkoutPageLink = CheckoutPage::find_link();

$checkoutPageLink is not used, you could remove the assignment.

        $this->extend('UpdateCanonicalLink', $link);
        
        return $link;
    }


    /**
     * @return string

Should the return type not be DBField?

     **/
    public function Message()
    {
        $this->workOutMessagesAndActions();
        if (!$this->message) {
            $sessionCode = EcommerceConfig::get('CartPage_Controller', 'session_code');
            if ($sessionMessage = Session::get($sessionCode)) {
                $this->message = $sessionMessage;
                Session::set($sessionCode, '');
                Session::clear($sessionCode);
            }
        }
        $field = DBField::create_field('HTMLText', $this->message);

        return $field;
    }

    /**
     * @return DataObject | Null - Order
     **/
    public function Order()
    {
        return $this->currentOrder;
    }

    /**
     * @return bool
     **/
    public function CanEditOrder()
    {
        if ($this->currentOrder) {
            if ($this->currentOrder->canEdit()) {
                if ($this->currentOrder->getTotalItems()) {
                    return true;
                }
            }
        }

        return false;
    }

    /**
     * Tells you if the order you are viewing at the moment is also in the cart.
     *
     * @return bool
     **/
    public function CurrentOrderIsInCart()
    {
        $viewingRealCurrentOrder = false;
        $realCurrentOrder = ShoppingCart::current_order();
        if ($this->currentOrder && $realCurrentOrder) {
            if ($realCurrentOrder->ID == $this->currentOrder->ID) {
                $viewingRealCurrentOrder = true;
            }
        }

        return $viewingRealCurrentOrder;
    }

    /**
     * @var bool
     */
    protected $showCreateAccountForm = false;

    /**
     * Do we need to show the Create Account Form?
     *
     * @return bool
     */
    public function ShowCreateAccountForm()
    {
        if (Session::get('CartPageCreateAccountForm')) {
            Session::set('CartPageCreateAccountForm', false);

false is of type boolean, but the function expects a string.

            return true;
        }
        if (Member::currentUser() || $this->currentOrder->MemberID) {
            return false;
        } else {
            Session::set('CartPageCreateAccountForm', true);

true is of type boolean, but the function expects a string.

            return true;
        }
    }

    /**
     * Returns the CreateAccountForm.
     *
     * @return ShopAccountForm
     */
    public function CreateAccountForm()
    {
        return ShopAccountForm::create($this, 'CreateAccountForm');
    }

    /**
     * work out the options for the user.
     **/
    protected function workOutMessagesAndActions()
    {
        if (!$this->workedOutMessagesAndActions) {
            $this->actionLinks = new ArrayList(array());

It seems like new \ArrayList(array()) of type object<ArrayList> is incompatible with the declared type object<ArraList> of property $actionLinks.

            //what order are we viewing?
            $viewingRealCurrentOrder = $this->CurrentOrderIsInCart();
            $currentUserID = Member::currentUserID();

            //Continue Shopping
            if (isset($this->ContinueShoppingLabel) && $this->ContinueShoppingLabel) {
                if ($viewingRealCurrentOrder) {
                    if ($this->isCartPage()) {
                        $continueLink = $this->ContinueShoppingLink();
                        if ($continueLink) {
                            $this->actionLinks->push(
                                ArrayData::create(
                                    array(
                                        'Title' => $this->ContinueShoppingLabel,
                                        'Link' => $continueLink,
                                    )
                                )
                            );
                        }
                    }
                }
            }

            //Proceed To CheckoutLabel
            if (isset($this->ProceedToCheckoutLabel) && $this->ProceedToCheckoutLabel) {
                if ($viewingRealCurrentOrder) {
                    if ($this->isCartPage()) {
                        $checkoutPageLink = CheckoutPage::find_link();
                        if ($checkoutPageLink && $this->currentOrder && $this->currentOrder->getTotalItems()) {
                            $this->actionLinks->push(new ArrayData(array(
                                'Title' => $this->ProceedToCheckoutLabel,
                                'Link' => $checkoutPageLink,
                            )));
                        }
                    }
                }
            }

            //view account details
            if (isset($this->ShowAccountLabel) && $this->ShowAccountLabel) {
                if ($this->isOrderConfirmationPage() || $this->isCartPage()) {
                    if (AccountPage::find_link()) {
                        if ($currentUserID) {
                            $this->actionLinks->push(new ArrayData(array(
                                'Title' => $this->ShowAccountLabel,
                                'Link' => AccountPage::find_link(),
                            )));
                        }
                    }
                }
            }
            //go to current order
            if (isset($this->CurrentOrderLinkLabel) && $this->CurrentOrderLinkLabel) {
                if ($this->isCartPage()) {
                    if (!$viewingRealCurrentOrder) {
                        $this->actionLinks->push(new ArrayData(array(
                            'Title' => $this->CurrentOrderLinkLabel,
                            'Link' => ShoppingCart::current_order()->Link(),
                        )));
                    }
                }
            }

            //Save order - we assume only current ones can be saved.
            if (isset($this->SaveOrderLinkLabel) && $this->SaveOrderLinkLabel) {
                if ($viewingRealCurrentOrder) {
                    if ($currentUserID && $this->currentOrder->MemberID == $currentUserID) {
                        if ($this->isCartPage()) {
                            if ($this->currentOrder && $this->currentOrder->getTotalItems() && !$this->currentOrder->IsSubmitted()) {
                                $this->actionLinks->push(new ArrayData(array(
                                    'Title' => $this->SaveOrderLinkLabel,
                                    'Link' => $this->Link('saveorder').'/'.$this->currentOrder->ID.'/',
                                )));
                            }
                        }
                    }
                }
            }

            //load order
            if (isset($this->LoadOrderLinkLabel) && $this->LoadOrderLinkLabel) {
                if ($this->isCartPage() && $this->currentOrder) {
                    if (!$viewingRealCurrentOrder) {
                        $this->actionLinks->push(new ArrayData(array(
                            'Title' => $this->LoadOrderLinkLabel,
                            'Link' => $this->Link('loadorder').'/'.$this->currentOrder->ID.'/',
                        )));
                    }
                }
            }

            //delete order
            if (isset($this->DeleteOrderLinkLabel) && $this->DeleteOrderLinkLabel) {
                if ($this->isCartPage() && $this->currentOrder) {
                    if (!$viewingRealCurrentOrder) {
                        $this->actionLinks->push(new ArrayData(array(
                            'Title' => $this->DeleteOrderLinkLabel,
                            'Link' => $this->Link('deleteorder').'/'.$this->currentOrder->ID.'/',
                        )));
                    }
                }
            }

            //Start new order
            //Strictly speaking this is only part of the
            //OrderConfirmationPage but we put it here for simplicity's sake
            if (isset($this->StartNewOrderLinkLabel) && $this->StartNewOrderLinkLabel) {
                if ($this->isOrderConfirmationPage()) {
                    $this->actionLinks->push(new ArrayData(array(
                        'Title' => $this->StartNewOrderLinkLabel,
                        'Link' => CartPage::new_order_link($this->currentOrder->ID),
                    )));
                }
            }

            //copy order
            //Strictly speaking this is only part of the
            //OrderConfirmationPage but we put it here for simplicity's sake
            if (isset($this->CopyOrderLinkLabel) && $this->CopyOrderLinkLabel) {
                if ($this->isOrderConfirmationPage() && $this->currentOrder->ID) {
                    $this->actionLinks->push(new ArrayData(array(
                        'Title' => $this->CopyOrderLinkLabel,
                        'Link' => OrderConfirmationPage::copy_order_link($this->currentOrder->ID),
                    )));
                }
            }

            //actions from modifiers
            if ($this->isOrderConfirmationPage() && $this->currentOrder->ID) {
                $modifiers = $this->currentOrder->Modifiers();
                if ($modifiers->count()) {
                    foreach ($modifiers as $modifier) {
                        $array = $modifier->PostSubmitAction();
                        if (is_array($array) && count($array)) {
                            $this->actionLinks->push(new ArrayData($array));
                        }
                    }
                }
            }

            //log out
            //Strictly speaking this is only part of the
            //OrderConfirmationPage but we put it here for simplicity's sake
            if (Member::currentUser()) {
                if ($this->isOrderConfirmationPage()) {
                    $this->actionLinks->push(new ArrayData(array(
                        'Title' => _t('CartPage.LOGOUT', 'log out'),
                        'Link' => '/Security/logout/',
                    )));
                }
            }

            //no items
            if ($this->currentOrder) {
                if (!$this->currentOrder->getTotalItems()) {
                    $this->message = $this->NoItemsInOrderMessage;
                }
            } else {
                $this->message = $this->NonExistingOrderMessage;
            }

            $this->workedOutMessagesAndActions = true;
            //does nothing at present....
        }
    }

    /***********************
     * HELPER METHOD (PROTECTED)
     ***********************






    /**
     * Is this a CartPage or is it another type (Checkout / OrderConfirmationPage)?
     * @return Boolean
     */
    protected function isCartPage()
    {
        if (($this->isCheckoutPage()) || ($this->isOrderConfirmationPage())) {

This if statement, and the following return statement can be replaced with return !($this->isCheckoutPage() || $this->isOrderConfirmationPage());.

            return false;
        }

        return true;
    }

    /**
     * Is this a CheckoutPage or is it another type (CartPage / OrderConfirmationPage)?
     *
     * @return bool
     */
    protected function isCheckoutPage()
    {
        if ($this->dataRecord instanceof CheckoutPage) {

The if-else statement can be simplified to return $this->dataRecord instanceof \CheckoutPage;.

            return true;
        } else {
            return false;
        }
    }

    /**
     * Is this a OrderConfirmationPage or is it another type (CartPage / CheckoutPage)?
     *
     * @return bool
     */
    protected function isOrderConfirmationPage()
    {
        if ($this->dataRecord instanceof OrderConfirmationPage) {

The if-else statement can be simplified to return $this->dataRecord instanceof \OrderConfirmationPage;.

            return true;
        } else {
            return false;
        }
    }

    /**
     * Can this page only show Submitted Orders (e.g. OrderConfirmationPage) ?
     *
     * @return bool
     */
    protected function onlyShowSubmittedOrders()
    {
        return false;
    }

    /**
     * Can this page only show Unsubmitted Orders (e.g. CartPage) ?
     *
     * @return bool
     */
    protected function onlyShowUnsubmittedOrders()
    {
        return true;
    }
}