ShopAccountForm_Validator

Complexity

Total Complexity

22

Size/Duplication

Total Lines	114
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
F	php()	0	102	22

<?php


class ShopAccountForm_Validator extends RequiredFields

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Ensures member unique id stays unique and other basic stuff...
     *
     * @param array $data               = array Form Field Data
     * @param bool  $allowExistingEmail - see comment below
     *
     * @return bool
     **/
    public function php($data, $allowExistingEmail = false)
    {
        $this->form->saveDataToSession();
        $valid = parent::php($data);
        $uniqueFieldName = Member::get_unique_identifier_field();

The method Member::get_unique_identifier_field() has been deprecated with message: 4.0 Use the "Member.unique_identifier_field" config setting instead

        $loggedInMember = Member::currentUser();
        $loggedInMemberID = 0;
        if (isset($data[$uniqueFieldName]) && $data[$uniqueFieldName]) {
            $isShopAdmin = false;
            if ($loggedInMember) {
                $loggedInMemberID = $loggedInMember->ID;
                if ($loggedInMember->IsShopAdmin()) {
                    $isShopAdmin = true;
                }
            }
            if ($isShopAdmin || $allowExistingEmail) {

This if statement is empty and can be removed.

                //do nothing
            } else {
                $uniqueFieldValue = Convert::raw2sql($data[$uniqueFieldName]);
                //can't be taken
                $otherMembersWithSameEmail = Member::get()
                    ->filter(array($uniqueFieldName => $uniqueFieldValue))
                    ->exclude(array('ID' => $loggedInMemberID));
                if ($otherMembersWithSameEmail->count()) {
                    //we allow existing email
                    // if we are currently NOT logged in
                    // in case we place an order!
                    if ($allowExistingEmail) {

This if statement is empty and can be removed.

                        //do nothing
                    } else {
                        $message = _t(
                            'Account.ALREADYTAKEN',
                            '{uniqueFieldValue} is already taken by another member. Please log in or use another {uniqueFieldName}.',
                            array('uniqueFieldValue' => $uniqueFieldValue, 'uniqueFieldName' => $uniqueFieldName)

array('uniqueFieldValue' => $uniqueFieldValue, 'uniqueFieldName' => $uniqueFieldName) is of type array<string,array|string,{"uniqueFieldValue":"array|string","uniqueFieldName":"string"}>, but the function expects a string.

                        );
                        $this->validationError(
                            $uniqueFieldName,
                            $message,
                            'required'
                        );
                        $valid = false;
                    }
                }
            }
        }
        // check password fields are the same before saving
        if (isset($data['PasswordCheck1']) && isset($data['PasswordCheck2'])) {
            if ($data['PasswordCheck1'] != $data['PasswordCheck2']) {
                $this->validationError(
                    'PasswordCheck1',
                    _t('Account.PASSWORDSERROR', 'Passwords do not match.'),
                    'required'
                );
                $valid = false;
            }
            //if you are not logged in, you have not provided a password and the settings require you to be logged in then
            //we have a problem
            if (!$loggedInMember && !$data['PasswordCheck1'] && EcommerceConfig::get('EcommerceRole', 'must_have_account_to_purchase')) {
                $this->validationError(
                    'PasswordCheck1',
                    _t('Account.SELECTPASSWORD', 'Please select a password.'),
                    'required'
                );
                $valid = false;
            }
            $letterCount = strlen($data['PasswordCheck1']);
            $minLength = Config::inst()->get('ShopAccountForm_Validator', 'minimum_password_length');
            if ($letterCount > 0 && $letterCount < $minLength) {
                $this->validationError(
                    'PasswordCheck1',
                    _t('Account.PASSWORDMINIMUMLENGTH', 'Password does not meet minimum standards.'),
                    'required'
                );
                $valid = false;
            }
        }
        if (isset($data['FirstName'])) {
            if (strlen($data['FirstName']) < 2) {
                $this->validationError(
                    'FirstName',
                    _t('Account.NOFIRSTNAME', 'Please enter your first name.'),
                    'required'
                );
                $valid = false;
            }
        }
        if (isset($data['Surname'])) {
            if (strlen($data['Surname']) < 2) {
                $this->validationError(
                    'Surname',
                    _t('Account.NOSURNAME', 'Please enter your surname.'),
                    'required'
                );
                $valid = false;
            }
        }
        if (!$valid) {
            $this->form->sessionMessage(_t('Account.ERRORINFORM', 'We could not save your details, please check your errors below.'), 'bad');
        }

        return $valid;
    }
}