OrderStep_Sent - Code Metrics - Inspection of "MINOR: message for separate shipping address" - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1552c3...bf9266 )

by Nicolaas

created 2017-10-31 08:16 UTC

OrderStep_Sent A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	183
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
dl	0
loc	183
rs	10
c	0
b	0
f	0
wmc	19
lcom	1
cbo	6

9 Methods

Rating	Name	Size	Complexity
B	getCMSFields()	24	1
A	initStep()	4	1
A	doStep()	13	3
A	nextStep()	8	3
A	addOrderStepFields()	8	1
A	hasCustomerMessage()	4	1
A	myDescription()	4	1
A	CalculatedEmailSubject()	12	4
A	CalculatedCustomerMessage()	12	4

<?php

/**
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: model
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class OrderStep_Sent extends OrderStep implements OrderStepInterface
namespace YourVendor;

class YourClass { }
{
    /**
     * @var string
     */
    protected $emailClassName = 'Order_StatusEmail';

    private static $db = array(

        'SendDetailsToCustomer' => 'Boolean',
        'EmailSubjectGift' => 'Varchar(200)',
        'CustomerMessageGift' => 'HTMLText'
    );

    private static $defaults = array(

        'CustomerCanEdit' => 0,
        'CustomerCanCancel' => 0,
        'CustomerCanPay' => 0,
        'Name' => 'Send Order',
        'Code' => 'SENT',
        'ShowAsInProcessOrder' => 1
    );

    private static $field_labels = [

        'EmailSubjectGift' => 'Email subject',
        'CustomerMessageGift' => 'Customer message'
    ];

    /**
     * The OrderStatusLog that is relevant to the particular step.
     *
     * @var string
     */
    protected $relevantLogEntryClassName = 'OrderStatusLog_DispatchPhysicalOrder';

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab('Root.Main', new HeaderField('ActuallySendDetails', _t('OrderStep.ACTUALLYSENDDETAILS', 'Send details to the customer?'), 3), 'SendDetailsToCustomer');
        $fields->addFieldsToTab(
            'Root.CustomerMessage',
            [
                HeaderField::create(
                    'GiftHeader',
                    _t('OrderStep.SEPARATE_DELIVERY', 'Message for separate shipping address ...')
                ),
                TextField::create(
                    'EmailSubjectGift',
                    _t('OrderStep.EmailSubjectGift', 'Subject')
                ),
                HTMLEditorField::create(
                    'CustomerMessageGift',
                    _t('OrderStep.CustomerMessageGift', 'Message')
                )->setRows(5)
            ]
        );

        return $fields;
    }

    /**
     *initStep:
     * makes sure the step is ready to run.... (e.g. check if the order is ready to be emailed as receipt).
     * should be able to run this function many times to check if the step is ready.
     *
     * @see Order::doNextStatus
     *
     * @param Order object
     *
     * @return bool - true if the current step is ready to be run...
     **/
    public function initStep(Order $order)
    {
        return true;
    }

    /**
     *doStep:
     * should only be able to run this function once
     * (init stops you from running it twice - in theory....)
     * runs the actual step.
     *
     * @see Order::doNextStatus
     *
     * @param Order object
     *
     * @return bool - true if run correctly.

     **/
    public function doStep(Order $order)
    {
        if ($this->RelevantLogEntry($order)) {
            return $this->sendEmailForStep(
                $order,
                $subject = $this->CalculatedEmailSubject($order),
                $message = $this->CalculatedCustomerMessage($order),
                $resend = false,
                $this->SendDetailsToCustomer ? false : true,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->getEmailClassName()
            );
        }
    }

    /**
     *nextStep:
     * returns the next step (after it checks if everything is in place for the next step to run...).
     *
     * @see Order::doNextStatus
     *
     * @param Order $order
     *
     * @return OrderStep | Null (next step OrderStep object)

     **/
    public function nextStep(Order $order)
    {
        if (!$this->SendDetailsToCustomer || $this->hasBeenSent($order)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return parent::nextStep($order);
        }

        return;
    }

    /**
     * Allows the opportunity for the Order Step to add any fields to Order::getCMSFields.
     *
     * @param FieldList $fields
     * @param Order     $order
     *
     * @return FieldList
     **/
    public function addOrderStepFields(FieldList $fields, Order $order)
    {
        $fields = parent::addOrderStepFields($fields, $order);
        $title = _t('OrderStep.MUSTENTERDISPATCHRECORD', ' ... To move this order to the next step please enter dispatch details.');
        $fields->addFieldToTab('Root.Next', $order->getOrderStatusLogsTableField('OrderStatusLog_DispatchPhysicalOrder', $title), 'ActionNextStepManually');

        return $fields;
    }

    /**
     * For some ordersteps this returns true...
     *
     * @return bool
     **/
    protected function hasCustomerMessage()
    {
        return $this->SendDetailsToCustomer;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Explains the current order step.
     *
     * @return string
     */
    protected function myDescription()
    {
        return _t('OrderStep.SENT_DESCRIPTION', 'During this step we record the delivery details for the order such as the courrier ticket number and whatever else is relevant.');
    }

    public function CalculatedEmailSubject($order = null)

    {
        $v = null;
        if($order && $order->IsSeparateShippingAddress()) {
            $v = $this->EmailSubjectGift;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if(! $v) {
            $v = $this->EmailSubject;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return $v;
    }

    public function CalculatedCustomerMessage($order = null)

    {
        $v = null;
        if($order && $order->IsSeparateShippingAddress()) {
            $v = $this->CustomerMessageGift;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if(! $v) {
            $v = $this->CustomerMessage;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return $v;
    }
}


1			<?php
2
3			/**
4			* @authors: Nicolaas [at] Sunny Side Up .co.nz
5			* @package: ecommerce
6			* @sub-package: model
7			* @inspiration: Silverstripe Ltd, Jeremy
8			**/
9			class OrderStep_Sent extends OrderStep implements OrderStepInterface
			0 ignored issues – show Coding Style Compatibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			/**
12			* @var string
13			*/
14			protected $emailClassName = 'Order_StatusEmail';
15
16			private static $db = array(
			0 ignored issues – show Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history... Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history...
17			'SendDetailsToCustomer' => 'Boolean',
18			'EmailSubjectGift' => 'Varchar(200)',
19			'CustomerMessageGift' => 'HTMLText'
20			);
21
22			private static $defaults = array(
			0 ignored issues – show Comprehensibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2016-10-31 23:06 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23			'CustomerCanEdit' => 0,
24			'CustomerCanCancel' => 0,
25			'CustomerCanPay' => 0,
26			'Name' => 'Send Order',
27			'Code' => 'SENT',
28			'ShowAsInProcessOrder' => 1
29			);
30
31			private static $field_labels = [
			0 ignored issues – show Comprehensibility introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
32			'EmailSubjectGift' => 'Email subject',
33			'CustomerMessageGift' => 'Customer message'
34			];
35
36			/**
37			* The OrderStatusLog that is relevant to the particular step.
38			*
39			* @var string
40			*/
41			protected $relevantLogEntryClassName = 'OrderStatusLog_DispatchPhysicalOrder';
42
43			public function getCMSFields()
44			{
45			$fields = parent::getCMSFields();
46			$fields->addFieldToTab('Root.Main', new HeaderField('ActuallySendDetails', _t('OrderStep.ACTUALLYSENDDETAILS', 'Send details to the customer?'), 3), 'SendDetailsToCustomer');
47			$fields->addFieldsToTab(
48			'Root.CustomerMessage',
49			[
50			HeaderField::create(
51			'GiftHeader',
52			_t('OrderStep.SEPARATE_DELIVERY', 'Message for separate shipping address ...')
53			),
54			TextField::create(
55			'EmailSubjectGift',
56			_t('OrderStep.EmailSubjectGift', 'Subject')
57			),
58			HTMLEditorField::create(
59			'CustomerMessageGift',
60			_t('OrderStep.CustomerMessageGift', 'Message')
61			)->setRows(5)
62			]
63			);
64
65			return $fields;
66			}
67
68			/**
69			*initStep:
70			* makes sure the step is ready to run.... (e.g. check if the order is ready to be emailed as receipt).
71			* should be able to run this function many times to check if the step is ready.
72			*
73			* @see Order::doNextStatus
74			*
75			* @param Order object
76			*
77			* @return bool - true if the current step is ready to be run...
78			**/
79			public function initStep(Order $order)
80			{
81			return true;
82			}
83
84			/**
85			*doStep:
86			* should only be able to run this function once
87			* (init stops you from running it twice - in theory....)
88			* runs the actual step.
89			*
90			* @see Order::doNextStatus
91			*
92			* @param Order object
93			*
94			* @return bool - true if run correctly.
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
95			**/
96			public function doStep(Order $order)
97			{
98			if ($this->RelevantLogEntry($order)) {
99			return $this->sendEmailForStep(
100			$order,
101			$subject = $this->CalculatedEmailSubject($order),
102			$message = $this->CalculatedCustomerMessage($order),
103			$resend = false,
104			$this->SendDetailsToCustomer ? false : true,
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The property `SendDetailsToCustomer` does not exist on `object<OrderStep_Sent>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
105			$this->getEmailClassName()
106			);
107			}
108			}
109
110			/**
111			*nextStep:
112			* returns the next step (after it checks if everything is in place for the next step to run...).
113			*
114			* @see Order::doNextStatus
115			*
116			* @param Order $order
117			*
118			* @return OrderStep \| Null (next step OrderStep object)
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report Should the return type not be `OrderStep\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
119			**/
120			public function nextStep(Order $order)
121			{
122			if (!$this->SendDetailsToCustomer \|\| $this->hasBeenSent($order)) {
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The property `SendDetailsToCustomer` does not exist on `object<OrderStep_Sent>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
123			return parent::nextStep($order);
124			}
125
126			return;
127			}
128
129			/**
130			* Allows the opportunity for the Order Step to add any fields to Order::getCMSFields.
131			*
132			* @param FieldList $fields
133			* @param Order $order
134			*
135			* @return FieldList
136			**/
137			public function addOrderStepFields(FieldList $fields, Order $order)
138			{
139			$fields = parent::addOrderStepFields($fields, $order);
140			$title = _t('OrderStep.MUSTENTERDISPATCHRECORD', ' ... To move this order to the next step please enter dispatch details.');
141			$fields->addFieldToTab('Root.Next', $order->getOrderStatusLogsTableField('OrderStatusLog_DispatchPhysicalOrder', $title), 'ActionNextStepManually');
142
143			return $fields;
144			}
145
146			/**
147			* For some ordersteps this returns true...
148			*
149			* @return bool
150			**/
151			protected function hasCustomerMessage()
152			{
153			return $this->SendDetailsToCustomer;
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The property `SendDetailsToCustomer` does not exist on `object<OrderStep_Sent>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
154			}
155
156			/**
157			* Explains the current order step.
158			*
159			* @return string
160			*/
161			protected function myDescription()
162			{
163			return _t('OrderStep.SENT_DESCRIPTION', 'During this step we record the delivery details for the order such as the courrier ticket number and whatever else is relevant.');
164			}
165
166			public function CalculatedEmailSubject($order = null)
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
167			{
168			$v = null;
169			if($order && $order->IsSeparateShippingAddress()) {
170			$v = $this->EmailSubjectGift;
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The property `EmailSubjectGift` does not exist on `object<OrderStep_Sent>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
171			}
172			if(! $v) {
173			$v = $this->EmailSubject;
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The property `EmailSubject` does not exist on `object<OrderStep_Sent>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
174			}
175
176			return $v;
177			}
178
179			public function CalculatedCustomerMessage($order = null)
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
180			{
181			$v = null;
182			if($order && $order->IsSeparateShippingAddress()) {
183			$v = $this->CustomerMessageGift;
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The property `CustomerMessageGift` does not exist on `object<OrderStep_Sent>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
184			}
185			if(! $v) {
186			$v = $this->CustomerMessage;
			0 ignored issues – show Documentation introduced 2017-10-31 08:31 UTC by Report Bug Copy Issue Report The property `CustomerMessage` does not exist on `object<OrderStep_Sent>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
187			}
188
189			return $v;
190			}
191			}
192

sunnysideup / silverstripe-ecommerce

Push — master ( 1552c3...bf9266 )

OrderStep_Sent A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like