Completed
Push — master ( e4b7dd...ebe629 )
by Nicolaas
02:44
created
code/forms/fields/EcommerceSearchHistoryFormField.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -56,6 +56,7 @@  discard block
 block discarded – undo
56 56
 
57 57
     /**
58 58
      * @param int
59
+     * @param integer $days
59 60
      *
60 61
      * @return EcommerceSearchHistoryFormField
61 62
      */
@@ -68,6 +69,7 @@  discard block
 block discarded – undo
68 69
 
69 70
     /**
70 71
      * @param int
72
+     * @param integer $count
71 73
      *
72 74
      * @return EcommerceSearchHistoryFormField
73 75
      */
@@ -80,6 +82,7 @@  discard block
 block discarded – undo
80 82
 
81 83
     /**
82 84
      * @param int
85
+     * @param boolean $b
83 86
      *
84 87
      * @return EcommerceSearchHistoryFormField
85 88
      */
@@ -92,6 +95,7 @@  discard block
 block discarded – undo
92 95
 
93 96
     /**
94 97
      * @param int
98
+     * @param integer $count
95 99
      *
96 100
      * @return EcommerceSearchHistoryFormField
97 101
      */
@@ -104,6 +108,7 @@  discard block
 block discarded – undo
104 108
 
105 109
     /**
106 110
      * @param int
111
+     * @param integer $number
107 112
      *
108 113
      * @return EcommerceSearchHistoryFormField
109 114
      */
Please login to merge, or discard this patch.
code/ProductGroup.php 1 patch
Doc Comments   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
      * by either type (e.g. FILER) or variable (e.g dbFieldName)
373 373
      * or both.
374 374
      *
375
-     * @param string $typeOfVariableName FILTER | SORT | DISPLAY or sessionName, getVariable, etc...
375
+     * @param string $typeOrVariable FILTER | SORT | DISPLAY or sessionName, getVariable, etc...
376 376
      * @param string $variable:          sessionName, getVariable, etc...
377 377
      *
378 378
      * @return array | String
@@ -1608,9 +1608,8 @@  discard block
 block discarded – undo
1608 1608
 
1609 1609
     /**
1610 1610
      *
1611
-     * @param string $name
1612
-     * @param string $filterKey
1613 1611
      *
1612
+     * @param string $cacheKey
1614 1613
      * @return string
1615 1614
      */
1616 1615
     public function cacheKey($cacheKey)
@@ -2253,7 +2252,7 @@  discard block
 block discarded – undo
2253 2252
      *
2254 2253
      * This is different from IsSearchResults.
2255 2254
      *
2256
-     * @return bool
2255
+     * @return boolean|null
2257 2256
      */
2258 2257
     public function ActiveSearchTerm()
2259 2258
     {
@@ -2319,7 +2318,7 @@  discard block
 block discarded – undo
2319 2318
      * Is there a special sort operating at the moment?
2320 2319
      * Is the current sort the default one (return inverse!)?
2321 2320
      *
2322
-     * @return bool
2321
+     * @return boolean|null
2323 2322
      */
2324 2323
     public function HasSort()
2325 2324
     {
@@ -2742,7 +2741,7 @@  discard block
 block discarded – undo
2742 2741
      *
2743 2742
      * @param SS_List
2744 2743
      *
2745
-     * @return PaginatedList
2744
+     * @return ProductGroup_Controller|null
2746 2745
      */
2747 2746
     protected function paginateList(SS_List $list)
2748 2747
     {
Please login to merge, or discard this patch.
code/api/ShoppingCart.php 1 patch
Doc Comments   +19 added lines, -18 removed lines patch added patch discarded remove patch
@@ -359,8 +359,8 @@  discard block
 block discarded – undo
359 359
      * Adds any number of items to the cart.
360 360
      * Returns the order item on succes OR false on failure.
361 361
      *
362
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
363
-     * @param float      $quantity   - number of items add.
362
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
363
+     * @param integer      $quantity   - number of items add.
364 364
      * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
365 365
      *                                 if you make it a form, it will save the form into the orderitem
366 366
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
@@ -407,7 +407,7 @@  discard block
 block discarded – undo
407 407
      *
408 408
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
409 409
      *
410
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
410
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
411 411
      * @param float      $quantity   - number of items add.
412 412
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
413 413
      *
@@ -437,8 +437,8 @@  discard block
 block discarded – undo
437 437
      *
438 438
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
439 439
      *
440
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
441
-     * @param float      $quantity   - number of items add.
440
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
441
+     * @param integer      $quantity   - number of items add.
442 442
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
443 443
      *
444 444
      * @return false | OrderItem | null
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
      *
476 476
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
477 477
      *
478
-     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart
478
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
479 479
      * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
480 480
      *
481 481
      * @return bool | item | null - successfully removed
@@ -502,9 +502,8 @@  discard block
 block discarded – undo
502 502
     /**
503 503
      * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
504 504
      *
505
-     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart
506
-     * @param float         $quantity            - number of items add.
507
-     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
505
+     * @param BuyableModel    $buyable             - the buyable (generally a product) being added to the cart
506
+     * @param bool          $mustBeExistingItem - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
508 507
      * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
509 508
      *                                           - form saved into item...
510 509
      *
@@ -569,7 +568,7 @@  discard block
 block discarded – undo
569 568
      * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
570 569
      * NOTE: does not write!
571 570
      *
572
-     * @param DataObject $buyable
571
+     * @param BuyableModel $buyable
573 572
      * @param array      $parameters
574 573
      *
575 574
      * @return OrderItem
@@ -631,7 +630,7 @@  discard block
 block discarded – undo
631 630
     /**
632 631
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
633 632
      *
634
-     * @return bool | null
633
+     * @return boolean|null | null
635 634
      */
636 635
     public function save()
637 636
     {
@@ -695,7 +694,7 @@  discard block
 block discarded – undo
695 694
      *
696 695
      * @param OrderModifier $modifier
697 696
      *
698
-     * @return bool | null
697
+     * @return boolean|null | null
699 698
      */
700 699
     public function removeModifier(OrderModifier $modifier)
701 700
     {
@@ -727,8 +726,9 @@  discard block
 block discarded – undo
727 726
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
728 727
      *
729 728
      * @param Int/ OrderModifier
729
+     * @param integer $modifier
730 730
      *
731
-     * @return bool
731
+     * @return boolean|null
732 732
      */
733 733
     public function addModifier($modifier)
734 734
     {
@@ -856,7 +856,7 @@  discard block
 block discarded – undo
856 856
      * @param Order $oldOrder
857 857
      * @param Order $newOrder
858 858
      *
859
-     * @return Ordeer (the new order)
859
+     * @return Order (the new order)
860 860
      */
861 861
     public function CopyOrderOnly($oldOrder, $newOrder)
862 862
     {
@@ -907,7 +907,7 @@  discard block
 block discarded – undo
907 907
      *
908 908
      * @param string - $countryCode
909 909
      *
910
-     * @return bool
910
+     * @return boolean|null
911 911
      **/
912 912
     public function setCountry($countryCode)
913 913
     {
@@ -929,6 +929,7 @@  discard block
 block discarded – undo
929 929
      * sets region in order so that modifiers can be recalculated, etc...
930 930
      *
931 931
      * @param int | String - $regionID you can use the ID or the code.
932
+     * @param integer $regionID
932 933
      *
933 934
      * @return bool
934 935
      **/
@@ -1071,7 +1072,7 @@  discard block
 block discarded – undo
1071 1072
     /**
1072 1073
      * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
1073 1074
      *
1074
-     * @param $message - the message, which could be a notification of successful action, or reason for failure
1075
+     * @param string $message - the message, which could be a notification of successful action, or reason for failure
1075 1076
      * @param $type - please use good, bad, warning
1076 1077
      */
1077 1078
     public function addMessage($message, $status = 'good')
@@ -1097,7 +1098,7 @@  discard block
 block discarded – undo
1097 1098
     /**
1098 1099
      * Gets an existing order item based on buyable and passed parameters.
1099 1100
      *
1100
-     * @param DataObject $buyable
1101
+     * @param BuyableModel $buyable
1101 1102
      * @param array      $parameters
1102 1103
      *
1103 1104
      * @return OrderItem | null
@@ -1122,7 +1123,7 @@  discard block
 block discarded – undo
1122 1123
     /**
1123 1124
      * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
1124 1125
      *
1125
-     * @param array $parameters
1126
+     * @param array $params
1126 1127
      *
1127 1128
      * @return cleaned array
1128 1129
      */
Please login to merge, or discard this patch.