ShopAccountForm

Complexity

Total Complexity

32

Size/Duplication

Total Lines	193
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	19

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
C	__construct()	0	80	16
A	submit()	0	4	1
A	proceed()	0	4	1
C	creatememberandaddtoorder()	0	30	7
B	processForm()	0	28	6
A	saveDataToSession()	0	10	1

<?php
/**
 * @description: ShopAccountForm allows shop members to update their details.
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: forms
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class ShopAccountForm extends Form

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @param Controller $controller
     * @param string     $name,      Name of the form

There is no parameter named $name,. Was it maybe removed?

     */
    public function __construct($controller, $name, $mustCreateAccount = false)
    {
        $member = Member::currentUser();
        $requiredFields = null;

$requiredFields is not used, you could remove the assignment.

        if ($member && $member->exists()) {
            $fields = $member->getEcommerceFields(false);
            $clearCartAndLogoutLink = ShoppingCart_Controller::clear_cart_and_logout_link();
            $loginMessage =
                '<span class="customerName">'.trim(Convert::raw2xml($member->FirstName).' '.Convert::raw2xml($member->Surname)).'</span>, '
                .'<a href="'.$clearCartAndLogoutLink.'">'._t('Account.LOGOUT', 'Log out now?').
                '</a>';
            if ($loginMessage) {
                $loginField = new ReadonlyField(
                    'LoggedInAsNote',
                    _t('Account.LOGGEDIN', 'You are currently logged in as '),
                    $loginMessage
                );
                $loginField->dontEscape = true;
                $fields->push($loginField);
            }
            $actions = new FieldList();
            if ($order = ShoppingCart::current_order()) {
                if ($order->getTotalItems()) {
                    $actions->push(new FormAction('proceed', _t('Account.SAVE_AND_PROCEED', 'Save changes and proceed to checkout')));
                } else {
                    $actions->push(new FormAction('submit', _t('Account.SAVE', 'Save Changes')));
                }
            }
        } else {
            if (!$member) {
                $member = new Member();
            }
            $fields = new FieldList();
            $urlParams = $controller->getURLParams();
            $backURLLink = Director::baseURL();
            if ($urlParams) {

The expression $urlParams of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                foreach ($urlParams as $urlParam) {
                    if ($urlParam) {
                        $backURLLink = Controller::join_links($backURLLink, $urlParam);
                    }
                }
            }
            $backURLLink = urlencode($backURLLink);
            $fields->push(new LiteralField('MemberInfo', '<p class="message good">'._t('OrderForm.MEMBERINFO', 'If you already have an account then please').' <a href="Security/login?BackURL='.$backURLLink.'">'._t('OrderForm.LOGIN', 'log in').'</a>.</p>'));
            $memberFields = $member->getEcommerceFields($mustCreateAccount);
            if ($memberFields) {
                foreach ($memberFields as $memberField) {
                    $fields->push($memberField);
                }
            }
            $passwordField = new PasswordField('PasswordCheck1', _t('Account.PASSWORD', 'Password'));
            $passwordFieldCheck = new PasswordField('PasswordCheck2', _t('Account.PASSWORDCHECK', 'Password (repeat)'));
            $fields->push($passwordField);
            $fields->push($passwordFieldCheck);
            $actions = new FieldList(
                new FormAction('creatememberandaddtoorder', _t('Account.SAVE', 'Create Account'))
            );
        }

        $requiredFields = ShopAccountForm_Validator::create($member->getEcommerceRequiredFields());
        parent::__construct($controller, $name, $fields, $actions, $requiredFields);
        $this->setAttribute('autocomplete', 'off');
        //extensions need to be set after __construct
        //extension point
        $this->extend('updateFields', $fields);
        $this->setFields($fields);
        $this->extend('updateActions', $actions);
        $this->setActions($actions);
        $this->extend('updateValidator', $requiredFields);
        $this->setValidator($requiredFields);

        if ($member) {
            $this->loadDataFrom($member);
        }
        $oldData = Session::get("FormInfo.{$this->FormName()}.data");
        if ($oldData && (is_array($oldData) || is_object($oldData))) {
            $this->loadDataFrom($oldData);

It seems like $oldData can also be of type object; however, Form::loadDataFrom() does only seem to accept array|object<DataObject>, maybe add an additional type check?

        }
        $this->extend('updateShopAccountForm', $this);
    }

    /**
     * Save the changes to the form, and go back to the account page.
     *
     * @return bool + redirection
     */
    public function submit($data, $form, $request)
    {
        return $this->processForm($data, $form, $request, '');
    }

    /**
     * Save the changes to the form, and redirect to the checkout page.
     *
     * @return bool + redirection
     */
    public function proceed($data, $form, $request)
    {
        return $this->processForm($data, $form, $request, CheckoutPage::find_link());
    }

    /**
     * create a member and add it to the order
     * then redirect back...
     *
     * @param array $data
     * @param Form  $form
     */
    public function creatememberandaddtoorder($data, $form)
    {
        $member = new Member();
        $order = ShoppingCart::current_order();
        if ($order && $order->exists()) {
            $form->saveInto($member);
            $password = ShopAccountForm_PasswordValidator::clean_password($data);
            if ($password) {
                $member->changePassword($password);

It seems like $password defined by \ShopAccountForm_PasswordValidator::clean_password($data) on line 131 can also be of type array; however, Member::changePassword() does only seem to accept string, maybe add an additional type check?

                if ($member->validate()->valid()) {
                    $member->write();
                    if ($member->exists()) {
                        if (!$order->MemberID) {

The property MemberID does not exist on object<Order>. Since you implemented __get, maybe consider adding a @property annotation.

                            $order->MemberID = $member->ID;

The property MemberID does not exist on object<Order>. Since you implemented __set, maybe consider adding a @property annotation.

                            $order->write();
                        }
                        $member->login();
                        $this->sessionMessage(_t('ShopAccountForm.SAVEDDETAILS', 'Your details has been saved.'), 'good');
                    } else {
                        $this->sessionMessage(_t('ShopAccountForm.COULD_NOT_CREATE_RECORD', 'Could not save create a record for your details.'), 'bad');
                    }
                } else {
                    $this->sessionMessage(_t('ShopAccountForm.COULD_NOT_VALIDATE_MEMBER', 'Could not save your details.'), 'bad');
                }
            }
        } else {
            $this->sessionMessage(_t('ShopAccountForm.COULDNOTFINDORDER', 'Could not find order.'), 'bad');
        }
        $this->controller->redirectBack();
    }

    /**
     *@return bool + redirection
     **/
    protected function processForm($data, $form, $request, $link = '')

The parameter $request is not used and could be removed.

    {
        $member = Member::currentUser();
        if (!$member) {
            $form->sessionMessage(_t('Account.DETAILSNOTSAVED', 'Your details could not be saved.'), 'bad');
            $this->controller->redirectBack();
        }
        $form->saveInto($member);
        $password = ShopAccountForm_PasswordValidator::clean_password($data);
        if ($password) {
            $member->changePassword($password);
        } elseif ($data['PasswordCheck1']) {
            $form->sessionMessage(_t('Account.NO_VALID_PASSWORD', 'You need to enter a valid password.'), 'bad');
            $this->controller->redirectBack();
        }
        if ($member->validate()->valid()) {
            $member->write();
            if ($link) {
                return $this->controller->redirect($link);
            } else {
                $form->sessionMessage(_t('Account.DETAILSSAVED', 'Your details have been saved.'), 'good');
                $this->controller->redirectBack();
            }
        } else {
            $form->sessionMessage(_t('Account.NO_VALID_DATA', 'Your details can not be updated.'), 'bad');
            $this->controller->redirectBack();
        }
    }

    /**
     * saves the form into session.
     *
     * @param array $data - data from form.

There is no parameter named $data. Was it maybe removed?

     */
    public function saveDataToSession()
    {
        $data = $this->getData();
        unset($data['AccountInfo']);
        unset($data['LoginDetails']);
        unset($data['LoggedInAsNote']);
        unset($data['PasswordCheck1']);
        unset($data['PasswordCheck2']);
        Session::set("FormInfo.{$this->FormName()}.data", $data);

$data is of type array, but the function expects a string.

    }
}