+global\ProductGroupSearchPage_Controller::searchresults()

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	ProductGroupSearchPage_Controller::MenuChildGroups()	0	4	1

<?php
/**
 * This page manages searching for products.
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: Pages
 **/
class ProductGroupSearchPage extends ProductGroup

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * standard SS variable.
     *
     * @static String | Array
     */
    private static $icon = 'ecommerce/images/icons/productgroupsearchpage';

The property $icon is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $description = 'This page allowing the user to search for products.';

The property $description is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    /**
     * Standard SS variable.
     */
    private static $singular_name = 'Product Search Page';

The property $singular_name is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return _t('ProductGroupSearchPage.SINGULARNAME', 'Product Search Page');
    }

    /**
     * Standard SS variable.
     */
    private static $plural_name = 'Product Search Pages';

The property $plural_name is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return _t('ProductGroupSearchPage.PLURALNAME', 'Product Search Pages');
    }

    /**
     * Standard SS function, we only allow for one Product Search Page to exist
     * but we do allow for extensions to exist at the same time.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return ProductGroupSearchPage::get()->filter(array('ClassName' => 'ProductGroupSearchPage'))->Count() ? false : $this->canEdit($member);
    }

    /**
     * Can product list (and related) be cached at all?
     *
     * @var bool
     */
    protected $allowCaching = false;

    public function getGroupFilter()
    {
        $resultArray = $this->searchResultsArrayFromSession();
        $this->allProducts = $this->allProducts->filter(array('ID' => $resultArray));

        return $this->allProducts;
    }

    /**
     * returns the SORT part of the final selection of products.
     *
     * @return string | Array

Should the return type not be string|array?

     */
    protected function currentSortSQL()
    {
        $sortKey = $this->getCurrentUserPreferences('SORT');
        $defaultSortKey = $this->getMyUserPreferencesDefault('SORT');
        if ($sortKey == $defaultSortKey) {
            $resultArray = $this->searchResultsArrayFromSession();
            
            return $this->createSortStatementFromIDArray($resultArray);
        }

        return $this->getUserSettingsOptionSQL('SORT', $sortKey);
    }

    public function childGroups($maxRecursiveLevel, $filter = null, $numberOfRecursions = 0)
    {
        return ArrayList::create();
    }
}

class ProductGroupSearchPage_Controller extends ProductGroup_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * standard SS variable.
     *
     * @var array
     */
    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'debug' => 'ADMIN',
        'filterforgroup' => true,
        'ProductSearchForm' => true,
        'searchresults' => true,
        'resetfilter' => true,
    );

    public function init()
    {
        parent::init();
        $array = $this->searchResultsArrayFromSession();
        if (count($array) > 1) {
            $this->isSearchResults = true;
        }
    }


    /**
     * returns child product groups for use in
     * 'in this section'. For example the vegetable Product Group
     * May have listed here: Carrot, Cabbage, etc...
     *
     * @return ArrayList (ProductGroups)

Should the return type not be ArrayList|null?

     */
    public function MenuChildGroups()
    {
        return;
    }

    /**
     * The link that Google et al. need to index.
     * @return string
     */
    public function CanonicalLink()
    {
        $link = $this->Link();
        $this->extend('UpdateCanonicalLink', $link);

        return $link;
    }

}