sunnysideup / silverstripe-ecommerce

code/api/ShoppingCart.php

Doc Comments +18 added lines, -17 removed lines

@@ -350,8 +350,8 @@ 
      * Adds any number of items to the cart.
      * Returns the order item on succes OR false on failure.
      *
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
-     * @param float      $quantity   - number of items add.
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
+     * @param integer      $quantity   - number of items add.
      * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
      *                                 if you make it a form, it will save the form into the orderitem
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
@@ -398,7 +398,7 @@ 
      *
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
      *
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
      * @param float      $quantity   - number of items add.
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
      *
@@ -428,8 +428,8 @@ 
      *
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
      *
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
-     * @param float      $quantity   - number of items add.
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
+     * @param integer      $quantity   - number of items add.
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
      *
      * @return false | OrderItem | null
@@ -467,7 +467,7 @@ 
      *
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
      *
-     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
      * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
      *
      * @return bool | item | null - successfully removed
@@ -494,9 +494,8 @@ 
     /**
      * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
      *
-     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart
-     * @param float         $quantity            - number of items add.
-     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
+     * @param BuyableModel    $buyable             - the buyable (generally a product) being added to the cart
+     * @param bool          $mustBeExistingItem - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
      * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
      *                                           - form saved into item...
      *
@@ -564,7 +563,7 @@ 
      * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
      * NOTE: does not write!
      *
-     * @param DataObject $buyable
+     * @param BuyableModel $buyable
      * @param array      $parameters
      *
      * @return OrderItem
@@ -626,7 +625,7 @@ 
     /**
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
      *
-     * @return bool | null
+     * @return boolean|null | null
      */
     public function save()
     {
@@ -690,7 +689,7 @@ 
      *
      * @param OrderModifier $modifier
      *
-     * @return bool | null
+     * @return boolean|null | null
      */
     public function removeModifier(OrderModifier $modifier)
     {
@@ -722,8 +721,9 @@ 
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
      *
      * @param Int/ OrderModifier
+     * @param integer $modifier
      *
-     * @return bool
+     * @return boolean|null
      */
     public function addModifier($modifier)
     {
@@ -857,7 +857,7 @@ 
      *
      * @param string - $countryCode
      *
-     * @return bool
+     * @return boolean|null
      **/
     public function setCountry($countryCode)
     {
@@ -879,6 +879,7 @@ 
      * sets region in order so that modifiers can be recalculated, etc...
      *
      * @param int | String - $regionID you can use the ID or the code.
+     * @param integer $regionID
      *
      * @return bool
      **/
@@ -1021,7 +1022,7 @@ 
     /**
      * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
      *
-     * @param $message - the message, which could be a notification of successful action, or reason for failure
+     * @param string $message - the message, which could be a notification of successful action, or reason for failure
      * @param $type - please use good, bad, warning
      */
     public function addMessage($message, $status = 'good')
@@ -1047,7 +1048,7 @@ 
     /**
      * Gets an existing order item based on buyable and passed parameters.
      *
-     * @param DataObject $buyable
+     * @param BuyableModel $buyable
      * @param array      $parameters
      *
      * @return OrderItem | null
@@ -1073,7 +1074,7 @@ 
     /**
      * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
      *
-     * @param array $parameters
+     * @param array $params
      *
      * @return cleaned array
      */

code/dev/EcommerceCodeFilter.php

Doc Comments +1 added lines

@@ -26,6 +26,7 @@
      * should be run in onBeforeWrite.
      *
      * @param DataObject | String $obj
+     * @param EcommerceRegion $obj
      */
     public function checkCode($obj, $fieldName = 'Code')
     {

code/model/money/EcommerceCurrency.php

Doc Comments +1 added lines, -1 removed lines

@@ -333,7 +333,7 @@
      *
      * @param string $currencyCode - the code of the currency, e.g. nzd
      *
-     * @return EcommerceCurrency | Null
+     * @return DataList | Null
      */
     public static function get_one_from_code($currencyCode)
     {

code/model/process/OrderProcessQueue.php

Doc Comments +4 added lines, -5 removed lines

@@ -152,7 +152,7 @@ 
      * META METHOD: Add an order to the job list if it does not exist already.
      *
      * @param Order $order
-     * @param Int   $deferInSeconds
+     * @param Int   $deferTimeInSeconds
      */
     public function AddOrderToQueue($order, $deferTimeInSeconds)
     {
@@ -184,7 +184,7 @@ 
      *
      *
      * @param  Order $order optional
-     * @return boolean | string
+     * @return boolean|string | string
      */
     public function process($order = null)
     {
@@ -244,7 +244,7 @@ 
      *
      * @param  Order $order
      *
-     * @return null |   OrderProcessQueue
+     * @return DataObject |   OrderProcessQueue
      */
     public function getQueueObject($order)
     {
@@ -301,7 +301,6 @@ 
 
     /**
      * META METHOD: all orders with a queue object
-     * @param int $id force this Order to be processed
      * @param int $limit total number of orders that can be retrieved at any one time
      *
      * @return DataList (of orders)
@@ -467,7 +466,7 @@ 
 
     /**
      * sort phrase for orders, based in order IDs...
-     * @param  array $orderIds
+     * @param  array $orderIDs
      * @return string
      */
     protected function sortPhraseForOrderIDs($orderIDs)

code/tasks/EcommerceTaskArchiveAllOrdersWithItems.php

Doc Comments +5 added lines

@@ -100,6 +100,11 @@
         }
     }
 
+    /**
+     * @param DataObject $lastOrderStep
+     * @param string $orderStatusLogClassName
+     * @param integer $offset
+     */
     public function getOrdersForCreateSubmissionLogForArchivedOrders($lastOrderStep, $orderStatusLogClassName, $offset)
     {
         return Order::get()