These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | |||
4 | /** |
||
5 | * OrderStatusLog_Submitted is an important class that is created when an order is submitted. |
||
6 | * It is created by the order and it signifies to the OrderStep to continue to the next step. |
||
7 | * |
||
8 | * @authors: Nicolaas [at] Sunny Side Up .co.nz |
||
9 | * @package: ecommerce |
||
10 | * @sub-package: model |
||
11 | * @inspiration: Silverstripe Ltd, Jeremy |
||
12 | **/ |
||
13 | class OrderStatusLog_Submitted extends OrderStatusLog |
||
14 | { |
||
15 | private static $db = array( |
||
0 ignored issues
–
show
Comprehensibility
introduced
by
Loading history...
|
|||
16 | 'OrderAsHTML' => 'HTMLText', |
||
17 | 'OrderAsString' => 'Text', |
||
18 | 'SequentialOrderNumber' => 'Int', |
||
19 | 'Total' => 'Currency', |
||
20 | 'SubTotal' => 'Currency', |
||
21 | ); |
||
22 | |||
23 | private static $defaults = array( |
||
0 ignored issues
–
show
|
|||
24 | 'InternalUseOnly' => true, |
||
25 | ); |
||
26 | |||
27 | private static $casting = array( |
||
0 ignored issues
–
show
|
|||
28 | 'HTMLRepresentation' => 'HTMLText', |
||
29 | ); |
||
30 | |||
31 | private static $singular_name = 'Submitted Order'; |
||
0 ignored issues
–
show
|
|||
32 | public function i18n_singular_name() |
||
33 | { |
||
34 | return _t('OrderStatusLog.SUBMITTEDORDER', 'Submitted Order - Fulltext Backup'); |
||
35 | } |
||
36 | |||
37 | private static $plural_name = 'Submitted Orders'; |
||
0 ignored issues
–
show
|
|||
38 | public function i18n_plural_name() |
||
39 | { |
||
40 | return _t('OrderStatusLog.SUBMITTEDORDERS', 'Submitted Orders - Fulltext Backup'); |
||
41 | } |
||
42 | |||
43 | /** |
||
44 | * Standard SS variable. |
||
45 | * |
||
46 | * @var string |
||
47 | */ |
||
48 | private static $description = 'The record that the order has been submitted by the customer. This is important in e-commerce, because from here, nothing can change to the order.'; |
||
0 ignored issues
–
show
|
|||
49 | |||
50 | /** |
||
51 | * Standard SS method. |
||
52 | * |
||
53 | * @param Member $member |
||
0 ignored issues
–
show
Should the type for parameter
$member not be Member|null ?
This check looks for It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types.
Loading history...
|
|||
54 | * |
||
55 | * @return bool |
||
56 | */ |
||
57 | public function canDelete($member = null) |
||
58 | { |
||
59 | return false; |
||
60 | } |
||
61 | |||
62 | /** |
||
63 | * Standard SS method. |
||
64 | * |
||
65 | * @param Member $member |
||
0 ignored issues
–
show
Should the type for parameter
$member not be Member|null ?
This check looks for It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types.
Loading history...
|
|||
66 | * |
||
67 | * @return bool |
||
68 | */ |
||
69 | public function canEdit($member = null) |
||
70 | { |
||
71 | return false; |
||
72 | } |
||
73 | |||
74 | /** |
||
75 | * Standard SS method. |
||
76 | * |
||
77 | * @param Member $member |
||
0 ignored issues
–
show
Should the type for parameter
$member not be Member|null ?
This check looks for It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types.
Loading history...
|
|||
78 | * |
||
79 | * @return bool |
||
80 | */ |
||
81 | public function canCreate($member = null) |
||
82 | { |
||
83 | if (! $member) { |
||
84 | $member = Member::currentUser(); |
||
85 | } |
||
86 | $extended = $this->extendedCan(__FUNCTION__, $member); |
||
0 ignored issues
–
show
$member is of type object<DataObject>|null , but the function expects a object<Member>|integer .
It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { }
$x = '123'; // string "123"
// Instead of
acceptsInteger($x);
// we recommend to use
acceptsInteger((integer) $x);
Loading history...
|
|||
87 | if ($extended !== null) { |
||
88 | return $extended; |
||
89 | } |
||
90 | |||
91 | return true; |
||
92 | } |
||
93 | |||
94 | /** |
||
95 | * can only be created when the order is submitted. |
||
96 | * |
||
97 | *@return string |
||
98 | **/ |
||
99 | public function HTMLRepresentation() |
||
100 | { |
||
101 | return $this->getHTMLRepresentation(); |
||
102 | } |
||
103 | public function getHTMLRepresentation() |
||
0 ignored issues
–
show
The return type could not be reliably inferred; please add a
@return annotation.
Our type inference engine in quite powerful, but sometimes the code does not
provide enough clues to go by. In these cases we request you to add a
Loading history...
|
|||
104 | { |
||
105 | if ($this->OrderAsHTML) { |
||
0 ignored issues
–
show
The property
OrderAsHTML does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
106 | return $this->OrderAsHTML; |
||
0 ignored issues
–
show
The property
OrderAsHTML does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
107 | } elseif ($this->OrderAsString) { |
||
0 ignored issues
–
show
The property
OrderAsString does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
108 | return unserialize($this->OrderAsString); |
||
0 ignored issues
–
show
The property
OrderAsString does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
109 | } |
||
110 | |||
111 | return _t('OrderStatusLog.NO_FURTHER_INFO_AVAILABLE', 'no further information available'); |
||
112 | } |
||
113 | |||
114 | /** |
||
115 | * adding a sequential order number. |
||
116 | */ |
||
117 | public function onBeforeWrite() |
||
118 | { |
||
119 | parent::onBeforeWrite(); |
||
120 | if ($order = $this->Order()) { |
||
0 ignored issues
–
show
The method
Order does not exist on object<OrderStatusLog_Submitted> ? Since you implemented __call , maybe consider adding a @method annotation.
If you implement This is often the case, when class ParentClass {
private $data = array();
public function __call($method, array $args) {
if (0 === strpos($method, 'get')) {
return $this->data[strtolower(substr($method, 3))];
}
throw new \LogicException(sprintf('Unsupported method: %s', $method));
}
}
/**
* If this class knows which fields exist, you can specify the methods here:
*
* @method string getName()
*/
class SomeClass extends ParentClass { }
Loading history...
|
|||
121 | if (!$this->Total) { |
||
0 ignored issues
–
show
The property
Total does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
122 | $this->Total = $order->Total(); |
||
0 ignored issues
–
show
The property
Total does not exist on object<OrderStatusLog_Submitted> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
123 | $this->SubTotal = $order->SubTotal(); |
||
0 ignored issues
–
show
The property
SubTotal does not exist on object<OrderStatusLog_Submitted> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
124 | } |
||
125 | } |
||
126 | if (!intval($this->SequentialOrderNumber)) { |
||
0 ignored issues
–
show
The property
SequentialOrderNumber does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
127 | $this->SequentialOrderNumber = 1; |
||
0 ignored issues
–
show
The property
SequentialOrderNumber does not exist on object<OrderStatusLog_Submitted> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
128 | $min = intval(EcommerceConfig::get('Order', 'order_id_start_number')) - 0; |
||
129 | if (isset($this->ID)) { |
||
130 | $id = intval($this->ID); |
||
131 | } else { |
||
132 | $id = 0; |
||
133 | } |
||
134 | $lastOne = OrderStatusLog_Submitted::get() |
||
135 | ->Exclude(array('ID' => $id)) |
||
136 | ->Sort('SequentialOrderNumber', 'DESC') |
||
137 | ->First(); |
||
138 | if ($lastOne) { |
||
139 | $this->SequentialOrderNumber = intval($lastOne->SequentialOrderNumber) + 1; |
||
0 ignored issues
–
show
The property
SequentialOrderNumber does not exist on object<OrderStatusLog_Submitted> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
140 | } |
||
141 | if (intval($min) && $this->SequentialOrderNumber < $min) { |
||
0 ignored issues
–
show
The property
SequentialOrderNumber does not exist on object<OrderStatusLog_Submitted> . Since you implemented __get , maybe consider adding a @property annotation.
Since your code implements the magic getter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
142 | $this->SequentialOrderNumber = $min; |
||
0 ignored issues
–
show
The property
SequentialOrderNumber does not exist on object<OrderStatusLog_Submitted> . Since you implemented __set , maybe consider adding a @property annotation.
Since your code implements the magic setter <?php
/**
* @property int $x
* @property int $y
* @property string $text
*/
class MyLabel
{
private $properties;
private $allowedProperties = array('x', 'y', 'text');
public function __get($name)
{
if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
return $properties[$name];
} else {
return null;
}
}
public function __set($name, $value)
{
if (in_array($name, $this->allowedProperties)) {
$properties[$name] = $value;
} else {
throw new \LogicException("Property $name is not defined.");
}
}
}
Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property.
Loading history...
|
|||
143 | } |
||
144 | } |
||
145 | } |
||
146 | } |
||
147 |