OrderForm_Feedback

Complexity

Total Complexity

15

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	36	5
B	dofeedback()	0	25	2
A	saveDataToSession()	0	5	1
B	getValueFromOrderConfirmationPage()	0	12	5
A	getOrderConfirmationPage()	0	6	2

<?php


class OrderForm_Feedback extends Form

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    protected $order = null;

    public function __construct(Controller $controller, $name, Order $order)
    {
        $this->order = $order;
        $values = $this->getValueFromOrderConfirmationPage('FeedbackValuesOptions');
        $values = explode(',', $values);
        $newValues = array();
        foreach($values as $value) {
            $value = trim($value);
            $newValues[Convert::raw2att($value)] = $value;
        }
        $fields = FieldList::create(
            array(
                HeaderField::create('FeedbackHeading', $this->getValueFromOrderConfirmationPage('FeedbackHeader'), 3),
                OptionsetField::create(
                    'Rating',
                    $this->getValueFromOrderConfirmationPage('FeedbackValuesFieldLabel'),
                    $newValues
                ),
                TextareaField::create('Note', $this->getValueFromOrderConfirmationPage('FeedbackNotesFieldLabel'))
            )
        );
        $actions = FieldList::create(
            FormAction::create('dofeedback', $this->getValueFromOrderConfirmationPage('FeedbackFormSubmitLabel'))
        );
        $requiredFields = array(
            'FeedbackValue'
        );
        $validator = OrderForm_Feedback_Validator::create($requiredFields);
        parent::__construct($controller, $name, $fields, $actions, $validator);

        $oldData = Session::get("FormInfo.{$this->FormName()}.data");
        if ($oldData && (is_array($oldData) || is_object($oldData))) {
            $this->loadDataFrom($oldData);

It seems like $oldData can also be of type object; however, Form::loadDataFrom() does only seem to accept array|object<DataObject>, maybe add an additional type check?

        }
        $this->extend('updateOrderForm_Feedback', $this);
    }

    /**
     * @param array        $data The form request data submitted
     * @param Form         $form The {@link Form} this was submitted on
     * @param HTTPRequest  $request The {@link Form} this was submitted on

Should the type for parameter $request not be SS_HTTPRequest?

     */
    public function dofeedback(array $data, Form $form, SS_HTTPRequest $request)

The return type could not be reliably inferred; please add a @return annotation.

The parameter $request is not used and could be removed.

    {
        $SQLData = Convert::raw2sql($data);
        if ($this->order) {
            $object = OrderFeedback::create($SQLData);
            $object->OrderID = $this->order->ID;

The property OrderID does not exist on object<OrderFeedback>. Since you implemented __set, maybe consider adding a @property annotation.

            $objet->write();

The variable $objet does not exist. Did you mean $object?

            $form->sessionMessage(
                $this->getValueFromOrderConfirmationPage('FeedbackFormThankYou'),
                'good'
            );

            return $this->controller->redirectBack();
        }
        $form->sessionMessage(
            _t(
                'OrderForm_Feedback.COULD_NOT_RECORD_FEEDBACK',
                'Sorry, order feedback could not be recorded.'
            ),
            'bad'
        );

        return $this->controller->redirectBack();

    }

    /**
     * saves the form into session.
     *
     * @param array $data - data from form.

There is no parameter named $data. Was it maybe removed?

     */
    public function saveDataToSession()
    {
        $data = $this->getData();
        Session::set("FormInfo.{$this->FormName()}.data", $data);

$data is of type array, but the function expects a string.

    }

    protected function getValueFromOrderConfirmationPage($value)

The return type could not be reliably inferred; please add a @return annotation.

    {
        if($page = $this->getOrderConfirmationPage()) {

Are you sure the assignment to $page is correct as $this->getOrderConfirmationPage() (which targets OrderForm_Feedback::getOrderConfirmationPage()) seems to always return null.

            return $page->$value;
        } else {
            $defaults = Config::inst()->get('OrderConfirmationPage', 'defaults');
            if($defaults && is_array($defaults) && isset($defaults[$value])) {
                return $defaults[$value];
            }
            return _t('OrderForm_Feedback.'.$value, 'OrderForm_Feedback.'.$value.' value not set in translations');
        }
    }

    protected $_orderConfirmationPage = null;

    protected function getOrderConfirmationPage()
    {
        if(! $this->_orderConfirmationPage) {
            $this->_orderConfirmationPage = OrderConfirmationPage::get()->first();
        }
    }

}