Completed
Push — master ( e3aa41...89474e )
by Nicolaas
04:08
created
code/model/process/OrderSteps/OrderStep_Submitted.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
      *
56 56
      * @see Order::doNextStatus
57 57
      *
58
-     * @param Order object
58
+     * @param Order Order
59 59
      *
60 60
      * @return bool - true if the current step is ready to be run...
61 61
      **/
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     /**
68 68
      * Add a member to the order - in case he / she is not a shop admin.
69 69
      *
70
-     * @param Order object
70
+     * @param Order Order
71 71
      *
72 72
      * @return bool - true if run correctly.
73 73
      **/
Please login to merge, or discard this patch.
code/api/ShoppingCart.php 1 patch
Doc Comments   +16 added lines, -17 removed lines patch added patch discarded remove patch
@@ -358,8 +358,8 @@  discard block
 block discarded – undo
358 358
      * Adds any number of items to the cart.
359 359
      * Returns the order item on succes OR false on failure.
360 360
      *
361
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
362
-     * @param float      $quantity   - number of items add.
361
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
362
+     * @param integer      $quantity   - number of items add.
363 363
      * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
364 364
      *                                 if you make it a form, it will save the form into the orderitem
365 365
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
      *
407 407
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
408 408
      *
409
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
409
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
410 410
      * @param float      $quantity   - number of items add.
411 411
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
412 412
      *
@@ -436,8 +436,8 @@  discard block
 block discarded – undo
436 436
      *
437 437
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
438 438
      *
439
-     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart
440
-     * @param float      $quantity   - number of items add.
439
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
440
+     * @param integer      $quantity   - number of items add.
441 441
      * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
442 442
      *
443 443
      * @return false | OrderItem | null
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
      *
475 475
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
476 476
      *
477
-     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart
477
+     * @param BuyableModel $buyable    - the buyable (generally a product) being added to the cart
478 478
      * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
479 479
      *
480 480
      * @return bool | item | null - successfully removed
@@ -501,9 +501,8 @@  discard block
 block discarded – undo
501 501
     /**
502 502
      * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
503 503
      *
504
-     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart
505
-     * @param float         $quantity            - number of items add.
506
-     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
504
+     * @param BuyableModel    $buyable             - the buyable (generally a product) being added to the cart
505
+     * @param bool          $mustBeExistingItem - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
507 506
      * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
508 507
      *                                           - form saved into item...
509 508
      *
@@ -571,7 +570,7 @@  discard block
 block discarded – undo
571 570
      * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
572 571
      * NOTE: does not write!
573 572
      *
574
-     * @param DataObject $buyable
573
+     * @param BuyableModel $buyable
575 574
      * @param array      $parameters
576 575
      *
577 576
      * @return OrderItem
@@ -633,7 +632,7 @@  discard block
 block discarded – undo
633 632
     /**
634 633
      * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
635 634
      *
636
-     * @return bool | null
635
+     * @return boolean|null | null
637 636
      */
638 637
     public function save()
639 638
     {
@@ -697,7 +696,7 @@  discard block
 block discarded – undo
697 696
      *
698 697
      * @param OrderModifier $modifier
699 698
      *
700
-     * @return bool | null
699
+     * @return boolean|null | null
701 700
      */
702 701
     public function removeModifier(OrderModifier $modifier)
703 702
     {
@@ -730,7 +729,7 @@  discard block
 block discarded – undo
730 729
      *
731 730
      * @param Int/ OrderModifier
732 731
      *
733
-     * @return bool
732
+     * @return boolean|null
734 733
      */
735 734
     public function addModifier($modifier)
736 735
     {
@@ -863,7 +862,7 @@  discard block
 block discarded – undo
863 862
      *
864 863
      * @param string - $countryCode
865 864
      *
866
-     * @return bool
865
+     * @return boolean|null
867 866
      **/
868 867
     public function setCountry($countryCode)
869 868
     {
@@ -1027,7 +1026,7 @@  discard block
 block discarded – undo
1027 1026
     /**
1028 1027
      * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
1029 1028
      *
1030
-     * @param $message - the message, which could be a notification of successful action, or reason for failure
1029
+     * @param string $message - the message, which could be a notification of successful action, or reason for failure
1031 1030
      * @param $type - please use good, bad, warning
1032 1031
      */
1033 1032
     public function addMessage($message, $status = 'good')
@@ -1053,7 +1052,7 @@  discard block
 block discarded – undo
1053 1052
     /**
1054 1053
      * Gets an existing order item based on buyable and passed parameters.
1055 1054
      *
1056
-     * @param DataObject $buyable
1055
+     * @param BuyableModel $buyable
1057 1056
      * @param array      $parameters
1058 1057
      *
1059 1058
      * @return OrderItem | null
@@ -1078,7 +1077,7 @@  discard block
 block discarded – undo
1078 1077
     /**
1079 1078
      * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
1080 1079
      *
1081
-     * @param array $parameters
1080
+     * @param array $params
1082 1081
      *
1083 1082
      * @return cleaned array
1084 1083
      */
Please login to merge, or discard this patch.