sunnysideup / silverstripe-ecommerce

code/cms/CMSPageAddController_Products.php

<?php


class CMSPageAddController_Products extends CMSPageAddController

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $url_segment = 'addproductorproductgroup';

The property $url_segment is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $url_rule = '/$Action/$ID/$OtherID';

The property $url_rule is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $url_priority = 41;

The property $url_priority is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $menu_title = 'Add Product';

The property $menu_title is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $required_permission_codes = 'CMS_ACCESS_CMSMain';

The property $required_permission_codes is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

Consider using a different property name as you override a private property of the parent class.

        'AddForm',
        'doAdd',
        'doCancel',
    );


    /**
     * the class of the page that is the root parent for the shop.
     *
     * @var string
     */
    private static $root_parent_class_for_adding_page = 'ProductGroupSearchPage';

The property $root_parent_class_for_adding_page is not used and could be removed.

    public function doCancel($data, $form)
    {
        return $this->redirect(singleton('ProductsAndGroupsModelAdmin')->Link());
    }


    /**
     * @return ArrayList
     */
    public function PageTypes()
    {
        $pageTypes = parent::PageTypes();
        $result = new ArrayList();
        $productClass = Object::getCustomClass('Product');
        $productGroupClass = Object::getCustomClass('ProductGroup');

        $acceptedClasses1 = ClassInfo::subclassesFor($productClass);
        $acceptedClasses1[$productClass] = $productClass;

        $acceptedClasses2 = ClassInfo::subclassesFor($productGroupClass);
        $acceptedClasses2[$productGroupClass] = $productGroupClass;

        $acceptedClasses = array_merge($acceptedClasses1, $acceptedClasses2);
        foreach ($pageTypes as $type) {
            if (in_array($type->ClassName, $acceptedClasses)) {
                $result->push($type);
            }
        }

        return $result;
    }
}