ShoppingCart::cleanParameters() - Code Metrics - Inspection of "PATCH: comments" - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( ce2dd0...10a6ac )

by Nicolaas
created 2017-04-18 23:55 UTC
ShoppingCart::cleanParameters() A

↳ Parent: ShoppingCart
Complexity

Conditions	4
Paths	4
Size

Total Lines	15
Code Lines	9
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	4
dl	0
loc	15
rs	9.2
c	0
b	0
f	0
eloc	9
nc	4
nop	1
<?php
/**
 * ShoppingCart - provides a global way to interface with the cart (current order).
 *
 * This can be used in other code by calling $cart = ShoppingCart::singleton();
 *
 * The shopping cart can be accessed as an order handler from the back-end
 * (e.g. when creating an order programmatically), while the accompagnying controller
 * is used by web-users to manipulate their order.
 *
 * A bunch of core functions are also stored in the order itself.
 * Methods and variables are in the shopping cart if they are relevant
 * only before (and while) the order is placed (e.g. latest update message),
 * and others are in the order because they are relevant even after the
 * order has been submitted (e.g. Total Cost).
 *
 * Key methods:
 *
 * //get Cart
 * $myCart = ShoppingCart::singleton();
 *
 * //get order
 * $myOrder = ShoppingCart::current_order();
 *
 * //view order (from another controller)
 * $this->redirect(ShoppingCart::current_order()->Link());
 *
 * //add item to cart
 * ShoppingCart::singleton()->addBuyable($myProduct);
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: control
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class ShoppingCart extends Object
namespace YourVendor;

class YourClass { }
{
    /**
     * List of names that can be used as session variables.
     * Also @see ShoppingCart::sessionVariableName.
     *
     * @var array
     */
    private static $session_variable_names = array('OrderID', 'Messages');

    /**
     * This is where we hold the (singleton) Shoppingcart.
     *
     * @var object (ShoppingCart)
     */
    private static $_singletoncart = null;

    /**
     * Feedback message to user (e.g. cart updated, could not delete item, someone in standing behind you).
     *
     *@var array
     **/
    protected $messages = array();

    /**
     * stores a reference to the current order object.
     *
     * @var object
     **/
    protected $order = null;

    /**
     * This variable is set to YES when we actually need an order (i.e. write it).
     *
     * @var bool
     */
    protected $requireSavedOrder = false;

    /**
     * Allows access to the cart from anywhere in code.
     *
     * @return ShoppingCart Object
     */
    public static function singleton()
    {
        if (!self::$_singletoncart) {
            self::$_singletoncart = Injector::inst()->get('ShoppingCart');
        }

        return self::$_singletoncart;
    }

    /**
     * Allows access to the current order from anywhere in the code..
     *
     * if you do not like the session Order then you can set it here ...
     *
     * @param Order $order (optional)

     *
     * @return Order
     */
    public static function current_order($order = null)
    {
        return self::singleton()->currentOrder(0, $order);
    }

    /**
     * looks up current order id.
     * you may supply an ID here, so that it looks up the current order ID
     * only when none is supplied.
     *
     * @param int (optional) | Order $orderOrOrderID
     *
     * @return int;

     */
    public static function current_order_id($orderOrOrderID = 0)

    {
        $orderID = 0;
        if (!$orderOrOrderID) {
            $order = self::current_order();
            if ($order && $order->exists()) {
                $orderID = $order->ID;
            }
        }
        if($orderOrOrderID instanceof Order) {
            $orderID = $orderOrOrderID->ID;
        } elseif(intval($orderOrOrderID)) {
            $orderID = intval($orderOrOrderID);
        }

        return $orderID;
    }

    /**
     * Allows access to the current order from anywhere in the code..
     *
     * @return Order

     */
    public static function session_order()
    {
        $sessionVariableName = self::singleton()->sessionVariableName('OrderID');
        $orderIDFromSession = intval(Session::get($sessionVariableName)) - 0;

        return Order::get()->byID($orderIDFromSession);
    }

    /**
     * set a specific order, other than the one from session ....
     *
     * @param Order $order
     *
     * @return Order
     */
    public function setOrder($order)
    {
        $this->order = $order;
        return $this->order;
    }

    /**
     * Gets or creates the current order.
     * Based on the session ONLY unless the order has been explictely set.
     * IMPORTANT FUNCTION!
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * However, you can pass an order in case you want to manipulate an order that is not in sesssion
     *
     * @param int $recurseCount (optional)
     * @param Order $order (optional)

     *
     * @return Order
     */
    public function currentOrder($recurseCount = 0, $order = null)
    {
        if($order) {
            $this->order = $order;
        }
        if($this->allowWrites()) {
            if (!$this->order) {
                $this->order = self::session_order();
                $loggedInMember = Member::currentUser();
                if ($this->order) {
                    //first reason to set to null: it is already submitted
                    if ($this->order->IsSubmitted()) {
                        $this->order = null;
                    }
                    //second reason to set to null: make sure we have permissions
                    elseif (!$this->order->canView()) {
                        $this->order = null;
                    }
                    //logged in, add Member.ID to order->MemberID
                    elseif ($loggedInMember && $loggedInMember->exists()) {
                        if ($this->order->MemberID != $loggedInMember->ID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                            $updateMember = false;
                            if (!$this->order->MemberID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $updateMember = true;
                            }
                            if (!$loggedInMember->IsShopAdmin()) {
                                $updateMember = true;
                            }
                            if ($updateMember) {
                                $this->order->MemberID = $loggedInMember->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $this->order->write();
                            }
                        }
                        //IF current order has nothing in it AND the member already has an order: use the old one first
                        //first, lets check if the current order is worthwhile keeping
                        if ($this->order->StatusID || $this->order->TotalItems()) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                            //do NOTHING!
                        } else {
                            $firstStep = OrderStep::get()->First();
                            //we assume the first step always exists.
                            //TODO: what sort order?
                            $count = 0;
                            while (
                                $firstStep &&
                                $previousOrderFromMember = Order::get()
                                    ->where('
                                        "MemberID" = '.$loggedInMember->ID.'
                                        AND ("StatusID" = '.$firstStep->ID.' OR "StatusID" = 0)
                                        AND "Order"."ID" <> '.$this->order->ID
                                    )
                                    ->First()
                            ) {
                                //arbritary 12 attempts ...
                                if ($count > 12) {
                                    break;
                                }
                                ++$count;
                                if ($previousOrderFromMember && $previousOrderFromMember->canView()) {
                                    if ($previousOrderFromMember->StatusID || $previousOrderFromMember->TotalItems()) {
                                        $this->order->delete();
                                        $this->order = $previousOrderFromMember;
                                        break;
                                    } else {
                                        $previousOrderFromMember->delete();
                                    }
                                }
                            }
                        }
                    }
                }
                if (! $this->order) {
                    if ($loggedInMember) {
                        //find previour order...
                        $firstStep = OrderStep::get()->First();
                        if ($firstStep) {
                            $previousOrderFromMember = Order::get()
                                ->filter(array(
                                    'MemberID' => $loggedInMember->ID,
                                    'StatusID' => array($firstStep->ID, 0),
                                ))
                                ->First();
                            if ($previousOrderFromMember) {
                                if ($previousOrderFromMember->canView()) {
                                    $this->order = $previousOrderFromMember;
                                }
                            }
                        }
                    }
                    if ($this->order && !$this->order->exists()) {
                        $this->order = null;
                    }
                    if (! $this->order) {
                        //here we cleanup old orders, because they should be
                        //cleaned at the same rate that they are created...
                        if (EcommerceConfig::get('ShoppingCart', 'cleanup_every_time')) {
                            $cartCleanupTask = EcommerceTaskCartCleanup::create();
                            $cartCleanupTask->runSilently();
                        }
                        //create new order
                        $this->order = Order::create();
                        if ($loggedInMember) {
                            $this->order->MemberID = $loggedInMember->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        }
                        $this->order->write();
                    }
                    $sessionVariableName = $this->sessionVariableName('OrderID');
                    Session::set($sessionVariableName, intval($this->order->ID));
                }
                if ($this->order){
                    if($this->order->exists()) {
                        $this->order->calculateOrderAttributes($force = false);
                    }
                    if (! $this->order->SessionID) {
                        $this->order->write();
                    }
                    //add session ID...
                }
            }
            //try it again
            //but limit to three, just in case ...
            //just in case ...
            if (!$this->order && $recurseCount < 3) {
                ++$recurseCount;

                return $this->currentOrder($recurseCount, $order);
            }

            return $this->order;
        } else {

            //we still return an order so that we do not end up with errors...
            return Order::create();
        }
    }


    private static $_allow_writes_cache = null;

    /**
     * can the current user use sessions and therefore write to cart???
     * the method also returns if an order has explicitely been set
     * @return Boolean
     */
    protected function allowWrites()
    {
        if(self::$_allow_writes_cache === null) {
            if($this->order) {
                self::$_allow_writes_cache = true;
            } else {
                if ( php_sapi_name() !== 'cli' ) {
                    if ( version_compare(phpversion(), '5.4.0', '>=') ) {
                        self::$_allow_writes_cache = session_status() === PHP_SESSION_ACTIVE ? true : false;
                    } else {
                        self::$_allow_writes_cache = session_id() === '' ? true : false;
                    }
                } else {
                    self::$_allow_writes_cache = false;
                }
            }
        }

        return self::$_allow_writes_cache;

    }

    /**
     * Allows access to the current order from anywhere in the code..
     *
     * @param Order $order (optional)

     *
     * @return ShoppingCart Object
     */
    public function Link($order = null)

    {
        $order = self::singleton()->currentOrder(0, $order = null);
        if ($order) {
            return $order->Link();
        }
    }

    /**
     * Adds any number of items to the cart.
     * Returns the order item on succes OR false on failure.
     *
     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart

     * @param float      $quantity   - number of items add.

     * @param mixed      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
     *                                 if you make it a form, it will save the form into the orderitem
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @return false | DataObject (OrderItem)

     */
    public function addBuyable(BuyableModel $buyable, $quantity = 1, $parameters = array())
    {
        if($this->allowWrites()) {
            if (!$buyable) {
                $this->addMessage(_t('Order.ITEMCOULDNOTBEFOUND', 'This item could not be found.'), 'bad');
                return false;
            }
            if (!$buyable->canPurchase()) {
                $this->addMessage(_t('Order.ITEMCOULDNOTBEADDED', 'This item is not for sale.'), 'bad');
                return false;
            }
            $item = $this->prepareOrderItem($buyable, $parameters, $mustBeExistingItem = false);
            $quantity = $this->prepareQuantity($buyable, $quantity);
            if ($item && $quantity) { //find existing order item or make one
                $item->Quantity += $quantity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $item->write();
                $this->currentOrder()->Attributes()->add($item); //save to current order

                //TODO: distinquish between incremented and set
                //TODO: use sprintf to allow product name etc to be included in message
                if ($quantity > 1) {
                    $msg = _t('Order.ITEMSADDED', 'Items added.');
                } else {
                    $msg = _t('Order.ITEMADDED', 'Item added.');
                }
                $this->addMessage($msg, 'good');
            } elseif (!$item) {
                $this->addMessage(_t('Order.ITEMNOTFOUND', 'Item could not be found.'), 'bad');
            } else {
                $this->addMessage(_t('Order.ITEMCOULDNOTBEADDED', 'Item could not be added.'), 'bad');
            }

            return $item;
        }
    }

    /**
     * Sets quantity for an item in the cart.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart

     * @param float      $quantity   - number of items add.
     * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
     *
     * @return false | DataObject (OrderItem) | null

     */
    public function setQuantity(BuyableModel $buyable, $quantity, array $parameters = array())
    {
        if($this->allowWrites()) {
            $item = $this->prepareOrderItem($buyable, $parameters, $mustBeExistingItem = false);
            $quantity = $this->prepareQuantity($buyable, $quantity);
            if ($item) {
                $item->Quantity = $quantity; //remove quantity
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $item->write();
                $this->addMessage(_t('Order.ITEMUPDATED', 'Item updated.'), 'good');

                return $item;
            } else {
                $this->addMessage(_t('Order.ITEMNOTFOUND', 'Item could not be found.'), 'bad');
            }

            return false;
        }
    }

    /**
     * Removes any number of items from the cart.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param DataObject $buyable    - the buyable (generally a product) being added to the cart

     * @param float      $quantity   - number of items add.

     * @param array      $parameters - array of parameters to target a specific order item. eg: group=1, length=5
     *
     * @return false | OrderItem | null

     */
    public function decrementBuyable(BuyableModel $buyable, $quantity = 1, array $parameters = array())
    {
        if($this->allowWrites()) {
            $item = $this->prepareOrderItem($buyable, $parameters, $mustBeExistingItem = false);
            $quantity = $this->prepareQuantity($buyable, $quantity);
            if ($item) {
                $item->Quantity -= $quantity; //remove quantity
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                if ($item->Quantity < 0) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    $item->Quantity = 0;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                }
                $item->write();
                if ($quantity > 1) {
                    $msg = _t('Order.ITEMSREMOVED', 'Items removed.');
                } else {
                    $msg = _t('Order.ITEMREMOVED', 'Item removed.');
                }
                $this->addMessage($msg, 'good');

                return $item;
            } else {
                $this->addMessage(_t('Order.ITEMNOTFOUND', 'Item could not be found.'), 'bad');
            }

            return false;
        }

    }

    /**
     * Delete item from the cart.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param OrderItem $buyable    - the buyable (generally a product) being added to the cart

     * @param array     $parameters - array of parameters to target a specific order item. eg: group=1, length=5
     *
     * @return bool | item | null - successfully removed

     */
    public function deleteBuyable(BuyableModel $buyable, array $parameters = array())
    {
        if($this->allowWrites()) {
            $item = $this->prepareOrderItem($buyable, $parameters, $mustBeExistingItem = true);
            if ($item) {
                $this->currentOrder()->Attributes()->remove($item);

                $item->delete();
                $item->destroy();
                $this->addMessage(_t('Order.ITEMCOMPLETELYREMOVED', 'Item removed from cart.'), 'good');

                return $item;
            } else {
                $this->addMessage(_t('Order.ITEMNOTFOUND', 'Item could not be found.'), 'bad');

                return false;
            }
        }
    }

    /**
     * Checks and prepares variables for a quantity change (add, edit, remove) for an Order Item.
     *
     * @param DataObject    $buyable             - the buyable (generally a product) being added to the cart

     * @param float         $quantity            - number of items add.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param bool          $mustBeExistingItems - if false, the Order Item gets created if it does not exist - if TRUE the order item is searched for and an error shows if there is no Order item.
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array | Form  $parameters          - array of parameters to target a specific order item. eg: group=1, length=5*
     *                                           - form saved into item...
     *
     * @return bool | DataObject ($orderItem)

     */
    protected function prepareOrderItem(BuyableModel $buyable, $parameters = array(), $mustBeExistingItem = true)
    {
        $parametersArray = $parameters;
        $form = null;
        if ($parameters instanceof Form) {
            $parametersArray = array();
            $form = $parameters;
        }
        if (!$buyable) {
            user_error('No buyable was provided', E_USER_WARNING);
        }
        if (!$buyable->canPurchase()) {
            $item = $this->getExistingItem($buyable, $parametersArray);
            if ($item && $item->exists()) {
                $item->delete();
                $item->destroy();
            }

            return false;
        }
        $item = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if ($mustBeExistingItem) {
            $item = $this->getExistingItem($buyable, $parametersArray);
        } else {
            $item = $this->findOrMakeItem($buyable, $parametersArray); //find existing order item or make one
        }
        if (!$item) {
            //check for existence of item
            return false;
        }
        if ($form) {
            $form->saveInto($item);
        }

        return $item;
    }

    /**
     * @todo: what does this method do???
     *
     * @return int

     *
     * @param DataObject ($buyable)
     * @param float $quantity
     */
    protected function prepareQuantity(BuyableModel $buyable, $quantity)
    {
        $quantity = round($quantity, $buyable->QuantityDecimals());
        if ($quantity < 0 || (!$quantity && $quantity !== 0)) {
            $this->addMessage(_t('Order.INVALIDQUANTITY', 'Invalid quantity.'), 'warning');

            return false;
        }

        return $quantity;
    }

    /**
     * Helper function for making / retrieving order items.
     * we do not need things like "canPurchase" here, because that is with the "addBuyable" method.
     * NOTE: does not write!
     *
     * @param DataObject $buyable

     * @param array      $parameters
     *
     * @return OrderItem
     */
    public function findOrMakeItem(BuyableModel $buyable, array $parameters = array())
    {
        if($this->allowWrites()) {
            if ($item = $this->getExistingItem($buyable, $parameters)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //do nothing
            } else {
                //otherwise create a new item
                if (!($buyable instanceof BuyableModel)) {
                    $this->addMessage(_t('ShoppingCart.ITEMNOTFOUND', 'Item is not buyable.'), 'bad');

                    return false;
                }
                $className = $buyable->classNameForOrderItem();
                $item = new $className();
                if ($order = $this->currentOrder()) {
                    $item->OrderID = $order->ID;
                    $item->BuyableID = $buyable->ID;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    $item->BuyableClassName = $buyable->ClassName;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    if (isset($buyable->Version)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                        $item->Version = $buyable->Version;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    }
                }
            }
            if ($parameters) {

                $item->Parameters = $parameters;
            }

            return $item;
        } else {
            return OrderItem::create();
        }
    }

    /**
     * submit the order so that it is no longer available
     * in the cart but will continue its journey through the
     * order steps.
     *
     * @return bool
     */
    public function submit()
    {
        if($this->allowWrites()) {
            $this->currentOrder()->tryToFinaliseOrder();
            $this->clear();
            //little hack to clear static memory
            OrderItem::reset_price_has_been_fixed($this->currentOrder()->ID);

            return true;
        }

        return false;
    }

    /**
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @return bool | null

     */
    public function save()
    {
        if($this->allowWrites()) {
            $this->currentOrder()->write();
            $this->addMessage(_t('Order.ORDERSAVED', 'Order Saved.'), 'good');

            return true;
        }
    }

    /**
     * Clears the cart contents completely by removing the orderID from session, and
     * thus creating a new cart on next request.
     *
     * @return bool
     */
    public function clear()
    {
        //we keep this here so that a flush can be added...
        set_time_limit(1 * 60);
        self::$_singletoncart = null;
        $this->order = null;
        $this->messages = array();
        foreach (self::$session_variable_names as $name) {
            $sessionVariableName = $this->sessionVariableName($name);
            Session::set($sessionVariableName, null);
            Session::clear($sessionVariableName);
            Session::save();
        }
        $memberID = Intval(Member::currentUserID());
        if ($memberID) {
            $orders = Order::get()->filter(array('MemberID' => $memberID));
            if ($orders && $orders->count()) {
                foreach ($orders as $order) {
                    if (! $order->IsSubmitted()) {
                        $order->delete();
                    }
                }
            }
        }

        return true;
    }

    /**
     * alias for clear.
     */
    public function reset()
    {
        return $this->clear();
    }

    /**
     * Removes a modifier from the cart
     * It does not actually remove it, but it just
     * sets it as "removed", to avoid that it is being
     * added again.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param OrderModifier $modifier
     *
     * @return bool | null

     */
    public function removeModifier(OrderModifier $modifier)
    {
        if($this->allowWrites()) {
            $modifier = (is_numeric($modifier)) ? OrderModifier::get()->byID($modifier) : $modifier;
            if (!$modifier) {
                $this->addMessage(_t('Order.MODIFIERNOTFOUND', 'Modifier could not be found.'), 'bad');

                return false;
            }
            if (!$modifier->CanBeRemoved()) {
                $this->addMessage(_t('Order.MODIFIERCANNOTBEREMOVED', 'Modifier can not be removed.'), 'bad');

                return false;
            }
            $modifier->HasBeenRemoved = 1;
            $modifier->onBeforeRemove();
            $modifier->write();
            $modifier->onAfterRemove();
            $this->addMessage(_t('Order.MODIFIERREMOVED', 'Removed.'), 'good');

            return true;
        }
    }

    /**
     * Removes a modifier from the cart.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param Int/ OrderModifier
     *
     * @return bool

     */
    public function addModifier($modifier)
    {
        if($this->allowWrites()) {
            if (is_numeric($modifier)) {
                $modifier = OrderModifier::get()->byID($modifier);
            } elseif (!(is_a($modifier, Object::getCustomClass('OrderModifier')))) {
                user_error('Bad parameter provided to ShoppingCart::addModifier', E_USER_WARNING);
            }
            if (!$modifier) {
                $this->addMessage(_t('Order.MODIFIERNOTFOUND', 'Modifier could not be found.'), 'bad');

                return false;
            }
            $modifier->HasBeenRemoved = 0;
            $modifier->write();
            $this->addMessage(_t('Order.MODIFIERREMOVED', 'Added.'), 'good');

            return true;
        }
    }

    /**
     * Sets an order as the current order.
     *
     * @param int | Order $order
     *
     * @return bool
     */
    public function loadOrder($order)
    {
        if($this->allowWrites()) {
            //TODO: how to handle existing order
            //TODO: permission check - does this belong to another member? ...or should permission be assumed already?
            if (is_numeric($order)) {
                $this->order = Order::get()->byID($order);
            } elseif (is_a($order, Object::getCustomClass('Order'))) {
                $this->order = $order;
            } else {
                user_error('Bad order provided as parameter to ShoppingCart::loadOrder()');
            }
            if ($this->order) {
                //first can view and then, if can view, set as session...
                if ($this->order->canView()) {
                    $this->order->init(true);
                    $sessionVariableName = $this->sessionVariableName('OrderID');
                    //we set session ID after can view check ...
                    Session::set($sessionVariableName, $this->order->ID);
                    $this->addMessage(_t('Order.LOADEDEXISTING', 'Order loaded.'), 'good');

                    return true;
                } else {
                    $this->addMessage(_t('Order.NOPERMISSION', 'You do not have permission to view this order.'), 'bad');

                    return false;
                }
            } else {
                $this->addMessage(_t('Order.NOORDER', 'Order can not be found.'), 'bad');

                return false;
            }
        } else {
            $this->addMessage(_t('Order.NOSAVE', 'You can not load orders as your session functionality is turned off.'), 'bad');

            return false;
        }

    }

    /**
     * NOTE: tried to copy part to the Order Class - but that was not much of a go-er.
     *
     * returns null if the current user does not allow order manipulation or saving (e.g. session disabled)
     *
     * @param int | Order $order
     *
     * @return Order | false | null

     **/
    public function copyOrder($oldOrder)
    {
        if($this->allowWrites()) {
            if (is_numeric($oldOrder)) {
                $oldOrder = Order::get()->byID(intval($oldOrder));
            } elseif (is_a($oldOrder, Object::getCustomClass('Order'))) {

                //$oldOrder = $oldOrder;

            } else {
                user_error('Bad order provided as parameter to ShoppingCart::loadOrder()');
            }
            if ($oldOrder) {
                if ($oldOrder->canView() && $oldOrder->IsSubmitted()) {
                    $newOrder = Order::create();
                    //copying fields.
                    $newOrder->UseShippingAddress = $oldOrder->UseShippingAddress;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    //important to set it this way...
                    $newOrder->setCurrency($oldOrder->CurrencyUsed());
                    $newOrder->MemberID = $oldOrder->MemberID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    //load the order
                    $newOrder->write();
                    $this->loadOrder($newOrder);
                    $items = OrderItem::get()
                        ->filter(array('OrderID' => $oldOrder->ID));
                    if ($items->count()) {
                        foreach ($items as $item) {
                            $buyable = $item->Buyable($current = true);
                            if ($buyable->canPurchase()) {
                                $this->addBuyable($buyable, $item->Quantity);
                            }
                        }
                    }
                    $newOrder->CreateOrReturnExistingAddress('BillingAddress');
                    $newOrder->CreateOrReturnExistingAddress('ShippingAddress');
                    $newOrder->write();
                    $this->addMessage(_t('Order.ORDERCOPIED', 'Order has been copied.'), 'good');

                    return $newOrder;
                } else {
                    $this->addMessage(_t('Order.NOPERMISSION', 'You do not have permission to view this order.'), 'bad');

                    return false;
                }
            } else {
                $this->addMessage(_t('Order.NOORDER', 'Order can not be found.'), 'bad');

                return false;
            }
        }
    }

    /**
     * sets country in order so that modifiers can be recalculated, etc...
     *
     * @param string - $countryCode
     *
     * @return bool

     **/
    public function setCountry($countryCode)
    {
        if($this->allowWrites()) {
            if (EcommerceCountry::code_allowed($countryCode)) {
                $this->currentOrder()->SetCountryFields($countryCode);
                $this->addMessage(_t('Order.UPDATEDCOUNTRY', 'Updated country.'), 'good');

                return true;
            } else {
                $this->addMessage(_t('Order.NOTUPDATEDCOUNTRY', 'Could not update country.'), 'bad');

                return false;
            }
        }
    }

    /**
     * sets region in order so that modifiers can be recalculated, etc...
     *
     * @param int | String - $regionID you can use the ID or the code.
     *
     * @return bool
     **/
    public function setRegion($regionID)
    {
        if (EcommerceRegion::regionid_allowed($regionID)) {
            $this->currentOrder()->SetRegionFields($regionID);
            $this->addMessage(_t('ShoppingCart.REGIONUPDATED', 'Region updated.'), 'good');

            return true;
        } else {
            $this->addMessage(_t('ORDER.NOTUPDATEDREGION', 'Could not update region.'), 'bad');

            return false;
        }
    }

    /**
     * sets the display currency for the cart.
     *
     * @param string $currencyCode
     *
     * @return bool
     **/
    public function setCurrency($currencyCode)
    {
        $currency = EcommerceCurrency::get_one_from_code($currencyCode);
        if ($currency) {
            if ($this->currentOrder()->MemberID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $member = $this->currentOrder()->Member();

                if ($member && $member->exists()) {
                    $member->SetPreferredCurrency($currency);
                }
            }
            $this->currentOrder()->UpdateCurrency($currency);
            $msg = _t('Order.CURRENCYUPDATED', 'Currency updated.');
            $this->addMessage($msg, 'good');

            return true;
        } else {
            $msg = _t('Order.CURRENCYCOULDNOTBEUPDATED', 'Currency could not be updated.');
            $this->addMessage($msg, 'bad');

            return false;
        }
    }

    /**
     * Produces a debug of the shopping cart.
     */
    public function debug()
    {
        if (Director::isDev() || Permission::check('ADMIN')) {
            debug::show($this->currentOrder());

            echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Country</h1>';
            echo 'GEOIP Country: '.EcommerceCountry::get_country_from_ip().'<br />';
            echo 'Calculated Country Country: '.EcommerceCountry::get_country().'<br />';

            echo '<blockquote><blockquote><blockquote><blockquote>';

            echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Items</h1>';
            $items = $this->currentOrder()->Items();
            echo $items->sql();
            echo '<hr />';
            if ($items->count()) {
                foreach ($items as $item) {
                    Debug::show($item);
                }
            } else {
                echo '<p>there are no items for this order</p>';
            }

            echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Modifiers</h1>';
            $modifiers = $this->currentOrder()->Modifiers();
            if ($modifiers->count()) {
                foreach ($modifiers as $modifier) {
                    Debug::show($modifier);
                }
            } else {
                echo '<p>there are no modifiers for this order</p>';
            }

            echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Addresses</h1>';
            $billingAddress = $this->currentOrder()->BillingAddress();

            if ($billingAddress && $billingAddress->exists()) {
                Debug::show($billingAddress);
            } else {
                echo '<p>there is no billing address for this order</p>';
            }
            $shippingAddress = $this->currentOrder()->ShippingAddress();

            if ($shippingAddress && $shippingAddress->exists()) {
                Debug::show($shippingAddress);
            } else {
                echo '<p>there is no shipping address for this order</p>';
            }

            $currencyUsed = $this->currentOrder()->CurrencyUsed();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($currencyUsed && $currencyUsed->exists()) {
                echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Currency</h1>';
                Debug::show($currencyUsed);
            }

            $cancelledBy = $this->currentOrder()->CancelledBy();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            if ($cancelledBy && $cancelledBy->exists()) {
                echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Cancelled By</h1>';
                Debug::show($cancelledBy);
            }

            $logs = $this->currentOrder()->OrderStatusLogs();

            if ($logs && $logs->count()) {
                echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Logs</h1>';
                foreach ($logs as $log) {
                    Debug::show($log);
                }
            }

            $payments = $this->currentOrder()->Payments();

            if ($payments  && $payments->count()) {
                echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Payments</h1>';
                foreach ($payments as $payment) {
                    Debug::show($payment);
                }
            }

            $emails = $this->currentOrder()->Emails();

            if ($emails && $emails->count()) {
                echo '<hr /><hr /><hr /><hr /><hr /><hr /><h1>Emails</h1>';
                foreach ($emails as $email) {
                    Debug::show($email);
                }
            }

            echo '</blockquote></blockquote></blockquote></blockquote>';
        } else {
            echo 'Please log in as admin first';
        }
    }

    /**
     * Stores a message that can later be returned via ajax or to $form->sessionMessage();.
     *
     * @param $message - the message, which could be a notification of successful action, or reason for failure
     * @param $type - please use good, bad, warning
     */
    public function addMessage($message, $status = 'good')
    {
        //clean status for the lazy programmer
        //TODO: remove the awkward replace
        $status = strtolower($status);
        str_replace(array('success', 'failure'), array('good', 'bad'), $status);
        $statusOptions = array('good', 'bad', 'warning');
        if (!in_array($status, $statusOptions)) {
            user_error('Message status should be one of the following: '.implode(',', $statusOptions), E_USER_NOTICE);
        }
        $this->messages[] = array(
            'Message' => $message,
            'Type' => $status,
        );
    }

    /*******************************************************
    * HELPER FUNCTIONS
    *******************************************************/

    /**
     * Gets an existing order item based on buyable and passed parameters.
     *
     * @param DataObject $buyable

     * @param array      $parameters
     *
     * @return OrderItem | null

     */
    protected function getExistingItem(BuyableModel $buyable, array $parameters = array())
    {
        $filterString = $this->parametersToSQL($parameters);
        if ($order = $this->currentOrder()) {
            $orderID = $order->ID;
            $obj = OrderItem::get()
                ->where(
                    " \"BuyableClassName\" = '".$buyable->ClassName."' AND
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    \"BuyableID\" = ".$buyable->ID.' AND
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
                    "OrderID" = '.$orderID.' '.
                    $filterString
                )
                ->First();

            return $obj;
        }
    }

    /**
     * Removes parameters that aren't in the default array, merges with default parameters, and converts raw2SQL.
     *
     * @param array $parameters
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return cleaned array

     */
    protected function cleanParameters(array $params = array())
    {
        $defaultParamFilters = EcommerceConfig::get('ShoppingCart', 'default_param_filters');
        $newarray = array_merge(array(), $defaultParamFilters); //clone array
        if (!count($newarray)) {
            return array(); //no use for this if there are not parameters defined
        }
        foreach ($newarray as $field => $value) {
            if (isset($params[$field])) {
                $newarray[$field] = Convert::raw2sql($params[$field]);
            }
        }

        return $newarray;
    }

    /**
     * @param array $parameters
     *                          Converts parameter array to SQL query filter
     */
    protected function parametersToSQL(array $parameters = array())
    {
        $defaultParamFilters = EcommerceConfig::get('ShoppingCart', 'default_param_filters');
        if (!count($defaultParamFilters)) {
            return ''; //no use for this if there are not parameters defined
        }
        $cleanedparams = $this->cleanParameters($parameters);
        $outputArray = array();
        foreach ($cleanedparams as $field => $value) {
            $outputarray[$field] = '"'.$field.'" = '.$value;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        if (count($outputArray)) {
            return implode(' AND ', $outputArray);
        }

        return '';
    }

    /*******************************************************
    * UI MESSAGE HANDLING
    *******************************************************/

    /**
     * Retrieves all good, bad, and ugly messages that have been produced during the current request.
     *
     * @return array of messages
     */
    public function getMessages()
    {
        $sessionVariableName = $this->sessionVariableName('Messages');
        //get old messages
        $messages = unserialize(Session::get($sessionVariableName));
        //clear old messages
        Session::clear($sessionVariableName, '');

        //set to form????

        if ($messages && count($messages)) {
            $this->messages = array_merge($messages, $this->messages);
        }

        return $this->messages;
    }

    /**
     *Saves current messages in session for retrieving them later.
     *
     *@return array of messages

     */
    protected function StoreMessagesInSession()
    {
        $sessionVariableName = $this->sessionVariableName('Messages');
        Session::set($sessionVariableName, serialize($this->messages));
    }

    /**
     * This method is used to return data after an ajax call was made.
     * When a asynchronious request is made to the shopping cart (ajax),
     * then you will first action the request and then use this function
     * to return some values.
     *
     * It can also be used without ajax, in wich case it will redirects back
     * to the last page.
     *
     * Note that you can set the ajax response class in the configuration file.
     *
     *
     * @param string $message
     * @param string $status
     * @param Form   $form

     * @returns String (JSON)
     */
    public function setMessageAndReturn($message = '', $status = '', Form $form = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($message && $status) {
            $this->addMessage($message, $status);
        }
        //TODO: handle passing back multiple messages

        if (Director::is_ajax()) {
            $responseClass = EcommerceConfig::get('ShoppingCart', 'response_class');
            $obj = new $responseClass();

            return $obj->ReturnCartData($this->getMessages());
        } else {
            //TODO: handle passing a message back to a form->sessionMessage
            $this->StoreMessagesInSession();
            if ($form) {
                //lets make sure that there is an order
                $this->currentOrder();
                //nowe we can (re)calculate the order
                $this->order->calculateOrderAttributes($force = false);
                $form->sessionMessage($message, $status);
                //let the form controller do the redirectback or whatever else is needed.
            } else {
                if (empty($_REQUEST['BackURL']) && Controller::has_curr()) {
                    Controller::curr()->redirectBack();
                } else {
                    Controller::curr()->redirect(urldecode($_REQUEST['BackURL']));
                }
            }

            return;
        }
    }

    /**
     * @return EcommerceDBConfig
     */
    protected function EcomConfig()
    {
        return EcommerceDBConfig::current_ecommerce_db_config();
    }

    /**
     * Return the name of the session variable that should be used.
     *
     * @param string $name
     *
     * @return string
     */
    protected function sessionVariableName($name = '')
    {
        if (!in_array($name, self::$session_variable_names)) {
            user_error("Tried to set session variable $name, that is not in use", E_USER_NOTICE);
        }
        $sessionCode = EcommerceConfig::get('ShoppingCart', 'session_code');

        return $sessionCode.'_'.$name;
    }
}

Push — master ( ce2dd0...10a6ac )

ShoppingCart::cleanParameters() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

sunnysideup / silverstripe-ecommerce

Push — master ( ce2dd0...10a6ac )

ShoppingCart::cleanParameters() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like
