EcommercePayment_TestPending - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/sunnys..." - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a7943...bccb03 )

by Nicolaas

created 2017-07-17 03:32 UTC

EcommercePayment_TestPending A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
dl	0
loc	47
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	4

4 Methods

Rating	Name	Size	Complexity
A	i18n_singular_name()	4	1
A	i18n_plural_name()	4	1
A	processPayment()	8	1
A	getPaymentFormFields()	6	1

<?php

/**
 * Payment object representing a TEST = PENDING.
 */
class EcommercePayment_TestPending extends EcommercePayment_Test
namespace YourVendor;

class YourClass { }
{

    /**
     * standard SS variable.
     *
     * @Var String
     */
    private static $singular_name = 'Ecommerce Test Pending Payment';

    public function i18n_singular_name()

    {
        return $this->Config()->get('singular_name');
    }

    /**
     * standard SS variable.
     *
     * @Var String
     */
    private static $plural_name = 'Ecommerce Test Pending Payments';

    public function i18n_plural_name()

    {
        return $this->Config()->get('plural_name');
    }

    /**
     * @param array     $data The form request data - see OrderForm
     * @param OrderForm $form The form object submitted on
     *
     * @return EcommercePayment_Result
     */
    public function processPayment($data, $form)
    {
        $this->Status = 'Pending';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->Message = '<div>PAYMENT TEST: PENDING</div>';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->write();

        return new EcommercePayment_Processing();
    }

    public function getPaymentFormFields()
    {
        return new FieldList(
            new LiteralField('SuccessBlurb', '<div>PENDING PAYMENT TEST</div>')
        );
    }
}


1			<?php
2
3			/**
4			* Payment object representing a TEST = PENDING.
5			*/
6			class EcommercePayment_TestPending extends EcommercePayment_Test
			0 ignored issues – show Coding Style Compatibility introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8
9			/**
10			* standard SS variable.
11			*
12			* @Var String
13			*/
14			private static $singular_name = 'Ecommerce Test Pending Payment';
			0 ignored issues – show Comprehensibility introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
15			public function i18n_singular_name()
			0 ignored issues – show Documentation introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
16			{
17			return $this->Config()->get('singular_name');
18			}
19
20			/**
21			* standard SS variable.
22			*
23			* @Var String
24			*/
25			private static $plural_name = 'Ecommerce Test Pending Payments';
			0 ignored issues – show Comprehensibility introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			public function i18n_plural_name()
			0 ignored issues – show Documentation introduced 2017-07-17 03:35 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
27			{
28			return $this->Config()->get('plural_name');
29			}
30
31			/**
32			* @param array $data The form request data - see OrderForm
33			* @param OrderForm $form The form object submitted on
34			*
35			* @return EcommercePayment_Result
36			*/
37			public function processPayment($data, $form)
38			{
39			$this->Status = 'Pending';
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The property `Status` does not exist on `object<EcommercePayment_TestPending>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			$this->Message = '<div>PAYMENT TEST: PENDING</div>';
			0 ignored issues – show Documentation introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The property `Message` does not exist on `object<EcommercePayment_TestPending>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41			$this->write();
42
43			return new EcommercePayment_Processing();
44			}
45
46			public function getPaymentFormFields()
47			{
48			return new FieldList(
49			new LiteralField('SuccessBlurb', '<div>PENDING PAYMENT TEST</div>')
50			);
51			}
52			}
53

sunnysideup / silverstripe-ecommerce

Push — master ( 3a7943...bccb03 )

EcommercePayment_TestPending A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like