EcommerceTaskDeleteProducts::run() - Code Metrics - sunnysideup/silverstripe-ecommerce - Measure and Improve Code Quality continuously with Scrutinizer

EcommerceTaskDeleteProducts::run() A
last analyzed 2019-09-15 09:38 UTC

↳ Parent: EcommerceTaskDeleteProducts

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
dl	0
loc	20
rs	9.2888
c	0
b	0
f	0
nc	5
nop	1

<?php

/**
 * @description: see description
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: tasks
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class EcommerceTaskDeleteProducts extends BuildTask
{
    private static $allowed_actions = array(
        '*' => 'ADMIN',
    );

    protected $title = 'Delete e-commerce Buyables';

    protected $description = 'Removes all Buyables (Products) from the database.';

    public function run($request)
    {
        $arrayOfBuyables = EcommerceConfig::get('EcommerceDBConfig', 'array_of_buyables');
        foreach ($arrayOfBuyables as $buyable) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $allproducts = $buyable::get();
            if ($allproducts->count()) {
                foreach ($allproducts as $product) {
                    DB::alteration_message('Deleting '.$product->ClassName.' ID = '.$product->ID, 'deleted');
                    if (is_a($product, Object::getCustomClass('SiteTree'))) {
                        $product->deleteFromStage('Live');
                        $product->deleteFromStage('Draft');
                    } else {
                        $product->delete();
                    }
                    $product->destroy();
                    //TODO: remove versions
                }
            }
        }
    }
}


1			<?php
2
3			/**
4			* @description: see description
5			*
6			* @authors: Nicolaas [at] Sunny Side Up .co.nz
7			* @package: ecommerce
8			* @sub-package: tasks
9			* @inspiration: Silverstripe Ltd, Jeremy
10			**/
11			class EcommerceTaskDeleteProducts extends BuildTask
12			{
13			private static $allowed_actions = array(
14			'*' => 'ADMIN',
15			);
16
17			protected $title = 'Delete e-commerce Buyables';
18
19			protected $description = 'Removes all Buyables (Products) from the database.';
20
21			public function run($request)
22			{
23			$arrayOfBuyables = EcommerceConfig::get('EcommerceDBConfig', 'array_of_buyables');
24			foreach ($arrayOfBuyables as $buyable) {
			0 ignored issues – show Bug introduced 2016-12-20 03:49 UTC by Report Bug Copy Issue Report The expression `$arrayOfBuyables` of type `array\|integer\|double\|string\|boolean` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
25			$allproducts = $buyable::get();
26			if ($allproducts->count()) {
27			foreach ($allproducts as $product) {
28			DB::alteration_message('Deleting '.$product->ClassName.' ID = '.$product->ID, 'deleted');
29			if (is_a($product, Object::getCustomClass('SiteTree'))) {
30			$product->deleteFromStage('Live');
31			$product->deleteFromStage('Draft');
32			} else {
33			$product->delete();
34			}
35			$product->destroy();
36			//TODO: remove versions
37			}
38			}
39			}
40			}
41			}
42

sunnysideup / silverstripe-ecommerce

EcommerceTaskDeleteProducts::run() A last analyzed 2019-09-15 09:38 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

EcommerceTaskDeleteProducts::run() A
last analyzed 2019-09-15 09:38 UTC