OrderStep

Complexity

Total Complexity

180

Size/Duplication

Total Lines	1444
Duplicated Lines	0 %

Coupling/Cohesion

Components	4
Dependencies	24

Importance

Changes

0

76 Methods

Rating	Name	Duplication	Size	Complexity
A	Title()	0	4	1
A	getTitle()	0	4	1
A	CustomerCanEditNice()	0	4	1
A	getCustomerCanEditNice()	0	8	2
A	CustomerCanPayNice()	0	4	1
A	getCustomerCanPayNice()	0	8	2
A	CustomerCanCancelNice()	0	4	1
A	getCustomerCanCancelNice()	0	8	2
A	ShowAsUncompletedOrderNice()	0	4	1
A	getShowAsUncompletedOrderNice()	0	8	2
A	ShowAsInProcessOrderNice()	0	4	1
A	getShowAsInProcessOrderNice()	0	8	2
A	ShowAsCompletedOrderNice()	0	4	1
A	getShowAsCompletedOrderNice()	0	8	2
A	HideFromEveryone()	0	4	1
A	HideStepFromCustomerNice()	0	4	1
A	getHideStepFromCustomerNice()	0	8	2
A	i18n_singular_name()	0	4	1
A	i18n_plural_name()	0	4	1
A	admin_manageable_steps()	0	6	1
A	non_admin_manageable_steps()	0	6	1
A	last_order_step()	0	8	3
A	bad_order_step_ids()	0	12	2
A	get_status_id_from_code()	0	12	2
A	get_codes_for_order_steps_to_include()	0	13	4
A	get_not_created_codes_for_order_steps_to_include()	0	14	5
A	getMyCode()	0	9	2
A	populateDefaults()	0	5	1
C	getCMSFields()	0	116	9
A	CMSEditLink()	0	4	1
A	AlternativeDisplayPage()	0	4	1
A	addOrderStepFields()	0	4	1
A	validate()	0	18	2
A	initStep()	0	6	1
A	doStep()	0	6	1
A	nextStep()	0	17	3
A	hasPassed()	0	19	5
A	hasPassedOrIsEqualTo()	0	4	1
A	hasNotPassed()	0	4	1
A	isBefore()	0	4	2
A	isDefaultStatusOption()	0	4	1
A	getEmailClassName()	0	4	1
B	sendEmailForStep()	0	49	11
A	setEmailClassName()	0	4	1
A	testEmailLink()	0	26	4
A	hasBeenSent()	0	24	5
A	hasCustomerMessage()	0	4	1
A	HasCustomerMessageNice()	0	4	1
A	getHasCustomerMessageNice()	0	4	2
A	CalculatedEmailSubject()	0	4	1
A	CalculatedCustomerMessage()	0	4	1
A	ShowAsSummary()	0	4	1
C	getShowAsSummary()	0	33	10
A	humanReadeableDeferTimeInSeconds()	0	17	3
A	NameAndDescription()	0	4	1
A	getNameAndDescription()	0	6	1
A	CalculatedDeferTimeInSeconds()	0	4	1
A	canBeDefered()	0	4	1
A	getRelevantLogEntryClassName()	0	4	1
A	setRelevantLogEntryClassName()	0	4	1
A	RelevantLogEntry()	0	6	2
A	RelevantLogEntries()	0	10	2
A	canCreate()	0	4	1
A	canView()	0	15	4
A	canOverrideCanViewForOrder()	0	9	3
A	canEdit()	0	15	4
B	canDelete()	0	30	7
B	onBeforeWrite()	0	29	7
B	onBeforeDelete()	0	21	6
A	onAfterDelete()	0	5	1
A	NextOrderStep()	0	6	1
A	PreviousOrderStep()	0	6	1
A	requireDefaultRecords()	0	5	1
C	checkValidityOfOrderSteps()	0	66	14
A	EcomConfig()	0	4	1
A	myDescription()	0	4	1

<?php

/**
 * @description: see OrderStep.md
 *
 *
 * @authors: Nicolaas [at] Sunny Side Up .co.nz
 * @package: ecommerce
 * @sub-package: model
 * @inspiration: Silverstripe Ltd, Jeremy
 **/
class OrderStep extends DataObject implements EditableEcommerceObject
{


    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

        'Name' => 'Varchar(50)',
        'Code' => 'Varchar(50)',
        'Description' => 'Text',
        'EmailSubject' => 'Varchar(200)',
        'CustomerMessage' => 'HTMLText',
        //customer privileges
        'CustomerCanEdit' => 'Boolean',
        'CustomerCanCancel' => 'Boolean',
        'CustomerCanPay' => 'Boolean',
        //What to show the customer...
        'ShowAsUncompletedOrder' => 'Boolean',
        'ShowAsInProcessOrder' => 'Boolean',
        'ShowAsCompletedOrder' => 'Boolean',
        'HideStepFromCustomer' => 'Boolean',
        //sorting index
        'Sort' => 'Int',
        'DeferTimeInSeconds' => 'Int',
        'DeferFromSubmitTime' => 'Boolean'
    );



    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $indexes = array(

Consider using a different property name as you override a private property of the parent class.

        'Code' => true,
        'Sort' => true,
    );

    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $has_many = array(

Consider using a different property name as you override a private property of the parent class.

        'Orders' => 'Order',
        'OrderEmailRecords' => 'OrderEmailRecord',
        'OrderProcessQueueEntries' => 'OrderProcessQueue'
    );

    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

        'Sort' => 'Sorting Index',
        'CustomerCanEdit' => 'Customer can edit order',
        'CustomerCanPay' => 'Customer can pay order',
        'CustomerCanCancel' => 'Customer can cancel order',
    );

    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

        'NameAndDescription' => 'Step',
        'ShowAsSummary' => 'Phase',
    );

    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

        'Title' => 'Varchar',
        'CustomerCanEditNice' => 'Varchar',
        'CustomerCanPayNice' => 'Varchar',
        'CustomerCanCancelNice' => 'Varchar',
        'ShowAsUncompletedOrderNice' => 'Varchar',
        'ShowAsInProcessOrderNice' => 'Varchar',
        'ShowAsCompletedOrderNice' => 'Varchar',
        'HideStepFromCustomerNice' => 'Varchar',
        'HasCustomerMessageNice' => 'Varchar',
        'ShowAsSummary' => 'HTMLText',
        'NameAndDescription' => 'HTMLText'
    );

    /**
     * standard SS variable.
     *
     * @return array
     */
    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

        'Name' => array(
            'title' => 'Name',
            'filter' => 'PartialMatchFilter',
        ),
        'Code' => array(
            'title' => 'Code',
            'filter' => 'PartialMatchFilter',
        ),
    );


    /**
     * casted variable.
     *
     * @return string
     */
    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->Name;

The property Name does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function CustomerCanEditNice()
    {
        return $this->getCustomerCanEditNice();
    }
    public function getCustomerCanEditNice()
    {
        if ($this->CustomerCanEdit) {

The property CustomerCanEdit does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function CustomerCanPayNice()
    {
        return $this->getCustomerCanPayNice();
    }
    public function getCustomerCanPayNice()
    {
        if ($this->CustomerCanPay) {

The property CustomerCanPay does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function CustomerCanCancelNice()
    {
        return $this->getCustomerCanCancelNice();
    }
    public function getCustomerCanCancelNice()
    {
        if ($this->CustomerCanCancel) {

The property CustomerCanCancel does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    public function ShowAsUncompletedOrderNice()
    {
        return $this->getShowAsUncompletedOrderNice();
    }
    public function getShowAsUncompletedOrderNice()
    {
        if ($this->ShowAsUncompletedOrder) {

The property ShowAsUncompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function ShowAsInProcessOrderNice()
    {
        return $this->getShowAsInProcessOrderNice();
    }
    public function getShowAsInProcessOrderNice()
    {
        if ($this->ShowAsInProcessOrder) {

The property ShowAsInProcessOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function ShowAsCompletedOrderNice()
    {
        return $this->getShowAsCompletedOrderNice();
    }
    public function getShowAsCompletedOrderNice()
    {
        if ($this->ShowAsCompletedOrder) {

The property ShowAsCompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * do not show in steps at all.
     * @return boolean
     */
    public function HideFromEveryone()
    {
        return false;
    }

    /**
     * casted variable.
     *
     * @return string
     */
    public function HideStepFromCustomerNice()
    {
        return $this->getHideStepFromCustomerNice();
    }

    public function getHideStepFromCustomerNice()
    {
        if ($this->HideStepFromCustomer) {

The property HideStepFromCustomer does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            return _t('OrderStep.YES', 'Yes');
        }

        return _t('OrderStep.NO', 'No');
    }

    /**
     * standard SS variable.
     *
     * @return string
     */
    private static $singular_name = 'Order Step';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_singular_name()
    {
        return _t('OrderStep.ORDERSTEP', 'Order Step');
    }

    /**
     * standard SS variable.
     *
     * @return string
     */
    private static $plural_name = 'Order Steps';

Consider using a different property name as you override a private property of the parent class.

    public function i18n_plural_name()
    {
        return _t('OrderStep.ORDERSTEPS', 'Order Steps');
    }

    /**
     * Standard SS variable.
     *
     * @var string
     */
    private static $description = 'A step that any order goes through.';

    /**
     * SUPER IMPORTANT TO KEEP ORDER!
     * standard SS variable.
     *
     * @return string
     */
    private static $default_sort = '"Sort" ASC';

Consider using a different property name as you override a private property of the parent class.

    /**
     * returns all the order steps
     * that the admin should / can edit....
     *
     * @return DataList
     */
    public static function admin_manageable_steps()
    {
        $lastStep = OrderStep::last_order_step();

        return OrderStep::get()->filter(array('ShowAsInProcessOrder' => 1))->exclude(array('ID' => $lastStep->ID));
    }
    /**
     * returns all the order steps
     * that the admin should / can edit....
     *
     * @return DataList
     */
    public static function non_admin_manageable_steps()
    {
        $lastStep = OrderStep::last_order_step();

        return OrderStep::get()->filterAny(array('ShowAsInProcessOrder' => 0, 'ID' => $lastStep->ID));
    }

    private static $_last_order_step_cache = null;

    /**
     * @param bool $noCacheValues
     * @return OrderStep
     */
    public static function last_order_step($noCacheValues = false)
    {
        if (! self::$_last_order_step_cache || $noCacheValues) {
            self::$_last_order_step_cache = OrderStep::get()->Last();
        }

        return self::$_last_order_step_cache;
    }

    /**
     * return StatusIDs (orderstep IDs) from orders that are bad....
     * (basically StatusID values that do not exist)
     *
     * @return array
     */
    public static function bad_order_step_ids()
    {
        $badorderStatus = Order::get()
            ->leftJoin('OrderStep', '"OrderStep"."ID" = "Order"."StatusID"')
            ->where('"OrderStep"."ID" IS NULL AND "StatusID" > 0')
            ->column('StatusID');
        if (is_array($badorderStatus)) {
            return array_unique(array_values($badorderStatus));
        } else {
            return array(-1);
        }
    }

    /**
     * turns code into ID.
     *
     * @param string $code
     * @param int
     */
    public static function get_status_id_from_code($code)
    {
        $otherStatus = DataObject::get_one(
            'OrderStep',
            array('Code' => $code)
        );
        if ($otherStatus) {
            return $otherStatus->ID;
        }

        return 0;
    }

    /**
     *@return array
     **/
    public static function get_codes_for_order_steps_to_include()
    {
        $newArray = array();
        $array = EcommerceConfig::get('OrderStep', 'order_steps_to_include');
        if (is_array($array) && count($array)) {
            foreach ($array as $className) {
                $code = singleton($className)->getMyCode();
                $newArray[$className] = strtoupper($code);
            }
        }

        return $newArray;
    }

    /**
     * returns a list of ordersteps that have not been created yet.
     *
     * @return array

Should the return type not be integer|double|string|boolean|array?

     **/
    public static function get_not_created_codes_for_order_steps_to_include()
    {
        $array = EcommerceConfig::get('OrderStep', 'order_steps_to_include');
        if (is_array($array) && count($array)) {
            foreach ($array as $className) {
                $obj = DataObject::get_one($className);
                if ($obj) {
                    unset($array[$className]);
                }
            }
        }

        return $array;
    }

    /**
     *@return string
     **/
    public function getMyCode()
    {
        $array = Config::inst()->get($this->ClassName, 'defaults', Config::UNINHERITED);
        if (!isset($array['Code'])) {
            user_error($this->class.' does not have a default code specified');
        }

        return $array['Code'];
    }

    /**
     * IMPORTANT:: MUST HAVE Code must be defined!!!
     * standard SS variable.
     *
     * @return array
     */
    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

        'CustomerCanEdit' => 0,
        'CustomerCanCancel' => 0,
        'CustomerCanPay' => 1,
        'ShowAsUncompletedOrder' => 0,
        'ShowAsInProcessOrder' => 0,
        'ShowAsCompletedOrder' => 0,
        'Code' => 'ORDERSTEP',
    );

    /**
     * standard SS method.
     */
    public function populateDefaults()
    {
        parent::populateDefaults();
        $this->Description = $this->myDescription();

The property Description does not seem to exist. Did you mean description?

    }

    /**
     *@return FieldList
     **/
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        //replacing
        $queueField = $fields->dataFieldByName('OrderProcessQueueEntries');
        $config = $queueField->getConfig();

The method getConfig() does not exist on FormField. Did you maybe mean config()?

        $config->removeComponentsByType('GridFieldAddExistingAutocompleter');
        $config->removeComponentsByType('GridFieldDeleteAction');
        $fields->removeFieldFromTab('Root', 'OrderProcessQueueEntries');
        if ($this->canBeDefered()) {
            if ($this->DeferTimeInSeconds) {

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                $fields->addFieldToTab(
                    'Root.Queue',
                    HeaderField::create(
                        'WhenWillThisRun',
                        $this->humanReadeableDeferTimeInSeconds()
                    )
                );
            }
            $fields->addFieldToTab(
                'Root.Queue',
                $deferTimeInSecondsField = TextField::create(
                    'DeferTimeInSeconds',
                    _t('OrderStep.DeferTimeInSeconds', 'Seconds in queue')
                )
                ->setRightTitle(
                    _t(
                        'OrderStep.TIME_EXPLANATION',
                        '86,400 seconds is one day ...
                        <br />To make it easier, you can also enter things like <em>1 week</em>, <em>3 hours</em>, or <em>7 minutes</em>.
                        <br />Non-second entries will automatically be converted to seconds.'
                    )
                )
            );
            if ($this->DeferTimeInSeconds) {

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                $fields->addFieldToTab(
                    'Root.Queue',
                    $deferTimeInSecondsField = CheckboxField::create(
                        'DeferFromSubmitTime',
                        _t('OrderStep.DeferFromSubmitTime', 'Calculated from submit time?')
                    )
                    ->setDescription(
                        _t(
                            'OrderStep.DeferFromSubmitTime_HELP',
                            'The time in the queue can be calculated from the moment the current orderstep starts or from the moment the order was submitted (in this case, check the box above) '
                            )
                        )
                );
            }
            $fields->addFieldToTab(
                'Root.Queue',
                $queueField
            );
        }
        if ($this->hasCustomerMessage()) {
            $rightTitle = _t(
                'OrderStep.EXPLAIN_ORDER_NUMBER_IN_SUBJECT',
                'You can use [OrderNumber] as a tag that will be replaced with the actual Order Number.'
            );
            $fields->addFieldToTab(
                'Root.CustomerMessage',
                TextField::create('EmailSubject', _t('OrderStep.EMAILSUBJECT', 'Email Subject'))
                    ->setRightTitle($rightTitle)
            );
            if ($testEmailLink = $this->testEmailLink()) {
                $fields->addFieldToTab(
                    'Root.CustomerMessage',
                    new LiteralField(
                        'testEmailLink',
                        '<h3>
                            <a href="'.$testEmailLink.'" data-popup="true" target"_blank" onclick="emailPrompt(this, event);">
                                '._t('OrderStep.VIEW_EMAIL_EXAMPLE', 'Test Email').'
                            </a>
                        </h3>
                        <script language="javascript">
                            function emailPrompt(caller, event) {
                                event.preventDefault();
                                var href = jQuery(caller).attr("href");
                                var email = prompt("Enter an email address to receive a copy of this example in your inbox, leave blank to view in the browser");
                                if (email) {
                                    href += "&send=" + email;
                                }
                                window.open(href);
                            };
                        </script>'
                    )
                );
            }

            $fields->addFieldToTab('Root.CustomerMessage', $htmlEditorField = new HTMLEditorField('CustomerMessage', _t('OrderStep.CUSTOMERMESSAGE', 'Customer Message (if any)')));
            $htmlEditorField->setRows(3);
        } else {
            $fields->removeFieldFromTab('Root', 'OrderEmailRecords');
            $fields->removeFieldFromTab('Root.Main', 'EmailSubject');
            $fields->removeFieldFromTab('Root.Main', 'CustomerMessage');
        }
        //adding
        if (!$this->exists() || !$this->isDefaultStatusOption()) {
            $fields->removeFieldFromTab('Root.Main', 'Code');
            $fields->addFieldToTab('Root.Main', new DropdownField('ClassName', _t('OrderStep.TYPE', 'Type'), self::get_not_created_codes_for_order_steps_to_include()), 'Name');
        }
        if ($this->isDefaultStatusOption()) {
            $fields->replaceField('Code', $fields->dataFieldByName('Code')->performReadonlyTransformation());
        }
        //headers
        $fields->addFieldToTab('Root.Main', new HeaderField('WARNING1', _t('OrderStep.CAREFUL', 'CAREFUL! please edit details below with care'), 2), 'Description');
        $fields->addFieldToTab('Root.Main', new HeaderField('WARNING2', _t('OrderStep.CUSTOMERCANCHANGE', 'What can be changed during this step?'), 3), 'CustomerCanEdit');
        $fields->addFieldToTab('Root.Main', new HeaderField('WARNING5', _t('OrderStep.ORDERGROUPS', 'Order groups for customer?'), 3), 'ShowAsUncompletedOrder');
        $fields->addFieldToTab('Root.Main', new HeaderField('HideStepFromCustomerHeader', _t('OrderStep.HIDE_STEP_FROM_CUSTOMER_HEADER', 'Customer Interaction'), 3), 'HideStepFromCustomer');
        $fields->addFieldToTab('Root.Main', new HeaderField('DeferHeader', _t('OrderStep.DEFER_HEADER', 'Delay'), 3), 'DeferTimeInSeconds');
        //final cleanup
        $fields->removeFieldFromTab('Root.Main', 'Sort');
        $fields->addFieldToTab('Root.Main', new TextareaField('Description', _t('OrderStep.DESCRIPTION', 'Explanation for internal use only')), 'WARNING1');

        return $fields;
    }

    /**
     * link to edit the record.
     *
     * @param string | Null $action - e.g. edit
     *
     * @return string

Should the return type not be null|string?

     */
    public function CMSEditLink($action = null)
    {
        return CMSEditLinkAPI::find_edit_link_for_object($this, $action);
    }

    /**
     * tells the order to display itself with an alternative display page.
     * in that way, orders can be displayed differently for certain steps
     * for example, in a print step, the order can be displayed in a
     * PRINT ONLY format.
     *
     * When the method return null, the order is displayed using the standard display page
     *
     * @see Order::DisplayPage
     *
     * @return null|object (Page)
     **/
    public function AlternativeDisplayPage()
    {
        return;
    }

    /**
     * Allows the opportunity for the Order Step to add any fields to Order::getCMSFields
     * Usually this is added before ActionNextStepManually.
     *
     * @param FieldList $fields
     * @param Order     $order
     *
     * @return FieldList
     **/
    public function addOrderStepFields(FieldList $fields, Order $order)
    {
        return $fields;
    }

    /**
     *@return ValidationResult
     **/
    public function validate()
    {
        $result = parent::validate();
        $anotherOrderStepWithSameNameOrCode = OrderStep::get()
            ->filter(
                array(
                    'Name' => $this->Name,

The property Name does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                    'Code' => strtoupper($this->Code),

The property Code does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                )
            )
            ->exclude(array('ID' => intval($this->ID)))
            ->First();
        if ($anotherOrderStepWithSameNameOrCode) {
            $result->error(_t('OrderStep.ORDERSTEPALREADYEXISTS', 'An order status with this name already exists. Please change the name and try again.'));
        }

        return $result;
    }

    /**************************************************
    * moving between statusses...
    **************************************************/
    /**
     *initStep:
     * makes sure the step is ready to run.... (e.g. check if the order is ready to be emailed as receipt).
     * should be able to run this function many times to check if the step is ready.
     *
     * @see Order::doNextStatus
     *
     * @param Order object
     *
     * @return bool - true if the current step is ready to be run...
     **/
    public function initStep(Order $order)
    {
        user_error('Please implement the initStep method in a subclass ('.get_class().') of OrderStep', E_USER_WARNING);

        return true;
    }

    /**
     *doStep:
     * should only be able to run this function once
     * (init stops you from running it twice - in theory....)
     * runs the actual step.
     *
     * @see Order::doNextStatus
     *
     * @param Order object
     *
     * @return bool - true if run correctly.
     **/
    public function doStep(Order $order)
    {
        user_error('Please implement the initStep method in a subclass ('.get_class().') of OrderStep', E_USER_WARNING);

        return true;
    }

    /**
     * nextStep:
     * returns the next step (after it checks if everything is in place for the next step to run...).
     *
     * @see Order::doNextStatus
     *
     * @param Order $order
     *
     * @return OrderStep | Null (next step OrderStep object)

Should the return type not be OrderStep|null?

     **/
    public function nextStep(Order $order)
    {
        $sort = (int) $this->Sort;

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

        if (! $sort) {
            $sort = 0;
        }
        $where = '"OrderStep"."Sort" >  '.$sort;
        $nextOrderStepObject = DataObject::get_one(
            'OrderStep',
            $where
        );
        if ($nextOrderStepObject) {
            return $nextOrderStepObject;
        }

        return;
    }

    /**************************************************
    * Boolean checks
    **************************************************/

    /**
     * Checks if a step has passed (been completed) in comparison to the current step.
     *
     * @param string $code:       the name of the step to check

There is no parameter named $code:. Was it maybe removed?

     * @param bool   $orIsEqualTo if set to true, this method will return TRUE if the step being checked is the current one
     *
     * @return bool
     **/
    public function hasPassed($code, $orIsEqualTo = false)
    {
        $otherStatus = DataObject::get_one(
            'OrderStep',
            array('Code' => $code)
        );
        if ($otherStatus) {
            if ($otherStatus->Sort < $this->Sort) {

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                return true;
            }
            if ($orIsEqualTo && $otherStatus->Code == $this->Code) {

The property Code does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                return true;
            }
        } else {
            user_error("could not find $code in OrderStep", E_USER_NOTICE);
        }

        return false;
    }

    /**
     * @param string $code
     *
     * @return bool
     **/
    public function hasPassedOrIsEqualTo($code)
    {
        return $this->hasPassed($code, true);
    }

    /**
     * @param string $code
     *
     * @return bool
     **/
    public function hasNotPassed($code)
    {
        return (bool) !$this->hasPassed($code, true);
    }

    /**
     * Opposite of hasPassed.
     *
     * @param string $code
     *
     * @return bool
     **/
    public function isBefore($code)
    {
        return (bool) $this->hasPassed($code, false) ? false : true;
    }

    /**
     *@return bool
     **/
    protected function isDefaultStatusOption()
    {
        return in_array($this->Code, self::get_codes_for_order_steps_to_include());

The property Code does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**************************************************
    * Email
    **************************************************/

    /**
     * @var string
     */
    protected $emailClassName = 'Order_InvoiceEmail';

    /**
     * returns the email class used for emailing the
     * customer during a specific step (IF ANY!).
     *
     * @return string
     */
    public function getEmailClassName()
    {
        return $this->emailClassName;
    }

    /**
     * return true if done already or mailed successfully now.
     *
     * @param order         $order
     * @param string        $subject
     * @param string        $message
     * @param bool          $resend
     * @param bool | string $adminOnlyOrToEmail you can set to false = send to customer, true: send to admin, or email = send to email
     * @param string        $emailClassName
     *
     * @return boolean;

The doc-type boolean; could not be parsed: Expected "|" or "end of type", but got ";" at position 7. (view supported doc-types)

     */
    protected function sendEmailForStep(
        $order,
        $subject,
        $message = '',
        $resend = false,
        $adminOnlyOrToEmail = false,
        $emailClassName = ''
    ) {
        if (!$this->hasBeenSent($order) || $resend) {
            if (!$subject) {
                $subject = $this->CalculatedEmailSubject($order);
            }
            $useAlternativeEmail = $adminOnlyOrToEmail && filter_var($adminOnlyOrToEmail, FILTER_VALIDATE_EMAIL);

            //this is NOT an admin EMAIL
            if ($this->hasCustomerMessage() || $useAlternativeEmail) {
                if (! $emailClassName) {
                    $emailClassName = $this->getEmailClassName();
                }
                return $order->sendEmail(
                    $emailClassName,
                    $subject,
                    $message,
                    $resend,
                    $adminOnlyOrToEmail
                );
            //ADMIN ONLY ....
            } else {
                if (! $emailClassName) {
                    $emailClassName = 'Order_ErrorEmail';
                }
                //looks like we are sending an error, but we are just using this for notification
                $message = _t('OrderStep.THISMESSAGENOTSENTTOCUSTOMER', 'NOTE: This message was not sent to the customer.').'<br /><br /><br /><br />'.$message;
                $outcome = $order->sendAdminNotification(
                    $emailClassName,
                    $subject,
                    $message,
                    $resend
                );
            }
            if ($outcome || Director::isDev()) {

This if statement, and the following return statement can be replaced with return $outcome || \Director::isDev();.

                return true;
            }

            return false;
        }

        return true;
    }

    /**
     * sets the email class used for emailing the
     * customer during a specific step (IF ANY!).
     *
     * @param string
     */
    public function setEmailClassName($s)
    {
        $this->emailClassName = $s;
    }

    /**
     * returns a link that can be used to test
     * the email being sent during this step
     * this method returns NULL if no email
     * is being sent OR if there is no suitable Order
     * to test with...
     *
     * @return string

Should the return type not be string|null?

     */
    protected function testEmailLink()
    {
        if ($this->getEmailClassName()) {
            $order = DataObject::get_one(
                'Order',
                array('StatusID' => $this->ID),
                $cacheDataObjectGetOne = true,
                'RAND() ASC'
            );
            if (! $order) {
                $order = Order::get()
                    ->where('"OrderStep"."Sort" >= '.$this->Sort)

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                    ->sort('IF("OrderStep"."Sort" > '.$this->Sort.', 0, 1) ASC, "OrderStep"."Sort" ASC, RAND() ASC')

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                    ->innerJoin('OrderStep', '"OrderStep"."ID" = "Order"."StatusID"')
                    ->first();
            }
            if ($order) {
                return OrderConfirmationPage::get_email_link(
                    $order->ID,
                    $this->getEmailClassName(),
                    $actuallySendEmail = false,
                    $alternativeOrderStepID = $this->ID
                );
            }
        }
    }

    /**
     * Has an email been sent to the customer for this
     * order step.
     *"-10 days".
     *
     * @param Order $order
     * @param bool  $checkDateOfOrder
     *
     * @return bool
     **/
    public function hasBeenSent(Order $order, $checkDateOfOrder = true)
    {
        //if it has been more than a XXX days since the order was last edited (submitted) then we do not send emails as
        //this would be embarrasing.
        if ($checkDateOfOrder) {
            if ($log = $order->SubmissionLog()) {
                $lastEditedValue = $log->LastEdited;
            } else {
                $lastEditedValue = $order->LastEdited;
            }
            if ((strtotime($lastEditedValue) < strtotime('-'.EcommerceConfig::get('OrderStep', 'number_of_days_to_send_update_email').' days'))) {
                return true;
            }
        }
        $count = OrderEmailRecord::get()
            ->Filter(array(
                'OrderID' => $order->ID,
                'OrderStepID' => $this->ID,
                'Result' => 1,
            ))
            ->count();

        return $count ? true : false;
    }

    /**
     * For some ordersteps this returns true...
     *
     * @return bool
     **/
    protected function hasCustomerMessage()
    {
        return false;
    }


    /**
     * Formatted answer for "hasCustomerMessage".
     *
     * @return string
     */
    public function HasCustomerMessageNice()
    {
        return $this->getHasCustomerMessageNice();
    }
    public function getHasCustomerMessageNice()
    {
        return $this->hasCustomerMessage() ?  _t('OrderStep.YES', 'Yes') :  _t('OrderStep.NO', 'No');
    }

    public function CalculatedEmailSubject($order = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->EmailSubject;

The property EmailSubject does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    public function CalculatedCustomerMessage($order = null)

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->CustomerMessage;

The property CustomerMessage does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Formatted answer for "hasCustomerMessage".
     *
     * @return string

Should the return type not be DBField?

     */
    public function ShowAsSummary()
    {
        return $this->getShowAsSummary();
    }

    /**
     *
     *
     * @return string

Should the return type not be DBField?

     */
    public function getShowAsSummary()
    {
        $v = '<strong>';
        if ($this->ShowAsUncompletedOrder) {

The property ShowAsUncompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $v .= _t('OrderStep.UNCOMPLETED', 'Uncompleted');
        } elseif ($this->ShowAsInProcessOrder) {

The property ShowAsInProcessOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $v .= _t('OrderStep.INPROCESS', 'In process');
        } elseif ($this->ShowAsCompletedOrder) {

The property ShowAsCompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $v .= _t('OrderStep.COMPLETED', 'Completed');
        }
        $v .= '</strong>';
        $canArray = array();
        if ($this->CustomerCanEdit) {

The property CustomerCanEdit does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $canArray[] = _t('OrderStep.EDITABLE', 'edit');
        }
        if ($this->CustomerCanPay) {

The property CustomerCanPay does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $canArray[] = _t('OrderStep.PAY', 'pay');
        }
        if ($this->CustomerCanCancel) {

The property CustomerCanCancel does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $canArray[] = _t('OrderStep.CANCEL', 'cancel');
        }
        if (count($canArray)) {
            $v .=  '<br />'._t('OrderStep.CUSTOMER_CAN', 'Customer Can').': '.implode(', ', $canArray).'';
        }
        if ($this->hasCustomerMessage()) {
            $v .= '<br />'._t('OrderStep.CUSTOMER_MESSAGES', 'Includes message to customer');
        }
        if ($this->DeferTimeInSeconds) {

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $v .= '<br />'.$this->humanReadeableDeferTimeInSeconds();
        }

        return DBField::create_field('HTMLText', $v);
    }

    /**
     * @return string

Should the return type not be string|null?

     */
    protected function humanReadeableDeferTimeInSeconds()
    {
        if ($this->canBeDefered()) {
            $field = DBField::create_field('SS_DateTime', strtotime('+ '.$this->DeferTimeInSeconds.' seconds'));

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $descr0 = _t('OrderStep.THE', 'The').' '.'<span style="color: #338DC1">'.$this->getTitle().'</span>';
            $descr1 = _t('OrderStep.DELAY_VALUE', 'Order Step, for any order, will run');
            $descr2 = $field->ago();
            $descr3 = $this->DeferFromSubmitTime ?

The property DeferFromSubmitTime does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                    _t('OrderStep.FROM_ORDER_SUBMIT_TIME', 'from the order being submitted') :
                    _t('OrderStep.FROM_START_OF_ORDSTEP', 'from the order arriving on this step');
            return $descr0. ' ' . $descr1.' <span style="color: #338DC1">'.$descr2.'</span> '.$descr3.'.';
        }
        // $dtF = new \DateTime('@0');
        // $dtT = new \DateTime("@".$this->DeferTimeInSeconds);
        //
        // return $dtF->diff($dtT)->format('%a days, %h hours, %i minutes and %s seconds');
    }

    /**
     * Formatted answer for "hasCustomerMessage".
     *
     * @return string

Should the return type not be DBField?

     */
    public function NameAndDescription()
    {
        return $this->getNameAndDescription();
    }

    public function getNameAndDescription()
    {
        $v = '<strong>'.$this->Name.'</strong><br /><em>'.$this->Description.'</em>';

The property Name does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

The property Description does not seem to exist. Did you mean description?

        return DBField::create_field('HTMLText', $v);
    }

    /**
     * This allows you to set the time to something other than the standard DeferTimeInSeconds
     * value based on the order provided.
     *
     * @param Order (optional)

Should the type for parameter $order not be optional|null?

     *
     * @return int
     */
    public function CalculatedDeferTimeInSeconds($order = null)

The parameter $order is not used and could be removed.

    {
        return $this->DeferTimeInSeconds;

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * can this order step be delayed?
     * in general, if there is a customer message
     * we should be able to delay it
     *
     * This method can be overridden in any orderstep
     * @return bool
     **/
    protected function canBeDefered()
    {
        return $this->hasCustomerMessage();
    }


    /**************************************************
    * Order Status Logs
    **************************************************/

    /**
     * The OrderStatusLog that is relevant to the particular step.
     *
     * @var string
     */
    protected $relevantLogEntryClassName = '';

    /**
     * @return string
     */
    public function getRelevantLogEntryClassName()
    {
        return $this->relevantLogEntryClassName;
    }

    /**
     * @param string
     */
    public function setRelevantLogEntryClassName($s)
    {
        $this->relevantLogEntryClassName = $s;
    }

    /**
     * returns the OrderStatusLog that is relevant to this step.
     *
     * @param Order $order
     *
     * @return OrderStatusLog | null
     */
    public function RelevantLogEntry(Order $order)
    {
        if ($className = $this->getRelevantLogEntryClassName()) {

$className is not used, you could remove the assignment.

            return $this->RelevantLogEntries($order)->Last();
        }
    }

    /**
     * returns the OrderStatusLogs that are relevant to this step.
     * It is important that getRelevantLogEntryClassName returns
     * a specific enough ClassName and not a base class name.
     *
     * @param Order $order
     *
     * @return DataObjectSet | null
     */
    public function RelevantLogEntries(Order $order)
    {
        if ($className = $this->getRelevantLogEntryClassName()) {
            return $className::get()->filter(
                array(
                    'OrderID' => $order->ID
                )
            );
        }
    }

    /**************************************************
    * Silverstripe Standard Data Object Methods
    **************************************************/

    /**
     * Standard SS method
     * These are only created programmatically.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * Standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool

Should the return type not be boolean|string|null?

     */
    public function canView($member = null)
    {
        if (! $member) {
            $member = Member::currentUser();
        }
        $extended = $this->extendedCan(__FUNCTION__, $member);

$member is of type object<DataObject>|null, but the function expects a object<Member>|integer.

        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get('EcommerceRole', 'admin_permission_code'))) {
            return true;
        }

        return parent::canEdit($member);

It seems like $member defined by \Member::currentUser() on line 1184 can also be of type object<DataObject>; however, DataObject::canEdit() does only seem to accept object<Member>|null, maybe add an additional type check?

It seems like you call parent on a different method (canEdit() instead of canView()). Are you sure this is correct? If so, you might want to change this to $this->canEdit().

    }

    /**
     * the default for this is TRUE, but for completed order steps
     *
     * we do not allow this.
     *
     * @param  Order $order
     * @param  Member $member optional

Should the type for parameter $member not be Member|null?

     * @return bool
     */
    public function canOverrideCanViewForOrder($order, $member = null)

The parameter $order is not used and could be removed.

The parameter $member is not used and could be removed.

    {
        //return true if the order can have customer input
        // orders recently saved can also be views
        return
            $this->CustomerCanEdit ||

The property CustomerCanEdit does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->CustomerCanCancel ||

The property CustomerCanCancel does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->CustomerCanPay;

The property CustomerCanPay does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * standard SS method.
     *
     * @param Member | NULL
     *
     * @return bool

Should the return type not be boolean|string|null?

     */
    public function canEdit($member = null)
    {
        if (! $member) {
            $member = Member::currentUser();
        }
        $extended = $this->extendedCan(__FUNCTION__, $member);
        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get('EcommerceRole', 'admin_permission_code'))) {
            return true;
        }

        return parent::canEdit($member);
    }

    /**
     * Standard SS method.
     *
     * @param Member $member

Should the type for parameter $member not be Member|null?

     *
     * @return bool

Should the return type not be boolean|string|null?

     */
    public function canDelete($member = null)
    {
        //cant delete last status if there are orders with this status
        $nextOrderStepObject = $this->NextOrderStep();
        if ($nextOrderStepObject) {
            //do nothing
        } else {
            $orderCount = Order::get()
                ->filter(array('StatusID' => intval($this->ID) - 0))
                ->count();
            if ($orderCount) {
                return false;
            }
        }
        if ($this->isDefaultStatusOption()) {
            return false;
        }
        if (! $member) {
            $member = Member::currentUser();
        }
        $extended = $this->extendedCan(__FUNCTION__, $member);

$member is of type object<DataObject>|null, but the function expects a object<Member>|integer.

        if ($extended !== null) {
            return $extended;
        }
        if (Permission::checkMember($member, Config::inst()->get('EcommerceRole', 'admin_permission_code'))) {
            return true;
        }

        return parent::canEdit($member);

It seems like $member defined by \Member::currentUser() on line 1264 can also be of type object<DataObject>; however, DataObject::canEdit() does only seem to accept object<Member>|null, maybe add an additional type check?

It seems like you call parent on a different method (canEdit() instead of canDelete()). Are you sure this is correct? If so, you might want to change this to $this->canEdit().

    }

    /**
     * standard SS method.
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        //make sure only one of three conditions applies ...
        if ($this->ShowAsUncompletedOrder) {

The property ShowAsUncompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->ShowAsInProcessOrder = false;

The property ShowAsInProcessOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

            $this->ShowAsCompletedOrder = false;

The property ShowAsCompletedOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

        } elseif ($this->ShowAsInProcessOrder) {

The property ShowAsInProcessOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->ShowAsUncompletedOrder = false;

The property ShowAsUncompletedOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

            $this->ShowAsCompletedOrder = false;

The property ShowAsCompletedOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

        } elseif ($this->ShowAsCompletedOrder) {

The property ShowAsCompletedOrder does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            $this->ShowAsUncompletedOrder = false;

The property ShowAsUncompletedOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

            $this->ShowAsInProcessOrder = false;

The property ShowAsInProcessOrder does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

        }
        if (! $this->canBeDefered()) {
            $this->DeferTimeInSeconds = 0;

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

            $this->DeferFromSubmitTime = 0;

The property DeferFromSubmitTime does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

        } else {
            if (is_numeric($this->DeferTimeInSeconds)) {

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                $this->DeferTimeInSeconds = intval($this->DeferTimeInSeconds);

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            } else {
                $this->DeferTimeInSeconds = strtotime('+'.$this->DeferTimeInSeconds);

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                if ($this->DeferTimeInSeconds > 0) {

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                    $this->DeferTimeInSeconds = $this->DeferTimeInSeconds - time();

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

The property DeferTimeInSeconds does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

                }
            }
        }
        $this->Code = strtoupper($this->Code);

The property Code does not exist on object<OrderStep>. Since you implemented __set, maybe consider adding a @property annotation.

The property Code does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * move linked orders to the next status
     * standard SS method.
     */
    public function onBeforeDelete()
    {
        $ordersWithThisStatus = Order::get()->filter(array('StatusID' => $this->ID));
        if ($ordersWithThisStatus->count()) {
            $previousOrderStepObject = null;

$previousOrderStepObject is not used, you could remove the assignment.

            $bestOrderStep = $this->NextOrderStep();
            //backup
            if ($bestOrderStep && $bestOrderStep->exists()) {
                //do nothing
            } else {
                $bestOrderStep = $this->PreviousOrderStep();
            }
            if ($bestOrderStep) {
                foreach ($ordersWithThisStatus as $orderWithThisStatus) {
                    $orderWithThisStatus->StatusID = $bestOrderStep->ID;
                    $orderWithThisStatus->write();
                }
            }
        }
        parent::onBeforeDelete();
    }

    /**
     * standard SS method.
     */
    public function onAfterDelete()
    {
        parent::onAfterDelete();
        $this->checkValidityOfOrderSteps();
    }

    protected function NextOrderStep()
    {
        return OrderStep::get()
            ->filter(array('Sort:GreaterThan' => $this->Sort))

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            ->First();
    }

    protected function PreviousOrderStep()
    {
        return OrderStep::get()
            ->filter(array('Sort:LessThan' => $this->Sort))

The property Sort does not exist on object<OrderStep>. Since you implemented __get, maybe consider adding a @property annotation.

            ->First();
    }

    /**
     * standard SS method
     * USED TO BE: Unpaid,Query,Paid,Processing,Sent,Complete,AdminCancelled,MemberCancelled,Cart.
     */
    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $this->checkValidityOfOrderSteps();
    }

    protected function checkValidityOfOrderSteps()
    {
        $orderStepsToInclude = EcommerceConfig::get('OrderStep', 'order_steps_to_include');
        $codesToInclude = self::get_codes_for_order_steps_to_include();
        $indexNumber = 0;
        if ($orderStepsToInclude && count($orderStepsToInclude)) {
            if ($codesToInclude && count($codesToInclude)) {

The expression $codesToInclude of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                foreach ($codesToInclude as $className => $code) {
                    $code = strtoupper($code);
                    $filter = array('ClassName' => $className);
                    $indexNumber += 10;
                    $itemCount = OrderStep::get()->filter($filter)->Count();
                    if ($itemCount > 0) {
                        //always reset code
                        $obj = DataObject::get_one(
                            'OrderStep',
                            $filter,
                            $cacheDataObjectGetOne = false
                        );
                        if ($obj->Code != $code) {
                            $obj->Code = $code;
                            $obj->write();
                        }
                        //replace default description
                        $parentObj = singleton('OrderStep');
                        if ($obj->Description == $parentObj->myDescription()) {
                            $obj->Description = $obj->myDescription();
                            $obj->write();
                        }
                        //check sorting order
                        if ($obj->Sort != $indexNumber) {
                            $obj->Sort = $indexNumber;
                            $obj->write();
                        }
                    } else {
                        $oldObjects = OrderStep::get()->filterAny(array('Code' => $code));
                        foreach ($oldObjects as $oldObject) {
                            DB::alteration_message('DELETING '.$oldObject->Title.' as this now appears obsolete', 'deleted');
                            $oldObject->delete();
                        }
                        $obj = $className::create($filter);
                        $obj->Code = $code;
                        $obj->Description = $obj->myDescription();
                        $obj->Sort = $indexNumber;
                        $obj->write();
                        DB::alteration_message("Created \"$code\" as $className.", 'created');
                    }
                    $obj = DataObject::get_one(
                        'OrderStep',
                        $filter,
                        $cacheDataObjectGetOne = false
                    );
                    if (! $obj) {
                        user_error("There was an error in creating the $code OrderStep");
                    }
                }
            }
        }
        $steps = OrderStep::get();
        foreach ($steps as $step) {
            if (!$step->Description) {
                $step->Description = $step->myDescription();
                $step->write();
            }
        }
    }

    /**
     * returns the standard EcommerceDBConfig for use within OrderSteps.
     *
     * @return EcommerceDBConfig
     */
    protected function EcomConfig()
    {
        return EcommerceDBConfig::current_ecommerce_db_config();
    }

    /**
     * Explains the current order step.
     *
     * @return string
     */
    protected function myDescription()
    {
        return _t('OrderStep.DESCRIPTION', 'No description has been provided for this step.');
    }
}