OptionalTreeDropdownField

Complexity

Total Complexity

5

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	preTree()	0	4	1
A	getField()	0	4	1
A	gettree()	0	6	1
A	tree()	0	8	2

<?php

/**
 * TreeDropdown-like field that gives you a tree of items including an empty field, using ajax.
 * Author: Marijn Kampf www.exadium.com
 * Date:						24 Nov 2009
 * Version:				2.2
 * Revision date:	9 May 2011
 * Changes:				Fixed ajax sub tree request
 * Revision date:	8 October 2010
 * Changes:				Changed $this->postTree to OptionalTreeDropdownField::$postTree to avoid Undefined error
 * Revision date:	17 June 2010
 * Changes:				Updated to work with SilverStripe 2.4, tree function added.
 */
class OptionalTreeDropdownField extends TreeDropdownField
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        'tree',
    );

    /**
     * Define once rather than defining same line twice.
     */
    private static $postTree = '</ul>';

    /**
     * Helper function to return the header (rather than defining same line twice).
     */
    public function preTree()
    {
        return '<ul class="tree"><li id="" class="l"><a>'._t('OptionalTreeDropdownField.NONE', '(None)').'</a>';
    }

    public function getField($field)

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->$field;
    }

    /**
     * Return the site tree
     * For version 2.3 and earlier.
     */
    public function gettree()
    {
        echo $this->preTree();
        parent::gettree();

It seems like you code against a specific sub-type and not the parent class TreeDropdownField as the method gettree() does only exist in the following sub-classes of TreeDropdownField: OptionalTreeDropdownField. Maybe you want to instanceof check for one of these explicitly?

        echo self::$postTree;
    }

    /**
     * Get the whole tree of a part of the tree via an AJAX request with empty / none item prepended.
     *
     * @param SS_HTTPRequest $request
     *
     * @return string
     *                for version 2.4 and later
     */
    public function tree(SS_HTTPRequest $request)
    {
        if ($ID = (int) $request->latestparam('ID')) {

$ID is not used, you could remove the assignment.

            return parent::tree($request);
        } else {
            return $this->preTree().parent::tree($request).self::$postTree;
        }
    }
}