CheckoutPageExtensionController::onAfterInit() - Code Metrics - Inspection of "WIP" - sunnysideup/silverstripe-ecommerce-google-analytics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5c035c...305609 )

by Nicolaas

created 2023-01-16 06:33 UTC

CheckoutPageExtensionController::onAfterInit() C

↳ Parent: CheckoutPageExtensionController

Complexity

Conditions	12
Paths	10

Size

Total Lines	59
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
eloc	39
c	4
b	0
f	0
dl	0
loc	59
rs	6.9666
cc	12
nc	10
nop	0

How to fix Long Method Complexity

<?php

namespace Sunnysideup\EcommerceGoogleAnalytics;

use SilverStripe\Control\Director;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Extension;
use SilverStripe\View\Requirements;
use Sunnysideup\Ecommerce\Config\EcommerceConfig;
use Sunnysideup\Ecommerce\Model\Money\EcommerceCurrency;
use Sunnysideup\Ecommerce\Pages\Product;

class CheckoutPageExtensionController extends Extension
{
    /**
     * Standard SS method.
     * Runs after the Page::init method is called.
     */
    public function onAfterInit()
    {
        $owner = $this->owner;
        if ($owner->EnableGoogleAnalytics && $owner->currentOrder && (Director::isLive() || isset($_GET['testanalytics']))) {
            $var = EcommerceConfig::get(CheckoutPageDataExtension::class, 'google_analytics_variable');
            if ($var) {
                $currencyUsedObject = $owner->currentOrder->CurrencyUsed();
                if ($currencyUsedObject) {
                    $currencyUsedString = $currencyUsedObject->Code;
                }
                if (empty($currencyUsedString)) {
                    $currencyUsedString = EcommerceCurrency::default_currency_code();
                }
                $orderItems = $owner->currentOrder->OrderItems();
                $items = '';
                if (Config::inst()->get(CheckoutPageExtensionController::class, 'include_product_items')) {
                    foreach ($orderItems as $orderItem) {
                        $product = Product::get_by_id($orderItem->BuyableID);
                        $sku = $product->InternalItemID ?: $product->ID;
                        $topParent = $product->TopParentGroup();
                        $catetory = 'Unknown';

                        if($topParent) {

                        }
                        $orderItemName = preg_replace("#\r|\n#", '', (string) $orderItem->TableTitle());
                        $category = preg_replace("#\r|\n#", '', (string) $category);

                        $items .=
                            'ga(
                                \'ecommerce:addItem\',
                                {
                                    \'id\': \'' . $owner->currentOrder->ID . '\',
                                    \'name\': \'' . $orderItemName . '\',
                                    \'sku\': \'' . $sku . '\',
                                    \'category\': \'' . $category . '\',
                                    \'price\': \'' . $orderItem->CalculatedTotal . '\',
                                    \'quantity\': \'' . $orderItem->Quantity . '\',
                                }
                            );';
                    }
                }
                $js = '
                jQuery("#OrderForm_OrderForm").on(
                    "submit",
                    function(e){
                        console.log(e);
                        ' . $var . '(\'require\', \'ecommerce\');
                        ' . $var . '(
                            \'ecommerce:addTransaction\',
                            {
                                \'id\': \'' . $owner->currentOrder->ID . '\',
                                \'revenue\': \'' . $owner->currentOrder->getSubTotal() . '\',
                                \'currency\': \'' . $currencyUsedString . '\'
                            }
                        );
                        ' . $items . '
                        ' . $var . '(\'ecommerce:send\');
                    }
                );';
                Requirements::customScript($js, 'GoogleAnalyticsEcommerce');
            }
        }
    }
}


1			<?php
2
3			namespace Sunnysideup\EcommerceGoogleAnalytics;
4
5			use SilverStripe\Control\Director;
6			use SilverStripe\Core\Config\Config;
7			use SilverStripe\Core\Extension;
8			use SilverStripe\View\Requirements;
9			use Sunnysideup\Ecommerce\Config\EcommerceConfig;
10			use Sunnysideup\Ecommerce\Model\Money\EcommerceCurrency;
11			use Sunnysideup\Ecommerce\Pages\Product;
12
13			class CheckoutPageExtensionController extends Extension
14			{
15			/**
16			* Standard SS method.
17			* Runs after the Page::init method is called.
18			*/
19			public function onAfterInit()
20			{
21			$owner = $this->owner;
22			if ($owner->EnableGoogleAnalytics && $owner->currentOrder && (Director::isLive() \|\| isset($_GET['testanalytics']))) {
23			$var = EcommerceConfig::get(CheckoutPageDataExtension::class, 'google_analytics_variable');
24			if ($var) {
25			$currencyUsedObject = $owner->currentOrder->CurrencyUsed();
26			if ($currencyUsedObject) {
27			$currencyUsedString = $currencyUsedObject->Code;
28			}
29			if (empty($currencyUsedString)) {
30			$currencyUsedString = EcommerceCurrency::default_currency_code();
31			}
32			$orderItems = $owner->currentOrder->OrderItems();
33			$items = '';
34			if (Config::inst()->get(CheckoutPageExtensionController::class, 'include_product_items')) {
35			foreach ($orderItems as $orderItem) {
36			$product = Product::get_by_id($orderItem->BuyableID);
37			$sku = $product->InternalItemID ?: $product->ID;
38			$topParent = $product->TopParentGroup();
39			$catetory = 'Unknown';
			0 ignored issues – show Unused Code introduced 2023-01-16 06:36 UTC by Report Bug Copy Issue Report The assignment to `$catetory` is dead and can be removed. Loading history...
40			if($topParent) {
41
42			}
43			$orderItemName = preg_replace("#\r\|\n#", '', (string) $orderItem->TableTitle());
44			$category = preg_replace("#\r\|\n#", '', (string) $category);
			0 ignored issues – show Comprehensibility Best Practice introduced 2023-01-16 06:36 UTC by Report Bug Copy Issue Report The variable `$category` seems to be defined later in this `foreach` loop on line `44`. Are you sure it is defined here? Loading history...
45			$items .=
46			'ga(
47			\'ecommerce:addItem\',
48			{
49			\'id\': \'' . $owner->currentOrder->ID . '\',
50			\'name\': \'' . $orderItemName . '\',
51			\'sku\': \'' . $sku . '\',
52			\'category\': \'' . $category . '\',
53			\'price\': \'' . $orderItem->CalculatedTotal . '\',
54			\'quantity\': \'' . $orderItem->Quantity . '\',
55			}
56			);';
57			}
58			}
59			$js = '
60			jQuery("#OrderForm_OrderForm").on(
61			"submit",
62			function(e){
63			console.log(e);
64			' . $var . '(\'require\', \'ecommerce\');
65			' . $var . '(
66			\'ecommerce:addTransaction\',
67			{
68			\'id\': \'' . $owner->currentOrder->ID . '\',
69			\'revenue\': \'' . $owner->currentOrder->getSubTotal() . '\',
70			\'currency\': \'' . $currencyUsedString . '\'
71			}
72			);
73			' . $items . '
74			' . $var . '(\'ecommerce:send\');
75			}
76			);';
77			Requirements::customScript($js, 'GoogleAnalyticsEcommerce');
78			}
79			}
80			}
81			}
82

sunnysideup / silverstripe-ecommerce-google-analytics

Push — master ( 5c035c...305609 )

CheckoutPageExtensionController::onAfterInit() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like