EmailDownloadPage_Registration - Code Metrics - sunnysideup/silverstripe-downloadtoemail - Measure and Improve Code Quality continuously with Scrutinizer

EmailDownloadPage_Registration A
last analyzed 2018-03-20 01:01 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	1
dl	0
loc	96
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	canCreate()	4	1
A	canDelete()	4	1
A	canEdit()	4	1
A	getTitle()	4	1
A	getUsedNice()	4	1
A	onBeforeWrite()	7	2

<?php


/**
 * record of all the
 *
 */
class EmailDownloadPage_Registration extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Email" => "Varchar",
        "Code" => "Varchar",
        "Used" => "Boolean",
        "DownloadTimes" => "Int"
    );

    private static $has_one = array(

        "DownloadFile" => "File",
        "EmailDownloadPage" => "EmailDownloadPage"
    );

    private static $casting = array(

        "Title" => "Varchar",
        "UsedNice" => "Varchar"
    );

    private static $summary_fields = array(

        "Created" => "Sent",
        "Email" => "Email",
        "UsedNice" => "Download Link Has Been Used",
        "DownloadTimes" => "Times Downloaded"
    );

    private static $searchable_fields = array(

        "Email",
        "UsedNice"
    );

    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canCreate($member = null)
    {
        return false;
    }

    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canDelete($member = null)
    {
        return false;
    }

    /**
     * standard SS method
     * @param Member $member

     * @return Boolean
     */
    public function canEdit($member = null)
    {
        return false;
    }

    /**
     * casted variable
     * @return String
     */
    public function getTitle()
    {
        return "Download for ".$this->Email;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * casted variable
     * @return String
     */
    public function getUsedNice()
    {
        return $this->dbObject('Used')->Nice();
    }

    /**
     * default sort
     * @var String
     */
    private static $default_sort = "\"Created\" DESC";


    /**
     * Automatically set Code
     */
    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if (!$this->Code) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Code = md5(rand(0, 10000));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
}


1			<?php
2
3
4			/**
5			* record of all the
6			*
7			*/
8			class EmailDownloadPage_Registration extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9			{
10			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11			"Email" => "Varchar",
12			"Code" => "Varchar",
13			"Used" => "Boolean",
14			"DownloadTimes" => "Int"
15			);
16
17			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18			"DownloadFile" => "File",
19			"EmailDownloadPage" => "EmailDownloadPage"
20			);
21
22			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23			"Title" => "Varchar",
24			"UsedNice" => "Varchar"
25			);
26
27			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28			"Created" => "Sent",
29			"Email" => "Email",
30			"UsedNice" => "Download Link Has Been Used",
31			"DownloadTimes" => "Times Downloaded"
32			);
33
34			private static $searchable_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
35			"Email",
36			"UsedNice"
37			);
38
39			/**
40			* standard SS method
41			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
42			* @return Boolean
43			*/
44			public function canCreate($member = null)
45			{
46			return false;
47			}
48
49			/**
50			* standard SS method
51			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
52			* @return Boolean
53			*/
54			public function canDelete($member = null)
55			{
56			return false;
57			}
58
59			/**
60			* standard SS method
61			* @param Member $member
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Should the type for parameter `$member` not be `Member\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
62			* @return Boolean
63			*/
64			public function canEdit($member = null)
65			{
66			return false;
67			}
68
69			/**
70			* casted variable
71			* @return String
72			*/
73			public function getTitle()
74			{
75			return "Download for ".$this->Email;
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `Email` does not exist on `object<EmailDownloadPage_Registration>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76			}
77
78			/**
79			* casted variable
80			* @return String
81			*/
82			public function getUsedNice()
83			{
84			return $this->dbObject('Used')->Nice();
85			}
86
87			/**
88			* default sort
89			* @var String
90			*/
91			private static $default_sort = "\"Created\" DESC";
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
92
93			/**
94			* Automatically set Code
95			*/
96			public function onBeforeWrite()
97			{
98			parent::onBeforeWrite();
99			if (!$this->Code) {
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<EmailDownloadPage_Registration>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
100			$this->Code = md5(rand(0, 10000));
			0 ignored issues – show Documentation introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<EmailDownloadPage_Registration>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
101			}
102			}
103			}
104

sunnysideup / silverstripe-downloadtoemail

EmailDownloadPage_Registration A last analyzed 2018-03-20 01:01 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like

EmailDownloadPage_Registration A
last analyzed 2018-03-20 01:01 UTC