DataObjectSortBaseClass

Complexity

Total Complexity

21

Size/Duplication

Total Lines	150
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	7

Importance

Changes

0

<?php
class DataObjectSortBaseClass extends Controller implements PermissionProvider

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(
        "show" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION'
    );

    /**
     * Permission for user management.
     *
     * @var string
     */
    const CAN_DO_STUFF = 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION';

    public function providePermissions()
    {
        return array(
            DataObjectSortBaseClass::CAN_DO_STUFF => array(
                'name' => _t(
                    'DataObjectSortBaseClass.PERMISSION_MANAGE_USERS_DESCRIPTION',
                    'Quick updates and edits'
                ),
                'help' => _t(
                    'DataObjectSortBaseClass.PERMISSION_MANAGE_USERS_HELP',
                    'Allows for certain data to be sorted, edited, etc... This is around quick edits'
                ),
                'category' => _t('DataObjectSortBaseClass.PERMISSIONS_CATEGORY', 'Miscellaneous'),
                'sort' => 100
            )
        );
    }


    public function init()
    {
        // Only administrators can run this method
        parent::init();
        if (! Permission::check("DATA_OBJECT_SORT_AND_EDIT_PERMISSION")) {
            return $this->permissionFailureStandard();
        }
    }

    public function show()
    {
        return array();
    }


    /**
     *
     * @return string
     */
    protected function SecureFieldToBeUpdated()
    {
        if (isset($_POST["Field"])) {
            return addslashes($_POST["Field"]);
        }
        $field = $this->getRequest()->param("OtherID");
        if ($table = $this->SecureTableToBeUpdated()) {
            if ($tableObject = DataObject::get_one($table) {

Avoid IF statements that are always true or false

                if ($tableObject->hasDatabaseField($field)) {

This code did not parse for me. Apparently, there is an error somewhere around this line:

Syntax error, unexpected T_IF

                    return $field;
                } else {
                    user_error("$field does not exist on $table", E_USER_ERROR);
                }
            } else {
                user_error("there are no records in $table", E_USER_ERROR);
            }
        } else {
            user_error("there is no table specified", E_USER_ERROR);
        }
    }

    /**
     *
     * @return string
     */
    protected function SecureTableToBeUpdated()
    {
        if (isset($_POST["Table"])) {
            $table = addslashes($_POST["Table"]);
        } else {
            $table = $this->getRequest()->param("ID");
        }
        if (class_exists($table)) {
            return $table;
        } else {
            user_error("could not find record: $table", E_USER_ERROR);
        }
    }


    /**
     *
     * @return int
     */
    protected function SecureRecordToBeUpdated()
    {
        if (isset($_POST["Record"])) {
            return intval($_POST["Record"]);
        }
        if (isset($_GET["id"])) {
            $record = $_GET["id"];
            return intval($record);
        }
        return 0;
    }


    /**
     *
     *
     * @param  DataObject $obj       [description]
     * @param  string $fieldName     [description]
     * @return FormField
     */
    protected function getFormField($obj, $fieldName)
    {
        if (!self::$field) {
            self::$field  = $obj->dbObject($fieldName)->scaffoldFormField($obj->Title);
        }
        return self::$field;
    }

    /**
     *
     * @return string
     */
    protected function HumanReadableTableName()
    {
        return singleton($this->SecureTableToBeUpdated())->plural_name();
    }

    /**
     *
     * @return string
     */
    public function Link($action = null)
    {
        $link = Config::inst()->get($this->class, 'url_segment').'/';
        if ($action) {
            $link .= "$action/";
        }
        return $link;
    }

    public function permissionFailureStandard()
    {
        return Security::permissionFailure($this, _t('Security.PERMFAILURE', ' This page is secured and you need administrator rights to access it. Enter your credentials below and we will send you right along.'));
    }
}