DataObjectOneRecordUpdateController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	108
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	popup_link_only()	0	5	1
A	popup_link()	8	8	2
A	init()	16	16	2
A	onerecordform()	0	33	5
A	save()	0	15	2
A	show()	0	11	2

<?php
/**
 *@author nicolaas [at] sunnysideup.co.nz
 *@package: dataobjectsorter
 *@description: allows you to edit one record
 *
 **/

class DataObjectOneRecordUpdateController extends DataObjectSortBaseClass
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        "onerecordform" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION',
        "show" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION',
        "save" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION'
    );

    /**
     *
     * make sure to also change in routes if you change this link
     * @var string
     */
    private static $url_segment = 'dataobjectonerecordupdate';

Consider using a different property name as you override a private property of the parent class.

    public static function popup_link_only($className, $recordID)

The return type could not be reliably inferred; please add a @return annotation.

    {
        DataObjectSorterRequirements::popup_link_requirements();
        return Injector::inst()->get('DataObjectOneRecordUpdateController')->Link('show/'.$className."/".$recordID);
    }
    public static function popup_link($className, $recordID, $linkText = 'click here to edit')

This method seems to be duplicated in your project.

    {
        $link = DataObjectOneRecordUpdateController::popup_link_only($className, $recordID);
        if ($link) {
            return '
                <a href="'.$link.'" class="modalPopUp modal-popup" data-width="800" data-height="600" data-rel="window.open(\''.$link.'\', \'sortlistFor'.$className.$recordID.'\',\'toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=600,height=600,left = 440,top = 200\'); return false;">'.$linkText.'</a>';
        }
    }

    public function init()

This method seems to be duplicated in your project.

    {
        //must set this first.
        Config::inst()->update('SSViewer', 'theme_enabled', Config::inst()->get('DataObjectSorterRequirements', 'run_through_theme'));
        parent::init();
        if (! Director::is_ajax()) {
            DataObjectSorterRequirements::popup_requirements('onerecord');
            $url = Director::absoluteURL(
                 Injector::inst()->get('DataObjectOneRecordUpdateController')->Link('onerecordform')
            );
            Requirements::customScript(
                "var DataObjectOneRecordUpdateURL = '".$url."'",
                'DataObjectOneRecordUpdateURL'
            );
        }
    }

    public function onerecordform()
    {
        Versioned::set_reading_mode('Stage.Stage');
        $table = $this->SecureTableToBeUpdated();
        $record = $this->SecureRecordToBeUpdated();
        $obj = $table::get()->byID($record);
        if (!$obj) {
            user_error("record could not be found!", E_USER_ERROR);
        }
        if (! $obj->canEdit()) {
            $this->permissionFailureStandard();
        }
        $formFields = $this->getFormFields($obj);

The method getFormFields does not exist on object<DataObjectOneRecordUpdateController>? Since you implemented __call, maybe consider adding a @method annotation.

        if (!$formFields) {
            user_error("Form Fields could not be Found", E_USER_ERROR);
        }
        $fields = new FieldList(
            new HiddenField("Table", "Table", $table),
            new HiddenField("Record", "Record", $record)
        );
        foreach ($formFields as $f) {
            $fields->push($f);
        }

        $form = new Form(
            $controller = $this,
            $name = "OneRecordForm",
            $fields,
            $actions = new FieldList(new FormAction("save", "save and close"))
        );
        $form->loadDataFrom($obj);
        return $form;
    }

    public function save($data, $form)

The parameter $data is not used and could be removed.

    {
        $table = $this->SecureTableToBeUpdated();
        $record = $this->SecureRecordToBeUpdated();
        $obj = $table::get()->byID($record);
        if ($obj->canEdit()) {
            $form->saveInto($obj);
            $obj->write();
            return '
                <p>Your changes have been saved, please <a href="#" onclick="self.close(); return false;">close window</a>.</p>
                <script type="text/javascript">self.close();</script>';
        } else {
            return $this->permissionFailureStandard();
        }
    }

    public function show()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $table = $this->SecureTableToBeUpdated();
        $record = $this->SecureRecordToBeUpdated();
        $obj = $table::get()->byID($record);
        if ($obj->canEdit()) {
            //..
        } else {
            return $this->permissionFailure();

The method permissionFailure() does not exist on DataObjectOneRecordUpdateController. Did you maybe mean permissionFailureStandard()?

        }
    }
}