DataObjectOneFieldOneRecordUpdateController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	111
Duplicated Lines	19.82 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	popup_link_only()	0	6	1
A	popup_link()	7	7	2
A	init()	15	15	1
A	onefieldform()	0	32	4
A	save()	0	15	2

<?php
/**
 *@author nicolaas [at] sunnysideup.co.nz
 *@package: dataobjectsorter
 *@description: allows you to edit one field in one record
 *
 **/

class DataObjectOneFieldOneRecordUpdateController extends DataObjectSortBaseClass
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        "onefieldform" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION',
        "show" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION',
        "save" => 'DATA_OBJECT_SORT_AND_EDIT_PERMISSION'
    );

    /**
     *
     * make sure to also change in routes if you change this link
     * @var string
     */
    private static $url_segment = 'dataobjectonefieldonerecordupdate';

Consider using a different property name as you override a private property of the parent class.

    /**
     * get a link
     * @param  string $ClassName
     * @param  string $FieldName
     * @param  string $recordID
     *
     * @return string
     */
    public static function popup_link_only($ClassName, $FieldName, $recordID)
    {
        DataObjectSorterRequirements::popup_link_requirements();
        return Injector::inst()->get('DataObjectOneFieldOneRecordUpdateController')
            ->Link('show/'.$ClassName."/".$FieldName).'?id='.$recordID;
    }

    /**
     * get a link
     * @param  string $ClassName
     * @param  string $FieldName
     * @param  string $recordID
     * @param  string $linkText
     * @return string

Should the return type not be string|null?

     */
    public static function popup_link($ClassName, $FieldName, $recordID, $linkText = 'click here to edit')

This method seems to be duplicated in your project.

    {
        if ($link = self::popup_link_only($ClassName, $FieldName, $recordID)) {
            return '
                <a href="'.$link.'" class="modalPopUp modal-popup" data-width="800" data-height="600" data-rel="window.open(\''.$link.'\', \'sortlistFor'.$ClassName.$FieldName.$recordID.'\',\'toolbar=0,scrollbars=1,location=0,statusbar=0,menubar=0,resizable=1,width=600,height=600,left = 440,top = 200\'); return false;">'.$linkText.'</a>';
        }
    }

    public function init()

This method seems to be duplicated in your project.

    {
        //must set this first ...
        Config::inst()->update('SSViewer', 'theme_enabled', Config::inst()->get('DataObjectSorterRequirements', 'run_through_theme'));
        // Only administrators can run this method
        parent::init();
        DataObjectSorterRequirements::popup_requirements('onefieldonerecord');
        $url = Director::absoluteURL(
            Injector::inst()->get('DataObjectOneFieldOneRecordUpdateController')->Link('updatefield')
        );
        Requirements::customScript(
            "var DataObjectOneFieldOneRecordUpdateURL = '".$url."'",
            'DataObjectOneFieldOneRecordUpdateURL'
        );
    }

    public function onefieldform()
    {
        Versioned::set_reading_mode('Stage.Stage');
        $table = $this->SecureTableToBeUpdated();
        $field = $this->SecureFieldToBeUpdated();
        $record = $this->SecureRecordToBeUpdated();
        $obj = $table::get()->byID($record);
        if (! $obj) {
            user_error("record could not be found!", E_USER_ERROR);
        }
        if (! $obj->canEdit()) {
            return $this->permissionFailureStandard();
        }
        $FormField = $this->getFormField($obj, $field);
        if (!$FormField) {
            user_error("Form Field could not be Found", E_USER_ERROR);
        }
        $FormField->setValue($obj->$field);
        $form = new Form(
            $controller = $this,
            $name = "OneFieldForm",
            $fields = new FieldList(
                $FormField,
                new HiddenField("Table", "Table", $table),
                new HiddenField("Field", "Field", $field),
                new HiddenField("Record", "Record", $record)
            ),
            $actions = new FieldList(new FormAction("save", "save and close"))
        );

        return $form;
    }

    public function save($data, $form)

The parameter $form is not used and could be removed.

    {
        $table = $this->SecureTableToBeUpdated();
        $field = $this->SecureFieldToBeUpdated();
        $record = $this->SecureRecordToBeUpdated();
        $obj = $table::get()->byID($record);
        if (! $obj->canEdit()) {
            return $this->permissionFailureStandard();
        }
        $obj->$field = $data[$field];
        $obj->write();
        return '
            <p>Your changes have been saved, please <a href="#" onclick="self.close(); return false;">close window</a>.</p>
            <script type="text/javascript">self.close();</script>';
    }
}