SunnySideUp\BuildDataObject\BuildController

Complexity

Total Complexity

104

Size/Duplication

Total Lines	641
Duplicated Lines	6.4 %

Coupling/Cohesion

Components	1
Dependencies	17

Importance

Changes

0

32 Methods

Rating	Name	Duplication	Size	Complexity
	primaryThingsToBuild()	0	1	?
	secondaryThingsToBuild()	0	1	?
A	Link()	0	10	2
A	LoadTemplateLink()	0	4	1
A	Title()	0	4	1
A	jQueryLink()	0	4	1
A	startover()	0	6	1
A	loadtemplate()	0	19	2
A	turnStaticsIntoSessionData()	0	20	4
A	index()	0	4	1
A	primaryformstart()	8	8	1
A	PrimaryForm()	0	6	1
A	doprimaryform()	0	6	1
A	secondaryformstart()	9	9	1
A	SecondaryForm()	0	6	1
A	dosecondaryform()	0	6	1
A	results()	0	10	1
A	debug()	0	7	1
A	Form()	0	4	1
A	FinalData()	0	4	1
A	PrevLink()	0	4	1
A	ClassNameForObject()	0	8	2
B	MyCanMethodBuilder()	0	15	5
F	createForm()	24	244	37
A	additionalPrimaryFields()	0	4	1
A	saveData()	0	19	4
B	retrieveData()	0	21	8
C	processedFormData()	0	56	17
A	resultsTemplateForBuilder()	0	4	1
A	prependNullOption()	0	6	1
A	myAPI()	0	6	1
A	addKeysToThingsToBuild()	0	18	3

<?php


namespace SunnySideUp\BuildDataObject;



abstract class BuildController extends \Controller {


    private static $form_data_session_variable = 'SunnySideUp\BuildDataObject\DataObjectBuildController';

The property $form_data_session_variable is not used and could be removed.

    private static $url_segment = 'build';

The property $url_segment is not used and could be removed.

    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'primaryformstart' => true,
        'PrimaryForm' => true,
        'doprimaryform' => true,
        'secondaryformstart' => true,
        'SecondaryForm' => true,
        'dosecondaryform' => true,
        'results' => true,
        'startover' => true,
        'loadtemplate' => true,
        'debug' => true
    ];

    protected $myBaseClass = 'DataObject';

    protected $apiProvider = 'SunnySideUp\BuildDataObject\API';

    abstract protected function primaryThingsToBuild();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract protected function secondaryThingsToBuild();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    public function Link($action = null)
    {
        if($action) {
            $action .= '/';
        }
        return
            '/'.$this->Config()->get('url_segment').
            '/'.strtolower($this->myBaseClass).
            '/'.$action;
    }

    public function LoadTemplateLink($className = '')
    {
        return $this->Link('loadtemplate').'?classname='.$className;
    }

    public function Title()
    {
        return 'Build a '.$this->myBaseClass.' - Step '.$this->step.' of 2';
    }


    public function jQueryLink()
    {
        return \Director::absoluteURL('/framework/thirdparty/jquery/jquery.js');
    }

    public function startover()
    {
        $this->saveData('_PrimaryForm', null);
        $this->saveData('_SecondaryForm', null);
        return $this->redirect($this->link('primaryformstart'));
    }

    public function loadtemplate($request)
    {
        $className = $request->getVar('classname');
        if(class_exists($className)) {
            $obj = \Injector::inst()->get($className);
            $primaryData = $this->turnStaticsIntoSessionData('primaryThingsToBuild', $className);
            $primaryData['Name'] = $className;
            $extends = get_parent_class($className);
            $primaryData['Extends'] = $extends;
            $primaryData['singular_name'] = $obj->i18n_singular_name();
            $primaryData['plural_name'] = $obj->i18n_plural_name();
            $this->saveData('_PrimaryForm', $primaryData);

            $secondaryData = $this->turnStaticsIntoSessionData('secondaryThingsToBuild', $className);
            $this->saveData('_SecondaryForm', $secondaryData);

            return $this->redirect($this->link('primaryformstart'));
        }
    }

    protected function turnStaticsIntoSessionData($method, $className) {
        $data = [];
        $thingsToBuild = $this->$method();
        foreach($thingsToBuild as $static) {
            $varName = $static['Name'];
            $varValue = \Config::inst()->get($className, $varName);
            if(is_array($varValue)) {
                $count = 0;
                foreach($varValue as $varInnerKey => $varInnerValue) {
                    $count++;
                    $data[$varName.'__KEY__'.$count] = $varInnerKey;
                    $data[$varName.'__VALUE__'.$count] = trim(preg_replace("/\([^)]+\)/","",$varInnerValue));
                }
            } else {
                $data[$varName] = $varValue;
            }
        }

        return $data;
    }

    /**
     *
     * @var Form
     */
    protected $step = 1;

    /**
     *
     * @var Form
     */
    protected $form = null;

    /**
     *
     * @var Form
     */
    protected $prevLink = null;

    /**
     *
     * @var ArrayList
     */
    protected $finalData = null;

    function index()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->redirect($this->Link('primaryformstart'));
    }

    function primaryformstart()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $this->PrimaryForm();
        $this->prevLink = $this->Link('startover');

It seems like $this->Link('startover') of type string is incompatible with the declared type object<SunnySideUp\BuildDataObject\Form> of property $prevLink.

        \SSViewer::set_source_file_comments(false);

The method SSViewer::set_source_file_comments() has been deprecated with message: 4.0 Use the "SSViewer.source_file_comments" config setting instead

        return $this->renderWith('BuildControllerForm');
    }

    function PrimaryForm()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->form = $this->createForm('PrimaryForm', 'Build Model');

It seems like $this->createForm('PrimaryForm', 'Build Model') of type object<Form> is incompatible with the declared type object<SunnySideUp\BuildDataObject\Form> of property $form.

        return $this->form;
    }

    function doprimaryform($data, $form)

The parameter $form is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->saveData('_PrimaryForm', $data);

        return $this->redirect($this->Link('secondaryformstart'));
    }


    function secondaryformstart()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        $this->step = 2;

It seems like 2 of type integer is incompatible with the declared type object<SunnySideUp\BuildDataObject\Form> of property $step.

        $this->SecondaryForm();
        $this->prevLink = $this->Link('primaryformstart');

It seems like $this->Link('primaryformstart') of type string is incompatible with the declared type object<SunnySideUp\BuildDataObject\Form> of property $prevLink.

        \SSViewer::set_source_file_comments(false);

The method SSViewer::set_source_file_comments() has been deprecated with message: 4.0 Use the "SSViewer.source_file_comments" config setting instead

        return $this->renderWith('BuildControllerForm');
    }

    function SecondaryForm()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->form = $this->createForm('SecondaryForm', 'Download Example Class');

It seems like $this->createForm('SecondaryForm', 'Download Example Class') of type object<Form> is incompatible with the declared type object<SunnySideUp\BuildDataObject\Form> of property $form.

        return $this->form;
    }


    function dosecondaryform($data, $form)

The parameter $form is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->saveData('_SecondaryForm', $data);

        return $this->redirect($this->Link('results'));
    }

    function results()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->finalData = $this->processedFormData($this->retrieveData());
        \SSViewer::set_source_file_comments(false);

The method SSViewer::set_source_file_comments() has been deprecated with message: 4.0 Use the "SSViewer.source_file_comments" config setting instead

        return \SS_HTTPRequest::send_file(
            $this->renderWith($this->resultsTemplateForBuilder()),
            $this->finalData->Name.'.php'
        );
    }

    function debug()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $this->finalData = $this->processedFormData($this->retrieveData());
        print_r($this->CanMethodBuilder('canEdit'));

The method CanMethodBuilder() does not exist on SunnySideUp\BuildDataObject\BuildController. Did you maybe mean MyCanMethodBuilder()?

        print_r($this->finalData);
        die('-----------------------------');

The method debug() contains an exit expression.

    }

    function Form()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->form;
    }

    function FinalData()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->finalData;
    }

    function PrevLink()

It is generally recommended to explicitly declare the visibility for methods.

    {
        return $this->prevLink;
    }

    protected function ClassNameForObject()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if(isset($this->finalData->Name)) {
            return $this->finalData->Name;
        } else {
            return 'self::$class';
        }
    }

    function MyCanMethodBuilder($type, $value) {

The parameter $type is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

        if($value === 'parent') {
            return null;
        } elseif($value === 'one') {
            $str = 'DataObject::get_one($this->class) ? false : true;';
        } elseif($value === 'true') {
            $str = 'true;';
        } elseif($value === 'false') {
            $str = 'false;';
        } else {
            $str = 'Permission::check(\''.$value.'\', \'any\', $member);';
        }

        return \DBField::create_field('Varchar', $str);
    }


    protected function createForm($formName, $actionTitle)
    {
        if($formName === 'PrimaryForm') {
            $isPrimary = true;
            $isSecond = false;

$isSecond is not used, you could remove the assignment.

        } elseif($formName === 'SecondaryForm') {
            $isPrimary = false;
            $isSecond = true;

$isSecond is not used, you could remove the assignment.

        } else {
            user_error('Set right form type: '.$formName.' is not valid');
        }

        $finalFields = \FieldList::create();

        if($isPrimary) {

The variable $isPrimary does not seem to be defined for all execution paths leading up to this point.

            $toBuild = $this->primaryThingsToBuild();
            $possibleExtensions = $this->myAPI()->PossibleRelationsWithBaseClass($this->myBaseClass);
            $finalFields->push(\HeaderField::create('Based On (OPTIONAL) ...'));
            $possibleBasedOn = $possibleExtensions;
            unset($possibleBasedOn['DataObject']);
            $possibleBasedOn = ['' => '--- PRELOAD VALUES FROM ---'] + $possibleBasedOn;
            $finalFields->push(\DropdownField::create('Template', '', $possibleBasedOn));
            $finalFields->push(\HeaderField::create('Name your '.$this->myBaseClass));
            $finalFields->push(\TextField::create('Name', ''));
            $finalFields->push(\HeaderField::create('Extends'));
            asort($possibleExtensions);
            $finalFields->push(
                \DropdownField::create(
                    'Extends',
                    '',
                    $possibleExtensions
                )
            );
            $additionalFields = $this->additionalPrimaryFields();
            foreach($additionalFields as $additionalField) {
                $finalFields->push($additionalField);
            }
        } else {
            $toBuild = $this->secondaryThingsToBuild();
        }
        $formFields = [];
        $formFieldsWithMultiple = [];

        $count = 0;
        //build fields ...
        foreach($toBuild as $item) {
            $name = $item['Name'];
            $sourceMethod1 = $item['SourceMethod1'];
            $sourceMethod2 = $item['SourceMethod2'];
            $isMultiple = $item['IsMultiple'];


            //work out style
            $hasKeyAndValue = false;
            if($sourceMethod1 && $sourceMethod2) {
                $hasKeyAndValue = true;
            }
            $formFields[$count] = [];
            if($isMultiple) {
                $max = 12;
            } else {
                $max = 1;
            }
            $formFields[$count][0] = [
                $name.'_HEADER',
                'HeaderField',
                $name
            ];


            //work out sources
            if($sourceMethod1 && $this->myAPI()->hasMethod($sourceMethod1)) {
                $source1 = $this->myAPI()->$sourceMethod1();
            } else {
                $source1 = null;
            }
            if($sourceMethod2 && $this->myAPI()->hasMethod($sourceMethod2)) {
                $source2 = $this->myAPI()->$sourceMethod2();
            } elseif($sourceMethod2) {
                $source2 = null;
            } else {
                $source2 = 'ignore';
            }

            //work out field names

            for($i = 1; $i <= $max; $i++) {
                if($hasKeyAndValue) {
                    if($isMultiple) {
                        $nameKey = $name.'__KEY__'.$i;
                        $nameValue = $name.'__VALUE__'.$i;
                        $formFieldsWithMultiple[$nameKey] = $nameKey;
                    } else {
                        $nameKey = $name.'__KEY__';
                        $nameValue = $name.'__VALUE__';
                    }
                } else {
                    if($isMultiple) {
                        $nameKey = $name.$i;
                        $nameValue = '';
                        $formFieldsWithMultiple[$nameKey] = $nameKey;
                    } else {
                        $nameKey = $name;
                        $nameValue = '';
                    }
                }
                if($hasKeyAndValue) {
                    //key field
                    if($source1) {

This code seems to be duplicated across your project.

                        $formFields[$count][$i]['KEY'] = [
                            $nameKey,
                            'DropdownField',
                            $source1
                        ];
                    } else {
                        $formFields[$count][$i]['KEY'] = [
                            $nameKey,
                            'TextField'
                        ];
                    }

                    //value field
                    if($source2) {

This code seems to be duplicated across your project.

                        $formFields[$count][$i]['VALUE'] = [
                            $nameValue,
                            'DropdownField',
                            $source2
                        ];
                    } else {
                        $formFields[$count][$i]['VALUE'] = [
                            $nameValue,
                            'TextField'
                        ];
                    }
                } else {
                    //keys only!
                    if($source1) {
                        $formFields[$count][$i] = [
                            $nameKey,
                            'DropdownField',
                            $source1
                        ];
                    } else {
                        $formFields[$count][$i] = [
                            $nameKey,
                            'TextField'
                        ];
                    }
                }
            }
            if($i > 2) {
                $formFields[$count][$i + 1] = [
                    $name.'_ADD_'.$i,
                    'LiteralField',
                    '
                    <div class="CompositeField add-and-remove">
                        <a href="#" class="add first-add"><i class="material-icons">add_circle_outline</i></a>
                        <a href="#" class="remove"><i class="material-icons">remove_circle_outline</i></a>
                    </div>
                    '
                ];
            }
            $count++;
        }
        //create fields ...
        $count = 0;
        foreach($formFields as $outerCount => $subFieldList) {
            $count++;
            $compositeField = \CompositeField::create();
            $compositeField->addExtraClass('OuterComposite pos'.$count);
            $innerCount = 0;
            foreach($subFieldList as $innerCount => $fieldDetails) {
                $innerCount++;
                if(isset($fieldDetails['KEY']) && isset($fieldDetails['VALUE'])) {
                    $subCompositeField = \CompositeField::create();
                    $subCompositeField->addExtraClass('InnerComposite pos'.$innerCount);
                    foreach($fieldDetails as $fieldDetailsInner) {
                        $fieldName = $fieldDetailsInner[0];
                        $fieldType = $fieldDetailsInner[1];
                        $additionalClasses = [];
                        if(strpos($fieldName, '__KEY__')) {
                            $additionalClasses[] = 'mykey';
                        }
                        if(strpos($fieldName, '__VALUE__')) {
                            $additionalClasses[] = 'myvalue';
                        }
                        if(isset($fieldDetailsInner[2])) {
                            $source = $fieldDetailsInner[2];
                            asort($source);
                            $source = $this->prependNullOption( $source );
                            $tempField = $fieldType::create($fieldName, '', $source);
                        } else {
                            $tempField = $fieldType::create($fieldName, '');
                        }
                        if(count($additionalClasses)) {
                            $classes = implode(' ', $additionalClasses);
                            $tempField->addExtraClass($classes);
                        }
                        $subCompositeField->push($tempField);
                    }
                    $compositeField->push($subCompositeField);
                } else {
                    $fieldName = $fieldDetails[0];
                    if(isset($formFieldsWithMultiple[$fieldName])) {
                        $subCompositeField = \CompositeField::create();
                        $subCompositeField->addExtraClass('InnerComposite pos'.$innerCount);
                    } else {
                        $subCompositeField = null;
                    }
                    $fieldType = $fieldDetails[1];
                    if($fieldType === 'DropdownField') {
                        $source = $fieldDetails[2];
                        asort($source);
                        $source = $this->prependNullOption($source);
                        $myTempfield = $fieldType::create($fieldName, '', $source);
                    } elseif($fieldType === 'HeaderField') {
                        $title = str_replace('_', ' ', $fieldDetails[2]);
                        $myTempfield = $fieldType::create($fieldName, $title);
                    } elseif($fieldType === 'LiteralField') {
                        $title = $fieldDetails[2];
                        $myTempfield = $fieldType::create($fieldName, $title);
                    } else {
                        $myTempfield = $fieldType::create($fieldName, '');
                    }
                    if($subCompositeField) {
                        $subCompositeField->push($myTempfield);
                        $compositeField->push($subCompositeField);
                    } else {
                        $compositeField->push($myTempfield);
                    }
                }
            }
            $finalFields->push($compositeField);
        }
        $actions = \FieldList::create(
            [\FormAction::create('do'.strtolower($formName), $actionTitle)]
        );

        $form = \Form::create($this, $formName, $finalFields, $actions);
        $form->setFormAction($this->Link($formName));
        $form->loadDataFrom($this->retrieveData());

        return $form;
    }

    /**
     * returns an array of fields
     * @return array
     */
    protected function additionalPrimaryFields()
    {
        return [];
    }

    protected function saveData($name, $data)
    {
        unset($data['url']);
        unset($data['SecurityID']);
        if(is_array($data)) {
            foreach($data as $key => $value) {
                if (strpos($key, 'action_') === 0) {
                    unset($data[$key]);
                }
            }
        }
        $var = $this->Config()->get('form_data_session_variable');
        \Session::clear($var.$name);
        \Session::save();
        \Session::set($var.$name, null);
        \Session::save();
        \Session::set($var.$name, $data);
        \Session::save();
    }

    private $_data = null;

    protected function retrieveData()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if(! $this->_data) {
            $var = $this->Config()->get('form_data_session_variable');
            $retrieveDataPrimary = \Session::get($var.'_PrimaryForm');
            if ($retrieveDataPrimary && (is_array($retrieveDataPrimary) || is_object($retrieveDataPrimary))) {

This if statement is empty and can be removed.

                //do nothing
            } else {
                $retrieveDataPrimary = [];
            }
            $retrieveDataSecondary = \Session::get($var.'_SecondaryForm');
            if ($retrieveDataSecondary && (is_array($retrieveDataSecondary) || is_object($retrieveDataSecondary))) {

This if statement is empty and can be removed.

                //do nothing
            } else {
                $retrieveDataSecondary = [];
            }
            $this->_data = $retrieveDataPrimary + $retrieveDataSecondary;
        }

        return $this->_data;
    }

    private $_processed_data = null;

    protected function processedFormData($data = null) {

The return type could not be reliably inferred; please add a @return annotation.

        if(! $this->_processed_data) {
            if(! $data) {
                $data = $this->retrieveData();
            }
            $array = [];
            foreach($data as $key => $value) {
                if($key && $value) {
                    if(
                        strpos($key, '__KEY__') ||
                        strpos($key, '__VALUE__')
                    ) {
                        $parts = explode('__', $key);
                        if(!isset($array[$parts[0]])) {
                            $array[$parts[0]] = [];
                        }
                        if(! isset($array[$parts[0]][$parts[2]])) {
                            $array[$parts[0]][$parts[2]] = [];
                        }
                        $array[$parts[0]][$parts[2]][$parts[1]] = $value;
                    } elseif(substr($key, 0, 3) === 'can') {
                        $array[$key] = $this->MyCanMethodBuilder($key, $value);
                    } else {
                        $array[$key] = $value;
                    }
                }
            }
            foreach($array as $field => $values) {
                $alInner = \ArrayList::create();
                if(is_array($values)) {
                    foreach($values as $key => $valuePairs) {
                        if(isset($valuePairs['KEY']) && isset($valuePairs['VALUE'])) {
                            if($valuePairs['VALUE'] == 'true') {
                                $valuePairArray = [
                                    'Key' => $valuePairs['KEY'],
                                    'UnquotedValue' => $valuePairs['VALUE'],
                                ];
                            } else {
                                $valuePairArray = [
                                    'Key' => $valuePairs['KEY'],
                                    'Value' => $valuePairs['VALUE'],
                                ];
                            }
                            $alInner->push(\ArrayData::create($valuePairArray));
                        }
                    }
                    $array[$field] = $alInner;
                } else {

This else statement is empty and can be removed.

                    //do nothing
                }
            }
            $this->_processed_data = \ArrayData::create($array);
        }

        return $this->_processed_data;
    }


    protected function resultsTemplateForBuilder()
    {
        return str_replace(__NAMESPACE__ .'\\', '', $this->class).'Results';
    }


    protected function prependNullOption($source)
    {
        $source = ['' => '--- Please Select ---'] + $source;

        return $source;
    }


    protected function myAPI()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $class = $this->apiProvider;

        return $class::inst($this->myBaseClass, $this->processedFormData());
    }

    protected function addKeysToThingsToBuild($array)
    {
        $newArray = [];
        $fields = [
            'Name',
            'SourceMethod1',
            'SourceMethod2',
            'IsMultiple'
        ];
        foreach($array as $arrayRowKey => $arrayRowValues){
            $newArray[$arrayRowKey] = [];
            foreach($arrayRowValues as $arrayColumnKey => $arrayColumnValue) {
                $newArray[$arrayRowKey][$fields[$arrayColumnKey]] = $arrayColumnValue;
            }
        }

        return $newArray;
    }


}