| Conditions | 37 |
| Paths | > 20000 |
| Total Lines | 244 |
| Code Lines | 178 |
| Lines | 24 |
| Ratio | 9.84 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 248 | protected function createForm($formName, $actionTitle) |
||
| 249 | { |
||
| 250 | if ($formName === 'PrimaryForm') { |
||
| 251 | $isPrimary = true; |
||
| 252 | $isSecond = false; |
||
| 253 | } elseif ($formName === 'SecondaryForm') { |
||
| 254 | $isPrimary = false; |
||
| 255 | $isSecond = true; |
||
| 256 | } else { |
||
| 257 | user_error('Set right form type: '.$formName.' is not valid'); |
||
| 258 | } |
||
| 259 | |||
| 260 | $finalFields = \FieldList::create(); |
||
| 261 | |||
| 262 | if ($isPrimary) { |
||
| 263 | $toBuild = $this->primaryThingsToBuild(); |
||
| 264 | $possibleExtensions = $this->myAPI()->PossibleRelationsWithBaseClass($this->myBaseClass); |
||
| 265 | $finalFields->push(\HeaderField::create('Based On (OPTIONAL) ...')); |
||
| 266 | $possibleBasedOn = $possibleExtensions; |
||
| 267 | unset($possibleBasedOn['DataObject']); |
||
| 268 | $possibleBasedOn = ['' => '--- PRELOAD VALUES FROM ---'] + $possibleBasedOn; |
||
| 269 | $finalFields->push(\DropdownField::create('Template', '', $possibleBasedOn)); |
||
| 270 | $finalFields->push(\HeaderField::create('Name your '.$this->myBaseClass)); |
||
| 271 | $finalFields->push(\TextField::create('Name', '')); |
||
| 272 | $finalFields->push(\HeaderField::create('Extends')); |
||
| 273 | asort($possibleExtensions); |
||
| 274 | $finalFields->push( |
||
| 275 | \DropdownField::create( |
||
| 276 | 'Extends', |
||
| 277 | '', |
||
| 278 | $possibleExtensions |
||
| 279 | ) |
||
| 280 | ); |
||
| 281 | $additionalFields = $this->additionalPrimaryFields(); |
||
| 282 | foreach ($additionalFields as $additionalField) { |
||
| 283 | $finalFields->push($additionalField); |
||
| 284 | } |
||
| 285 | } else { |
||
| 286 | $toBuild = $this->secondaryThingsToBuild(); |
||
| 287 | } |
||
| 288 | $formFields = []; |
||
| 289 | $formFieldsWithMultiple = []; |
||
| 290 | |||
| 291 | $count = 0; |
||
| 292 | //build fields ... |
||
| 293 | foreach ($toBuild as $item) { |
||
| 294 | $name = $item['Name']; |
||
| 295 | $sourceMethod1 = $item['SourceMethod1']; |
||
| 296 | $sourceMethod2 = $item['SourceMethod2']; |
||
| 297 | $isMultiple = $item['IsMultiple']; |
||
| 298 | |||
| 299 | |||
| 300 | //work out style |
||
| 301 | $hasKeyAndValue = false; |
||
| 302 | if ($sourceMethod1 && $sourceMethod2) { |
||
| 303 | $hasKeyAndValue = true; |
||
| 304 | } |
||
| 305 | $formFields[$count] = []; |
||
| 306 | if ($isMultiple) { |
||
| 307 | $max = 12; |
||
| 308 | } else { |
||
| 309 | $max = 1; |
||
| 310 | } |
||
| 311 | $formFields[$count][0] = [ |
||
| 312 | $name.'_HEADER', |
||
| 313 | 'HeaderField', |
||
| 314 | $name |
||
| 315 | ]; |
||
| 316 | |||
| 317 | |||
| 318 | //work out sources |
||
| 319 | if ($sourceMethod1 && $this->myAPI()->hasMethod($sourceMethod1)) { |
||
| 320 | $source1 = $this->myAPI()->$sourceMethod1(); |
||
| 321 | } else { |
||
| 322 | $source1 = null; |
||
| 323 | } |
||
| 324 | if ($sourceMethod2 && $this->myAPI()->hasMethod($sourceMethod2)) { |
||
| 325 | $source2 = $this->myAPI()->$sourceMethod2(); |
||
| 326 | } elseif ($sourceMethod2) { |
||
| 327 | $source2 = null; |
||
| 328 | } else { |
||
| 329 | $source2 = 'ignore'; |
||
| 330 | } |
||
| 331 | |||
| 332 | //work out field names |
||
| 333 | |||
| 334 | for ($i = 1; $i <= $max; $i++) { |
||
| 335 | if ($hasKeyAndValue) { |
||
| 336 | if ($isMultiple) { |
||
| 337 | $nameKey = $name.'__KEY__'.$i; |
||
| 338 | $nameValue = $name.'__VALUE__'.$i; |
||
| 339 | $formFieldsWithMultiple[$nameKey] = $nameKey; |
||
| 340 | } else { |
||
| 341 | $nameKey = $name.'__KEY__'; |
||
| 342 | $nameValue = $name.'__VALUE__'; |
||
| 343 | } |
||
| 344 | } else { |
||
| 345 | if ($isMultiple) { |
||
| 346 | $nameKey = $name.$i; |
||
| 347 | $nameValue = ''; |
||
| 348 | $formFieldsWithMultiple[$nameKey] = $nameKey; |
||
| 349 | } else { |
||
| 350 | $nameKey = $name; |
||
| 351 | $nameValue = ''; |
||
| 352 | } |
||
| 353 | } |
||
| 354 | if ($hasKeyAndValue) { |
||
| 355 | //key field |
||
| 356 | View Code Duplication | if ($source1) { |
|
| 357 | $formFields[$count][$i]['KEY'] = [ |
||
| 358 | $nameKey, |
||
| 359 | 'DropdownField', |
||
| 360 | $source1 |
||
| 361 | ]; |
||
| 362 | } else { |
||
| 363 | $formFields[$count][$i]['KEY'] = [ |
||
| 364 | $nameKey, |
||
| 365 | 'TextField' |
||
| 366 | ]; |
||
| 367 | } |
||
| 368 | |||
| 369 | //value field |
||
| 370 | View Code Duplication | if ($source2) { |
|
| 371 | $formFields[$count][$i]['VALUE'] = [ |
||
| 372 | $nameValue, |
||
| 373 | 'DropdownField', |
||
| 374 | $source2 |
||
| 375 | ]; |
||
| 376 | } else { |
||
| 377 | $formFields[$count][$i]['VALUE'] = [ |
||
| 378 | $nameValue, |
||
| 379 | 'TextField' |
||
| 380 | ]; |
||
| 381 | } |
||
| 382 | } else { |
||
| 383 | //keys only! |
||
| 384 | if ($source1) { |
||
| 385 | $formFields[$count][$i] = [ |
||
| 386 | $nameKey, |
||
| 387 | 'DropdownField', |
||
| 388 | $source1 |
||
| 389 | ]; |
||
| 390 | } else { |
||
| 391 | $formFields[$count][$i] = [ |
||
| 392 | $nameKey, |
||
| 393 | 'TextField' |
||
| 394 | ]; |
||
| 395 | } |
||
| 396 | } |
||
| 397 | } |
||
| 398 | if ($i > 2) { |
||
| 399 | $formFields[$count][$i + 1] = [ |
||
| 400 | $name.'_ADD_'.$i, |
||
| 401 | 'LiteralField', |
||
| 402 | ' |
||
| 403 | <div class="CompositeField add-and-remove"> |
||
| 404 | <a href="#" class="add first-add"><i class="material-icons">add_circle_outline</i></a> |
||
| 405 | <a href="#" class="remove"><i class="material-icons">remove_circle_outline</i></a> |
||
| 406 | </div> |
||
| 407 | ' |
||
| 408 | ]; |
||
| 409 | } |
||
| 410 | $count++; |
||
| 411 | } |
||
| 412 | //create fields ... |
||
| 413 | $count = 0; |
||
| 414 | foreach ($formFields as $outerCount => $subFieldList) { |
||
| 415 | $count++; |
||
| 416 | $compositeField = \CompositeField::create(); |
||
| 417 | $compositeField->addExtraClass('OuterComposite pos'.$count); |
||
| 418 | $innerCount = 0; |
||
| 419 | foreach ($subFieldList as $innerCount => $fieldDetails) { |
||
| 420 | $innerCount++; |
||
| 421 | if (isset($fieldDetails['KEY']) && isset($fieldDetails['VALUE'])) { |
||
| 422 | $subCompositeField = \CompositeField::create(); |
||
| 423 | $subCompositeField->addExtraClass('InnerComposite pos'.$innerCount); |
||
| 424 | foreach ($fieldDetails as $fieldDetailsInner) { |
||
| 425 | $fieldName = $fieldDetailsInner[0]; |
||
| 426 | $fieldType = $fieldDetailsInner[1]; |
||
| 427 | $additionalClasses = []; |
||
| 428 | if (strpos($fieldName, '__KEY__')) { |
||
| 429 | $additionalClasses[] = 'mykey'; |
||
| 430 | } |
||
| 431 | if (strpos($fieldName, '__VALUE__')) { |
||
| 432 | $additionalClasses[] = 'myvalue'; |
||
| 433 | } |
||
| 434 | if (isset($fieldDetailsInner[2])) { |
||
| 435 | $source = $fieldDetailsInner[2]; |
||
| 436 | asort($source); |
||
| 437 | $source = $this->prependNullOption($source); |
||
| 438 | $tempField = $fieldType::create($fieldName, '', $source); |
||
| 439 | } else { |
||
| 440 | $tempField = $fieldType::create($fieldName, ''); |
||
| 441 | } |
||
| 442 | if (count($additionalClasses)) { |
||
| 443 | $classes = implode(' ', $additionalClasses); |
||
| 444 | $tempField->addExtraClass($classes); |
||
| 445 | } |
||
| 446 | $subCompositeField->push($tempField); |
||
| 447 | } |
||
| 448 | $compositeField->push($subCompositeField); |
||
| 449 | } else { |
||
| 450 | $fieldName = $fieldDetails[0]; |
||
| 451 | if (isset($formFieldsWithMultiple[$fieldName])) { |
||
| 452 | $subCompositeField = \CompositeField::create(); |
||
| 453 | $subCompositeField->addExtraClass('InnerComposite pos'.$innerCount); |
||
| 454 | } else { |
||
| 455 | $subCompositeField = null; |
||
| 456 | } |
||
| 457 | $fieldType = $fieldDetails[1]; |
||
| 458 | if ($fieldType === 'DropdownField') { |
||
| 459 | $source = $fieldDetails[2]; |
||
| 460 | asort($source); |
||
| 461 | $source = $this->prependNullOption($source); |
||
| 462 | $myTempfield = $fieldType::create($fieldName, '', $source); |
||
| 463 | } elseif ($fieldType === 'HeaderField') { |
||
| 464 | $title = str_replace('_', ' ', $fieldDetails[2]); |
||
| 465 | $myTempfield = $fieldType::create($fieldName, $title); |
||
| 466 | } elseif ($fieldType === 'LiteralField') { |
||
| 467 | $title = $fieldDetails[2]; |
||
| 468 | $myTempfield = $fieldType::create($fieldName, $title); |
||
| 469 | } else { |
||
| 470 | $myTempfield = $fieldType::create($fieldName, ''); |
||
| 471 | } |
||
| 472 | if ($subCompositeField) { |
||
| 473 | $subCompositeField->push($myTempfield); |
||
| 474 | $compositeField->push($subCompositeField); |
||
| 475 | } else { |
||
| 476 | $compositeField->push($myTempfield); |
||
| 477 | } |
||
| 478 | } |
||
| 479 | } |
||
| 480 | $finalFields->push($compositeField); |
||
| 481 | } |
||
| 482 | $actions = \FieldList::create( |
||
| 483 | [\FormAction::create('do'.strtolower($formName), $actionTitle)] |
||
| 484 | ); |
||
| 485 | |||
| 486 | $form = \Form::create($this, $formName, $finalFields, $actions); |
||
| 487 | $form->setFormAction($this->Link($formName)); |
||
| 488 | $form->loadDataFrom($this->retrieveData()); |
||
| 489 | |||
| 490 | return $form; |
||
| 491 | } |
||
| 492 | |||
| 647 |
This check marks private properties in classes that are never used. Those properties can be removed.