sunnysideup / silverstripe-databasebackup

code/cms/Databasebackup_ModelAdmin.php

<?php



class Databasebackup_ModelAdmin extends ModelAdmin
{
    private static $managed_models = array('DatabasebackupLog');

Consider using a different property name as you override a private property of the parent class.

    private static $url_segment = 'databasebackuplog';

Consider using a different property name as you override a private property of the parent class.

    private static $menu_title = 'Database Backup';

Consider using a different property name as you override a private property of the parent class.

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        "test"
    );

    /**
     * @param Member $member

Should the type for parameter $member not be Member|null?

     * @return boolean
     */
    public function canView($member = null)
    {
        if (!$member && $member !== false) {
            $member = Member::currentUser();
        }

        // cms menus only for logged-in members
        if (!$member) {
            return false;
        }

        // Check for "CMS admin" permission
        if (Permission::checkMember($member, "ADMIN")) {

This if statement, and the following return statement can be replaced with return (bool) \Permission::checkMember($member, 'ADMIN');.

            return true;
        }
        return false;
    }


    /**
     *
     * allows for custom CMSActions
     */
    public function getEditForm($id = null, $fields = null)
    {
        $form = parent::getEditForm($id = null, $fields = null);
        $listfield = $form->Fields()->fieldByName("DatabasebackupLog");
        $model = Injector::inst()->get("DatabasebackupLog");

$model is not used, you could remove the assignment.

        $listfield->getConfig()->getComponentByType('GridFieldDetailForm')
            ->setItemRequestClass('DatabasebackupLogDetailForm_ItemRequest');
        //->setFormActions($model->getCMSActions());
        return $form;
    }
}