DatabasebackupLogDetailForm_ItemRequest

Complexity

Total Complexity

15

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	ItemEditForm()	0	11	2
B	doRestoreDatabaseBackup()	0	29	6
A	doDownload()	0	13	4
A	restoreDatabaseBackup()	0	16	3

<?php

class DatabasebackupLogDetailForm extends GridFieldDetailForm
{
}

class DatabasebackupLogDetailForm_ItemRequest extends GridFieldDetailForm_ItemRequest
{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        "ItemEditForm" => "ADMIN",
        "doDownload" => "ADMIN",
        'doRestoreDatabaseBackup' => "ADMIN"
    );

    public function ItemEditForm()
    {
        $form = parent::ItemEditForm();
        $actions = $this->record->getCMSActions();
        $oldActions = $form->Actions();
        foreach ($actions as $action) {
            $oldActions->push($action);
        }
        $form->setActions($oldActions);

It seems like $oldActions defined by $form->Actions() on line 19 can be null; however, Form::setActions() does not accept null, maybe add an additional type check?

        return $form;
    }

    /**
     * run the action (separate method) and send the right message back
     *
     */
    public function doRestoreDatabaseBackup($data, $form)

The parameter $data is not used and could be removed.

    {
        if (!$this->record->ID) {
            return new SS_HTTPResponse("Please pass an ID in the form content", 400);
        }
        $databaseToRestore = DatabasebackupLog::get()->byID($this->record->ID);
        if (!$databaseToRestore) {
            return new SS_HTTPResponse("backup #$id not found", 400);

The variable $id does not exist. Did you forget to declare it?

        }
        $outcome = $this->restoreDatabaseBackup($databaseToRestore);

$databaseToRestore of type object<DataObject> is not a sub-type of object<DatabasebackupLog>. It seems like you assume a child class of the class DataObject to be always present.

        if ($outcome) {
            $message = _t('Databasebackup.DB_RESTORED', 'Database Restored, please reload the entire site to continue...');
            $form->sessionMessage($message, 'good', false);
            return $this->getToplevelController()->redirectBack();
        } else {
            $message = _t('Databasebackup.DB_NOT_RESTORED', 'Database * NOT * Restored');
        }
        $toplevelController = $this->getToplevelController();
        if ($toplevelController && $toplevelController instanceof LeftAndMain) {
            $backForm = $toplevelController->getEditForm();
            $backForm->sessionMessage($message, 'good', false);

The method sessionMessage does only exist in CMSForm, but not in SS_HTTPResponse.

        } else {
            $form->sessionMessage($message, 'good', false);
        }
        //when an item is deleted, redirect to the parent controller
        $controller = $this->getToplevelController();
        $controller->getRequest()->addHeader('X-Pjax', 'Content'); // Force a content refresh
        return $controller->redirect($this->getBacklink(), 302); //redirect back to admin section
    }


    /**
     * downloads the file
     * @param Array $data
     * @param Form $form
     */
    public function doDownload($data, $form)

The parameter $data is not used and could be removed.

The parameter $form is not used and could be removed.

    {
        if (!$this->record->ID) {
            return new SS_HTTPResponse("Please pass an ID in the form content", 400);
        }
        $databaseToRestore = DatabasebackupLog::get()->byID($this->record->ID);
        if (!$databaseToRestore) {
            return new SS_HTTPResponse("backup #$id not found", 400);

The variable $id does not exist. Did you forget to declare it?

        }
        if (!file_exists($databaseToRestore->FullLocation)) {
            return new SS_HTTPResponse("file #$id not found", 400);
        }
    }

    /**
     * copies back up files up one ...
     * returns true on success, false on failure
     *
     * @param DatabasebackupLog $databaseToRestore
     *
     * @return Boolean
     */
    private function restoreDatabaseBackup(DatabasebackupLog $databaseToRestore)
    {
        if (Permission::check("ADMIN")) {
            Config::inst()->update("DatabasebackupLog", "max_db_copies", Config::inst()->get("DatabasebackupLog", "max_db_copies") + 1);
            //firstly make a backup of the current state ...
            $obj = new DatabasebackupLog();
            $obj->Title = _t("DatabaseBackup.RESTORE_NOTE", "Additional backup before doing a database restore.");

The property Title does not exist on object<DatabasebackupLog>. Since you implemented __set, maybe consider adding a @property annotation.

            $obj->write();
            //make sure it still exists ...
            $databaseToRestore = DatabasebackupLog::get()->byID($databaseToRestore->ID);
            if ($databaseToRestore) {
                return $databaseToRestore->restoreDatabaseBackup();
            }
        }
        return false;
    }
}