ContactUsFormEntry

Complexity

Total Complexity

10

Size/Duplication

Total Lines	141
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
B	create_enquiry()	0	26	1
A	i18n_singular_name()	0	1	1
A	i18n_plural_name()	0	1	1
A	canCreate()	0	3	1
A	canDelete()	0	3	1
B	getCMSFields()	0	29	2
A	getNiceData()	0	13	3

<?php

class ContactUsFormEntry extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        'AdminEmail' => 'Varchar(255)',
        'Email' => 'Varchar(255)',
        'FirstName' => 'Varchar(255)',
        'Surname' => 'Varchar(255)',
        'Phone' => 'Varchar(255)',
        'Enquiry' => 'Text',
        'Data' => 'Text',
        'Responded' => 'Boolean',
        'SentToAdmin' => 'Boolean',
        'SentToCustomer' => 'Boolean'
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        'Page' => 'SiteTree'
    );

    private static $casting = array(

Consider using a different property name as you override a private property of the parent class.

The property $casting is not used and could be removed.

        'NiceData' => 'HTMLText'
    );

    public static function create_enquiry($sqlSafeData, $page)
    {
        $obj = ContactUsFormEntry::create(
            array(
                'Email'=> ($sqlSafeData['Email']),
                'FirstName' => ($sqlSafeData['FirstName']),
                'Surname' => ($sqlSafeData['Surname']),
                'Phone' => ($sqlSafeData['Phone']),
                'Enquiry' => ($sqlSafeData['Enquiry']),
                //data is a backup for any additional fields in the form...
                "PageID" => $page->ID
            )
        );
        unset($sqlSafeData['url']);
        unset($sqlSafeData['action_docontactusform']);
        unset($sqlSafeData['SecurityID']);
        unset($sqlSafeData['Enquiry']);
        unset($sqlSafeData['Phone']);
        unset($sqlSafeData['FirstName']);
        unset($sqlSafeData['Surname']);
        unset($sqlSafeData['Email']);
        $obj->Data = serialize($sqlSafeData);

The property Data does not exist on object<ContactUsFormEntry>. Since you implemented __set, maybe consider adding a @property annotation.

        $obj->write();

        return $obj;
    }

    private static $singular_name = "Customer Enquiry";

Consider using a different property name as you override a private property of the parent class.

        function i18n_singular_name() { return self::$singular_name;}

It is generally recommended to explicitly declare the visibility for methods.

    private static $plural_name = "Customer Enquiries";

Consider using a different property name as you override a private property of the parent class.

        function i18n_plural_name() { return self::$plural_name;}

It is generally recommended to explicitly declare the visibility for methods.

    private static $indexes = array(

Consider using a different property name as you override a private property of the parent class.

The property $indexes is not used and could be removed.

        "Email" => true
    );

    private static $default_sort = array(

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

        'Created' => 'Desc'
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        'Email' => 'From',
        'AdminEmail' => 'To',
        'Created' => 'Created',
        'SentToAdmin.Nice' => 'Sent to Admin',
        'SentToCustomer.Nice' => 'Sent to Customer',
        'Enquiry' => 'Enquiry',
        'Responded.Nice' => 'Replied',
        'Page.Title' => 'Page'
    );

    private static $field_labes = array(

The property $field_labes is not used and could be removed.

        'Email' => 'From',
        'AdminEmail' => 'To'
    );

    public function canCreate($member = null) {
        return false;
    }

    public function canDelete($member = null) {
        return false;
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField(
                'Data',
                LiteralField::create('NiceData', $this->getNiceData())
         );
        $fixedFields = array(
            'AdminEmail',
            'SentToCustomer',
            'SentToAdmin',
            'FirstName',
            'Email',
            'Surname',
            'Phone',
            'Enquiry'
        );

        $labels = $this->FieldLabels();
        foreach($fixedFields as $fixedField) {
            $fields->replaceField(
                $fixedField,
                ReadonlyField::create($fixedField, $labels[$fixedField])
            );
        }
        $fields->removeByName('PageID');

        return $fields;
   }

    /**
     * returns list of fields as they are exported
     * @return array
     * Field => Label
     */
  //  public function getExportFields();

56% of this comment could be valid code. Did you maybe forget this after debugging?

    function getNiceData()

It is generally recommended to explicitly declare the visibility for methods.

    {
        $array = unserialize($this->Data);

The property Data does not exist on object<ContactUsFormEntry>. Since you implemented __get, maybe consider adding a @property annotation.

        $html = '<ul>';
        if(is_array($array)){
            foreach($array as $field => $value){
                $html .= '<li><strong>'.$field.':</strong> '.$value;
            }
        }
        $html .= '</ul>';

        return $html;
    }

}