Contact::getCMSFields() - Code Metrics - sunnysideup/silverstripe-contact_list - Measure and Improve Code Quality continuously with Scrutinizer

Contact::getCMSFields() A
last analyzed 2018-06-20 00:57 UTC

↳ Parent: Contact

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
c	0
b	0
f	0
rs	9.4285
cc	1
eloc	7
nc	1
nop	0

<?php

class Contact extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        'FirstName' => 'Varchar(50)',
        'Surname' => 'Varchar(50)',
        'Email' => 'EmailAddress',
        'BusinessName' => 'Varchar(50)',
        'Website' => 'Varchar(50)',
        'IsProfessional' => 'Boolean',
        'IsVisible' => 'Boolean',
        'IsHighlighted' => 'Boolean',
        'Reference' => 'Varchar(50)'
    );

    private static $has_one = array(

        'Location' => 'ContactLocation',
    );

    private static $many_many = array(

        'Type'  => 'ContactCategory'
    );

    private static $summary_fields = array(

        'Title' => 'Name',
        'BusinessName' => 'BusinessName'
    );

    private static $field_labels = array(

        'LocationID' => 'Locationnnn'
    );

    private static $searchable_fields = array(

        'Email' => 'PartialMatchFilter',
        'FirstName' => 'PartialMatchFilter',
        'Surname' => 'PartialMatchFilter',
        'BusinessName' => 'PartialMatchFilter',
        'Website' => 'PartialMatchFilter',
        'IsProfessional' => 'ExactMatchFilter',
        'IsVisible' => 'ExactMatchFilter',
        'IsHighlighted' => 'ExactMatchFilter',
        'Reference' => 'PartialMatchFilter'
    );

    /**
     * @inherited
     */
    private static $casting = array(

        'Title' => "Varchar"
    );

    /**
     * @inherited
     */
    private static $default_sort = array(

        'BusinessName' => "ASC"
    );

    private static $singular_name = 'Contact';


    private static $plural_name = 'Contacts';


    /**
     * @return String
     */
    public function Title()
    {
        return $this->getTitle();
    }
    public function getTitle()
    {
        return implode(' ', array($this->FirstName, $this->Surname));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSfields();
        $locationField = $fields->dataFieldByName('LocationID');
        $fields->replaceField(
            'LocationID',
            DropdownField::create('LocationID', $locationField->Title(), ContactLocation::get()->map())
        );
        return $fields;
    }
}


1			<?php
2
3			class Contact extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
6			'FirstName' => 'Varchar(50)',
7			'Surname' => 'Varchar(50)',
8			'Email' => 'EmailAddress',
9			'BusinessName' => 'Varchar(50)',
10			'Website' => 'Varchar(50)',
11			'IsProfessional' => 'Boolean',
12			'IsVisible' => 'Boolean',
13			'IsHighlighted' => 'Boolean',
14			'Reference' => 'Varchar(50)'
15			);
16
17			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
18			'Location' => 'ContactLocation',
19			);
20
21			private static $many_many = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
22			'Type' => 'ContactCategory'
23			);
24
25			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
26			'Title' => 'Name',
27			'BusinessName' => 'BusinessName'
28			);
29
30			private static $field_labels = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
31			'LocationID' => 'Locationnnn'
32			);
33
34			private static $searchable_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
35			'Email' => 'PartialMatchFilter',
36			'FirstName' => 'PartialMatchFilter',
37			'Surname' => 'PartialMatchFilter',
38			'BusinessName' => 'PartialMatchFilter',
39			'Website' => 'PartialMatchFilter',
40			'IsProfessional' => 'ExactMatchFilter',
41			'IsVisible' => 'ExactMatchFilter',
42			'IsHighlighted' => 'ExactMatchFilter',
43			'Reference' => 'PartialMatchFilter'
44			);
45
46			/**
47			* @inherited
48			*/
49			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
50			'Title' => "Varchar"
51			);
52
53			/**
54			* @inherited
55			*/
56			private static $default_sort = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
57			'BusinessName' => "ASC"
58			);
59
60			private static $singular_name = 'Contact';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
61
62			private static $plural_name = 'Contacts';
			0 ignored issues – show Comprehensibility introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
63
64			/**
65			* @return String
66			*/
67			public function Title()
68			{
69			return $this->getTitle();
70			}
71			public function getTitle()
72			{
73			return implode(' ', array($this->FirstName, $this->Surname));
			0 ignored issues – show Documentation introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `FirstName` does not exist on `object<Contact>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-03 00:27 UTC by Report Bug Copy Issue Report The property `Surname` does not exist on `object<Contact>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
74			}
75
76			public function getCMSFields()
77			{
78			$fields = parent::getCMSfields();
79			$locationField = $fields->dataFieldByName('LocationID');
80			$fields->replaceField(
81			'LocationID',
82			DropdownField::create('LocationID', $locationField->Title(), ContactLocation::get()->map())
83			);
84			return $fields;
85			}
86			}
87

sunnysideup / silverstripe-contact_list

Contact::getCMSFields() A last analyzed 2018-06-20 00:57 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Contact::getCMSFields() A
last analyzed 2018-06-20 00:57 UTC