SilverstripeColumnsPageControllerExtension

Complexity

Total Complexity

28

Size/Duplication

Total Lines	160
Duplicated Lines	14.38 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	HasFullWidthContent()	12	12	4
B	HasSideBar()	0	19	6
B	NumberOfColumns()	0	24	5
A	RecentlyUpdated()	0	18	3
A	InThisSection()	11	11	3
A	AlsoSee()	0	17	4
A	myspecificpagemenuitems()	0	13	3

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class SilverstripeColumnsPageControllerExtension extends Extension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $allowed_actions = [

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        'myspecificpagemenuitems' => true
    ];

    /**
     * @return bool
     */
    function HasFullWidthContent()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if($this->owner->hasMethod('HasFullWidthContentOverloaded')) {
            $v = $this->owner->HasFullWidthContentOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        if($this->owner->owner->getFullWidthContent()) {
            return true;
        }
    }

    /**
     * @return bool
     */
    function HasSideBar()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->owner->hasMethod('HasSideBarOverloaded')) {
            $v = $this->owner->HasSideBarOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        if(
            (
                $this->owner->UseDefaultSideBarContent() &&
                strlen($this->owner->getMyDefaultSidebarContent()) > 17
            )
            ||
            $this->owner->MySidebarImage()
        ) {
            return true;
        }
    }

    /**
     * @param boolean $asClassName
     *
     * @return string | int
     */
    function NumberOfColumns($asClassName = true)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->owner->hasMethod('NumberOfColumnsOverloaded')) {
            return $this->owner->NumberOfColumnsOverloaded();
            if($v !== null) {

if ($v !== null) { return $v; } does not seem to be reachable.

                return $v;
            }
        }
        $count = 1;
        if($this->owner->HasSideBar()) {
            $count++;
        }
        if($asClassName) {
            $array = array(
                1 => 'one',
                2 => 'two',
                3 => 'three'
            );
            return $array[$count];
        }
        else {
            return $count;
        }
    }


    /**
     * returns a data list of items that have been edited last - up to one day ago.
     * This ensures that we do not show stuff we have just fixed up...
     * @return DataList
     */
    function RecentlyUpdated($limit = 5)

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->owner->hasMethod('RecentlyUpdatedOverloaded')) {
            $v = $this->owner->RecentlyUpdatedOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        return Page::get()
            ->filter(
                array(
                    'ShowInSearch' => true,
                    'LastEdited:LessThan' => date('Y-m-d h:i:s', time() - 86400)
                )
            )
            ->sort(array('LastEdited' => 'DESC'))
            ->limit($limit);
    }

    /**
     *  Children Menu Items
     * @return null | DataList
     */
    function InThisSection()

It is generally recommended to explicitly declare the visibility for methods.

This method seems to be duplicated in your project.

    {
        if($this->owner->hasMethod('InThisSectionOverloaded')) {
            $v = $this->owner->InThisSectionOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        
        return $this->owner->ChildrenShowInMenu();
    }

    /**
     * Sibling Menu Items
     * @return null | DataList
     */
    function AlsoSee()

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->owner->hasMethod('AlsoSeeOverloaded')) {
            $v = $this->owner->AlsoSeeOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        if($this->owner->ParentID) {
            $parent = DataObject::get_one('Page', ['ParentID' => $this->owner->ParentID]);
            $list = $parent->ChildrenShowInMenu();
            $list->removeByID($this->owner->ID);

            return $list;

        }
    }

    /**
     * returns relevant menus items for
     * @param  SS_Request
     * @return string (html)
     */
    function myspecificpagemenuitems($request)

The parameter $request is not used and could be removed.

It is generally recommended to explicitly declare the visibility for methods.

    {
        if($this->owner->hasMethod('MySpecificPageMenuItemsOverloaded')) {
            $v = $this->owner->MySpecificPageMenuItemsOverloaded();
            if($v !== null) {
                return $v;
            }
        }
        $id = intval($this->owner->request->param('ID'));
        $page = Page::get()->byID($id);

        return $page->renderWith('MyMenuItems');
    }


}