ValidateCodeFieldForObject::checkCode() - Code Metrics - Inspection of "Update ValidateCodeFieldForObject.php" - sunnysideup/silverstripe-code_validator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2b172d...78d289 )

by Nicolaas

created 2018-09-19 08:40 UTC

ValidateCodeFieldForObject::checkCode() B

↳ Parent: ValidateCodeFieldForObject

Complexity

Conditions	10
Paths	24

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	41
rs	7.6666
c	0
b	0
f	0
cc	10
nc	24
nop	3

How to fix Complexity

<?php
/**
 */

class ValidateCodeFieldForObject extends Object
{
    private static $length = 7;

    /**
     * @var Array
     */
    private $replacements = array(
        '/&amp;/u' => '-and-',
        '/&/u' => '-and-',
        '/\s/u' => '-', // remove whitespace
        '/[^A-Za-z0-9.\-_]+/u' => '', // remove non-ASCII chars, only allow alphanumeric, dashes and dots.
        '/[\-]{2,}/u' => '-', // remove duplicate dashes
        '/[\_]{2,}/u' => '_', // remove duplicate underscores
        '/^[\.\-_]/u' => '', // Remove all leading dots, dashes or underscores
    );

    /**
     * makes sure that code is unique and gets rid of special characters
     * should be run in onBeforeWrite
     *
     * @param DataObject | String $obj
     * @param Boolean $createCode
     * @param String $field
     */

    public function checkCode($obj, $createCode = false, $field = "Code")

    {
        //exception dealing with Strings
        $isObject = true;
        if (! is_object($obj)) {
            $str = $obj;
            $obj = new DataObject();
            $obj->$field = strval($str);
            $isObject = false;
        }
        if ($createCode) {
            if (!$obj->$field || strlen($obj->$field) != $this->Config()->get("length")) {
                $obj->$field = $this->CreateCode();
            }
        } else {
            $obj->$field = trim($obj->$field);
            foreach ($this->replacements as $regex => $replace) {
                $obj->$field = preg_replace($regex, $replace, $obj->$field);
            }
        }
        if (!$obj->$field) {
            $obj->$field = strtoupper($field)."-NOT-SET";
        }
        //make upper-case
        $obj->$field = trim(strtoupper($obj->$field));
        //check for other ones.
        $count = 0;
        $code = $obj->$field;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        while (
            $isObject && 
            $obj::get()
                ->filter([$field => $obj->$field])
                ->exclude(["ID" => intval($obj->ID) - 0])->Count() > 0 &&
            $count < 1000
        ) {
            $obj->$field = $this->CreateCode();
            $count++;
        }
        
        return $obj->$field;
    }

    public function CreateCode()
    {
        $seed = str_split('ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'); // and any other characters
        $rand = '';
        foreach (array_rand($seed, $this->Config()->get("length")) as $k) {
            $rand .= $seed[$k];
        }

        return $rand;
    }
}


1			<?php
2			/**
3			*/
4
5			class ValidateCodeFieldForObject extends Object
6			{
7			private static $length = 7;
8
9			/**
10			* @var Array
11			*/
12			private $replacements = array(
13			'/&/u' => '-and-',
14			'/&/u' => '-and-',
15			'/\s/u' => '-', // remove whitespace
16			'/[^A-Za-z0-9.\-_]+/u' => '', // remove non-ASCII chars, only allow alphanumeric, dashes and dots.
17			'/[\-]{2,}/u' => '-', // remove duplicate dashes
18			'/[\_]{2,}/u' => '_', // remove duplicate underscores
19			'/^[\.\-_]/u' => '', // Remove all leading dots, dashes or underscores
20			);
21
22			/**
23			* makes sure that code is unique and gets rid of special characters
24			* should be run in onBeforeWrite
25			*
26			* @param DataObject \| String $obj
27			* @param Boolean $createCode
28			* @param String $field
29			*/
30
31			public function checkCode($obj, $createCode = false, $field = "Code")
			0 ignored issues – show Documentation introduced 2018-09-19 08:43 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
32			{
33			//exception dealing with Strings
34			$isObject = true;
35			if (! is_object($obj)) {
36			$str = $obj;
37			$obj = new DataObject();
38			$obj->$field = strval($str);
39			$isObject = false;
40			}
41			if ($createCode) {
42			if (!$obj->$field \|\| strlen($obj->$field) != $this->Config()->get("length")) {
43			$obj->$field = $this->CreateCode();
44			}
45			} else {
46			$obj->$field = trim($obj->$field);
47			foreach ($this->replacements as $regex => $replace) {
48			$obj->$field = preg_replace($regex, $replace, $obj->$field);
49			}
50			}
51			if (!$obj->$field) {
52			$obj->$field = strtoupper($field)."-NOT-SET";
53			}
54			//make upper-case
55			$obj->$field = trim(strtoupper($obj->$field));
56			//check for other ones.
57			$count = 0;
58			$code = $obj->$field;
			0 ignored issues – show Unused Code introduced 2018-09-19 08:43 UTC by Report Bug Copy Issue Report `$code` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
59			while (
60			$isObject &&
61			$obj::get()
62			->filter([$field => $obj->$field])
63			->exclude(["ID" => intval($obj->ID) - 0])->Count() > 0 &&
64			$count < 1000
65			) {
66			$obj->$field = $this->CreateCode();
67			$count++;
68			}
69
70			return $obj->$field;
71			}
72
73			public function CreateCode()
74			{
75			$seed = str_split('ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'); // and any other characters
76			$rand = '';
77			foreach (array_rand($seed, $this->Config()->get("length")) as $k) {
78			$rand .= $seed[$k];
79			}
80
81			return $rand;
82			}
83			}
84

sunnysideup / silverstripe-code_validator

Push — master ( 2b172d...78d289 )

ValidateCodeFieldForObject::checkCode() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like