CMSEditLinkField

Complexity

Total Complexity

6

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	21	6

<?php


class CMSEditLinkField extends ReadonlyField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $linkedObject = '';

    /**
     *
     * @param string $name                 e.g. MyLinkedObjectID
     * @param string $title                e.g. My Fancy Title
     * @param DataObject $linkedObject     e.g. $this->MyLinkedObjectID()
     * @param string $methodOrVariable     (OPTIONAL) - e.g. MyFullTitle
     */
    public function __construct($name, $title, $linkedObject, $methodOrVariable = 'getTitle')
    {
        $name .= '_CMSEditLink';
        if ($linkedObject && $linkedObject->exists() && $linkedObject->hasMethod('CMSEditLink')) {
            $this->linkedObject = $linkedObject;

It seems like $linkedObject of type object<DataObject> is incompatible with the declared type string of property $linkedObject.

            if($linkedObject->hasMethod($methodOrVariable)) {
                $description = $linkedObject->$methodOrVariable();
            } elseif(isset($linkedObject->$methodOrVariable)) {
                $description = $linkedObject->$methodOrVariable;
            } else {
                $description = 'ERROR!';
                user_error($methodOrVariable.' does not exist on '.$linkedObject.' (as method or variable)');
            }
            $content = '<p><a href="'.$linkedObject->CMSEditLink().'">'.$description.'</a></h3>';
            $this->dontEscape = true;

            return parent::__construct($name, $title, $content);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

        } else {
            return parent::__construct($name, $title);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

        }
    }

}