CMSEditLinkAPI

Complexity

Total Complexity

13

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	find_edit_link_for_object()	0	44	13

<?php


class CMSEditLinkAPI extends Object

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    private static $_cache = array();

    /**
     * common usage ...
     *
     *         public function CMSEditLink($action = null)
     *         {
     *             return CMSEditLinkAPI::find_edit_link_for_object($this, $action);
     *         };
     *
     * @param  DataObject | string $objectOrClassName
     * @param  string              $action

Should the type for parameter $action not be string|null?

     *
     * @return string
     */
    public static function find_edit_link_for_object($objectOrClassName, $action = null)
    {
        if($objectOrClassName instanceof DataObject && $objectOrClassName->exists()) {
            $modelName = $objectOrClassName->ClassName;
            $id = $objectOrClassName->ID;
        } else {
            $modelName = $objectOrClassName;
            $objectOrClassName = Injector::inst()->get($modelName);

$objectOrClassName is not used, you could remove the assignment.

            $id = 0;
        }
        $key = $modelName.'_'.$action;
        if(!isset(self::$_cache[$key])) {
            foreach(ClassInfo::subclassesFor('ModelAdmin') as $i => $class) {

The expression \ClassInfo::subclassesFor('ModelAdmin') of type null|array is not guaranteed to be traversable. How about adding an additional type check?

                if($class == 'ModelAdmin') {continue;}
                if(ClassInfo::classImplements($class, 'TestOnly')) {continue;}
                $myAdminClassName = $class;
                $modelAdminclassObject = Injector::inst()->get($myAdminClassName);
                $models = $modelAdminclassObject->getManagedModels();
                foreach($models as $key => $model) {
                    if($key === $modelName || $model === $modelName) {
                        $myManagerClass = $class;
                        $myManagerObject = $modelAdminclassObject;
                        break 2;
                    }
                }
            }
            if(isset($myManagerClass) && isset($myManagerObject)) {
                if(!$action) {

The expression $action of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

                    $action = $modelName.'/EditForm/field/'.$modelName.'/item/0/';
                    self::$_cache[$key] = Controller::join_links(
                        Director::baseURL(),
                        $myManagerObject->Link($action)
                    );
                } else {
                    return Controller::join_links(
                        Director::baseURL(),
                        $myManagerObject->Link($action)
                    );
                }
            }
        }

        return str_replace('item/0/', 'item/'.$id.'/', self::$_cache[$key]);
    }


}