Sunnysideup\CMSNiceties\Traits\CMSNicetiesTraitForCanMethods

Complexity

Total Complexity

12

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	canDelete()	0	3	1
B	canCreate()	0	40	10
A	canEdit()	0	3	1

<?php

namespace Sunnysideup\CMSNiceties\Traits;

use SilverStripe\ORM\ArrayList;
use SilverStripe\Security\Permission;
use SilverStripe\Security\Security;

trait CMSNicetiesTraitForCanMethods
{
    public function canCreate($member = null, $context = [])
    {
        if (! $member) {
            $member = Security::getCurrentUser();
        }

        if ($this->hasMethod('canEditingOwnerObject')) {

It seems like hasMethod() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $obj = $this->canEditingOwnerObject();

The method canEditingOwnerObject() does not exist on Sunnysideup\CMSNiceties\Traits\CMSNicetiesTraitForCanMethods. Did you maybe mean canEdit()?

            if ($obj instanceof ArrayList) {
                $outcome = true;
                foreach ($obj as $item) {
                    if (! $item->canCreate($member, $context)) {
                        $outcome = false;

                        break;
                    }
                }

                if ($outcome) {
                    return parent::canCreate($member, $context);
                }

                return false;
            }

            return $obj->canCreate($member, $context);
        }

        $groupCodes = $this->hasMethod('canEditingGroupsCodes') ? $this->canEditingGroupsCodes() : [

The method canEditingGroupsCodes() does not exist on Sunnysideup\CMSNiceties\Traits\CMSNicetiesTraitForCanMethods. Did you maybe mean canEdit()?

            'CMS_ACCESS_CMSMain',
        ];
        $groupCodes = array_merge(['ADMIN'], $groupCodes);

        foreach ($groupCodes as $groupCode) {
            if (Permission::checkMember($member, $groupCode)) {
                return parent::canCreate($member, $context);
            }
        }

        return false;
    }

    public function canEdit($member = null)
    {
        return $this->canCreate($member);
    }

    public function canDelete($member = null)
    {
        return $this->canCreate($member);
    }
}