CallToActionPageExtension - Code Metrics - sunnysideup/silverstripe-call_to_action - Measure and Improve Code Quality continuously with Scrutinizer

CallToActionPageExtension A
last analyzed 2018-03-20 00:56 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	8
dl	0
loc	58
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	updateCMSFields()	0	43	5

<?php

/**
 *@author nicolaas [at] sunnysideup.co.nz
 *
 *
 **/

class CallToActionPageExtension extends DataExtension
namespace YourVendor;

class YourClass { }
{
    private static $has_one = [

        'CallToAction' => 'CallToAction'
    ];

    private static $field_labels = [

        'CallToAction' => 'Call to action'
    ];

    private static $field_labels_right = [

        'CallToAction' => 'Big image with optional text'
    ];

    public function updateCMSFields(FieldList $fields)
    {
        $fieldLabels = $this->owner->FieldLabels();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $callToAction = CallToAction::singleton();
        $fieldLabelsRight = Config::inst()->get('CallToActionPageExtension', 'field_labels_right');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $tabTitle0 = $callToAction->i18n_singular_name();
        $link1 = '/admin/calltoaction/';
        $tabTitle1 = _t('CallToActionPageExtension.CREATE_NEW', 'view all');
        if ($this->owner->CallToActionID) {
            $callToAction = $this->owner->CallToAction();
            if ($callToAction && $callToAction->exists()) {
                $link2 = $this->owner->CallToAction()->CMSEditLink();
                $tabTitle2 = _t('CallToActionPageExtension.EDIT_CURRENT', 'edit').' '.$callToAction->getTitle();
            }
        }
        if (! isset($link2)) {
            $link2 = $callToAction->CMSAddLink();
            $tabTitle2 = _t('CallToActionPageExtension.CREATE_NEW', 'create new').' '.$callToAction->i18n_singular_name();
        }
        $fields->addFieldsToTab(
            'Root.'.$tabTitle0,
            [
                DropdownField::create(
                    'CallToActionID',
                    _t('CallToActionPageExtension.SELECT', 'select'),
                    [0 => _t('CallToActionPageExtension.PLEASE_SELECT', '-- please select --')] +CallToAction::get()->map()->toArray()
                ),
                LiteralField::create(
                    'CallToActionList',
                    '<h2>
                        ✎
                        <a href="'.$link1.'" target="_blank">'.$tabTitle1.'</a> |
                        <a href="'.$link2.'" target="_blank">'.$tabTitle2.'</a>
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    <h2>'
                ),
                LiteralField::create(
                    'CallToActionEdit',
                    ''
                )
            ]
        );
        return $fields;
    }
}


1			<?php
2
3			/**
4			*@author nicolaas [at] sunnysideup.co.nz
5			*
6			*
7			**/
8
9			class CallToActionPageExtension extends DataExtension
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			private static $has_one = [
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			'CallToAction' => 'CallToAction'
13			];
14
15			private static $field_labels = [
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$field_labels` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16			'CallToAction' => 'Call to action'
17			];
18
19			private static $field_labels_right = [
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report The property `$field_labels_right` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
20			'CallToAction' => 'Big image with optional text'
21			];
22
23			public function updateCMSFields(FieldList $fields)
24			{
25			$fieldLabels = $this->owner->FieldLabels();
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report `$fieldLabels` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
26			$callToAction = CallToAction::singleton();
27			$fieldLabelsRight = Config::inst()->get('CallToActionPageExtension', 'field_labels_right');
			0 ignored issues – show Unused Code introduced 2017-08-24 08:32 UTC by Report Bug Copy Issue Report `$fieldLabelsRight` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28			$tabTitle0 = $callToAction->i18n_singular_name();
29			$link1 = '/admin/calltoaction/';
30			$tabTitle1 = _t('CallToActionPageExtension.CREATE_NEW', 'view all');
31			if ($this->owner->CallToActionID) {
32			$callToAction = $this->owner->CallToAction();
33			if ($callToAction && $callToAction->exists()) {
34			$link2 = $this->owner->CallToAction()->CMSEditLink();
35			$tabTitle2 = _t('CallToActionPageExtension.EDIT_CURRENT', 'edit').' '.$callToAction->getTitle();
36			}
37			}
38			if (! isset($link2)) {
39			$link2 = $callToAction->CMSAddLink();
40			$tabTitle2 = _t('CallToActionPageExtension.CREATE_NEW', 'create new').' '.$callToAction->i18n_singular_name();
41			}
42			$fields->addFieldsToTab(
43			'Root.'.$tabTitle0,
44			[
45			DropdownField::create(
46			'CallToActionID',
47			_t('CallToActionPageExtension.SELECT', 'select'),
48			[0 => _t('CallToActionPageExtension.PLEASE_SELECT', '-- please select --')] +CallToAction::get()->map()->toArray()
49			),
50			LiteralField::create(
51			'CallToActionList',
52			'<h2>
53			✎
54			<a href="'.$link1.'" target="_blank">'.$tabTitle1.'</a> \|
55			<a href="'.$link2.'" target="_blank">'.$tabTitle2.'</a>
			0 ignored issues – show Bug introduced 2017-09-28 07:26 UTC by Report Bug Copy Issue Report The variable `$tabTitle2` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
56			<h2>'
57			),
58			LiteralField::create(
59			'CallToActionEdit',
60			''
61			)
62			]
63			);
64			return $fields;
65			}
66			}
67

sunnysideup / silverstripe-call_to_action

CallToActionPageExtension A last analyzed 2018-03-20 00:56 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Available Fixes

Duplication Side-by-Side

Filter issues like

CallToActionPageExtension A
last analyzed 2018-03-20 00:56 UTC