CalendarMonthView::MonthWeeks() - Code Metrics - sunnysideup/silverstripe-calendar - Measure and Improve Code Quality continuously with Scrutinizer

CalendarMonthView::MonthWeeks() C
last analyzed 2018-03-20 00:56 UTC

↳ Parent: CalendarMonthView

Complexity

Conditions	15
Paths	44

Size

Total Lines	40
Code Lines	26

Duplication

Lines	3
Ratio	7.5 %

Importance

Changes

Metric	Value
dl	3
loc	40
rs	5.0504
c	0
b	0
f	0
cc	15
eloc	26
nc	44
nop	2

How to fix Complexity

<?php

class CalendarMonthView extends CalendarAbstractWeekView
namespace YourVendor;

class YourClass { }
{

    // Attributes

    private $monthClass;

    // Abstract Functions Implemented

    public function init()
    {
        parent::init();
        $this->containerClass = 'monthView';
        $this->innerClass = 'month';
        $this->viewTitle = 'return date(\'F Y\', $date);';
        $this->monthClass = 'return strtolower(date(\'F\', $monthDate));';
    }

    public function needsMonth()
    {
        return true;
    }
    public function needsDay()
    {
        return false;
    }

    public function prevLinkParams(Calendar $calendar)
    {
        $date = mktime(0, 0, 0, $calendar->getMonth() - $this->number, 1, $calendar->getYear());
        return $this->getLinkParams($date);
    }

    public function nextLinkParams(Calendar $calendar)
    {
        $date = mktime(0, 0, 0, $calendar->getMonth() + $this->number, 1, $calendar->getYear());
        return $this->getLinkParams($date);
    }

    public function viewLinkParamsAndTitle(Calendar $calendar)
    {
        $month = $calendar->getMonth();
        if (! $month) {
            $month = 1;
        }
        $year = $calendar->getYear();
        $date = mktime(0, 0, 0, $month, 1, $year);
        $params = $this->getLinkParams($date);
        $title = $this->getCustomisedTitle($month, $year);
        return array($params, $title);
    }

    public function getLinkParams($date)
    {
        return array(
            'year' => date('Y', $date),
            'month' => date('n', $date)
        );
    }

    public function title()

    {
        return $this->number == 1 ? 'month' : "$this->number months";
    }

    public function DateTitle(Calendar $calendar)

    {
        return $this->getCustomisedTitle($calendar->getMonth(), $calendar->getYear());
    }

    public function Weeks(Calendar $calendar)
    {
        $year = $calendar->getYear();
        $month = $calendar->getMonth();

        $nowYear = date('Y');
        $nowMonth = date('n');

        for ($i = 0; $i < $this->number; $i++) {
            $weeksGroup = $this->MonthWeeks($month, $year);

            // 1) Single Values

            $monthDate = mktime(0, 0, 0, $month, 1, $year);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $values['ExtraInnerClass'] = eval($this->monthClass) . " year$year";
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $values['IsNowYear'] = $year == $nowYear;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            $values['IsPastYear'] = $year < $nowYear;
            $values['IsNow'] = $values['IsNowYear'] && $month == $nowMonth;
            $values['IsPast'] = $values['IsPastYear'] || ($values['IsNowYear'] && $month < $nowMonth);

            $weeksGroups[] = array($weeksGroup, $values);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

            if (++$month > 12) {
                $month = 1;
                $year++;
            }
        }

        return $weeksGroups;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    // Private Functions

    protected function MonthWeeks($month, $year)
    {
        $firstDate = mktime(0, 0, 0, $month, 1, $year);
        $firstDateWeek = date('W', $firstDate);
        $firstDateWeekYear = $year;

        if ($month == 1 && $firstDateWeek >= 52) {
            $firstDateWeekYear--;
        }

        $weekFirstDate = $this->getWeekStartDay($firstDateWeek, $firstDateWeekYear, true);
        $nextWeekFirstDate = mktime(0, 0, 0, date('n', $weekFirstDate), date('j', $weekFirstDate) + 7, date('Y', $weekFirstDate));

        if (date('j', $nextWeekFirstDate) == 1) {
            $weekFirstDate = $nextWeekFirstDate;
        }

        while (date('Y', $weekFirstDate) < $year || (date('Y', $weekFirstDate) == $year && date('n', $weekFirstDate) <= $month)) {
            $weekMonday = $weekFirstDate;
            while (date('N', $weekMonday) != 1) {

                $weekMonday = mktime(0, 0, 0, date('n', $weekMonday), date('j', $weekMonday) + 1, date('Y', $weekMonday));
            }
            $week = date('W', $weekMonday);
            $yearOfWeek = date('Y', $weekMonday);
            if ($month == 1) {
                if ($week == 1 && $yearOfWeek == $year - 1) {
                    $yearOfWeek++;
                } elseif ($week >= 52 && $yearOfWeek == $year) {
                    $yearOfWeek--;
                }
            } elseif ($month == 12 && $week == 1) {
                $yearOfWeek++;
            }

            $weeks[] = array('week' => $week, 'yearOfWeek' => $yearOfWeek, 'month' => $month, 'yearOfMonth' => $year);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $weekFirstDate = mktime(0, 0, 0, date('n', $weekFirstDate), date('j', $weekFirstDate) + 7, date('Y', $weekFirstDate));
        }

        return $weeks;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    // Other Functions

    public function getCustomisedTitle($month, $year)

    {
        $date = mktime(0, 0, 0, $month, 1, $year);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $result = eval($this->viewTitle);

        if ($this->number > 1) {
            $date = mktime(0, 0, 0, $month + $this->number - 1, 1, $year);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $result .= $this->viewTitleDelimiter . eval($this->viewTitle);

        }
        return $result;
    }
}


1		<?php
2
3		class CalendarMonthView extends CalendarAbstractWeekView
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5
6		// Attributes
7
8		private $monthClass;
9
10		// Abstract Functions Implemented
11
12		public function init()
13		{
14		parent::init();
15		$this->containerClass = 'monthView';
16		$this->innerClass = 'month';
17		$this->viewTitle = 'return date(\'F Y\', $date);';
18		$this->monthClass = 'return strtolower(date(\'F\', $monthDate));';
19		}
20
21		public function needsMonth()
22		{
23		return true;
24		}
25		public function needsDay()
26		{
27		return false;
28		}
29
30		public function prevLinkParams(Calendar $calendar)
31		{
32		$date = mktime(0, 0, 0, $calendar->getMonth() - $this->number, 1, $calendar->getYear());
33		return $this->getLinkParams($date);
34		}
35
36		public function nextLinkParams(Calendar $calendar)
37		{
38		$date = mktime(0, 0, 0, $calendar->getMonth() + $this->number, 1, $calendar->getYear());
39		return $this->getLinkParams($date);
40		}
41
42		public function viewLinkParamsAndTitle(Calendar $calendar)
43		{
44		$month = $calendar->getMonth();
45		if (! $month) {
46		$month = 1;
47		}
48		$year = $calendar->getYear();
49		$date = mktime(0, 0, 0, $month, 1, $year);
50		$params = $this->getLinkParams($date);
51		$title = $this->getCustomisedTitle($month, $year);
52		return array($params, $title);
53		}
54
55		public function getLinkParams($date)
56		{
57		return array(
58		'year' => date('Y', $date),
59		'month' => date('n', $date)
60		);
61		}
62
63		public function title()
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
64		{
65		return $this->number == 1 ? 'month' : "$this->number months";
66		}
67
68		public function DateTitle(Calendar $calendar)
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
69		{
70		return $this->getCustomisedTitle($calendar->getMonth(), $calendar->getYear());
71		}
72
73		public function Weeks(Calendar $calendar)
74		{
75		$year = $calendar->getYear();
76		$month = $calendar->getMonth();
77
78		$nowYear = date('Y');
79		$nowMonth = date('n');
80
81		for ($i = 0; $i < $this->number; $i++) {
82		$weeksGroup = $this->MonthWeeks($month, $year);
83
84		// 1) Single Values
85
86		$monthDate = mktime(0, 0, 0, $month, 1, $year);
		0 ignored issues – show Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$monthDate` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
87		$values['ExtraInnerClass'] = eval($this->monthClass) . " year$year";
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$values` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$values = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history... Coding Style introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
88		$values['IsNowYear'] = $year == $nowYear;
		0 ignored issues – show Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The variable `$values` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
89		$values['IsPastYear'] = $year < $nowYear;
90		$values['IsNow'] = $values['IsNowYear'] && $month == $nowMonth;
91		$values['IsPast'] = $values['IsPastYear'] \|\| ($values['IsNowYear'] && $month < $nowMonth);
92
93		$weeksGroups[] = array($weeksGroup, $values);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$weeksGroups` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$weeksGroups = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
94
95		if (++$month > 12) {
96		$month = 1;
97		$year++;
98		}
99		}
100
101		return $weeksGroups;
		0 ignored issues – show Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The variable `$weeksGroups` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
102		}
103
104		// Private Functions
105
106		protected function MonthWeeks($month, $year)
107		{
108		$firstDate = mktime(0, 0, 0, $month, 1, $year);
109		$firstDateWeek = date('W', $firstDate);
110		$firstDateWeekYear = $year;
111
112		if ($month == 1 && $firstDateWeek >= 52) {
113		$firstDateWeekYear--;
114		}
115
116		$weekFirstDate = $this->getWeekStartDay($firstDateWeek, $firstDateWeekYear, true);
117		$nextWeekFirstDate = mktime(0, 0, 0, date('n', $weekFirstDate), date('j', $weekFirstDate) + 7, date('Y', $weekFirstDate));
118
119		if (date('j', $nextWeekFirstDate) == 1) {
120		$weekFirstDate = $nextWeekFirstDate;
121		}
122
123		while (date('Y', $weekFirstDate) < $year \|\| (date('Y', $weekFirstDate) == $year && date('n', $weekFirstDate) <= $month)) {
124		$weekMonday = $weekFirstDate;
125	View Code Duplication	while (date('N', $weekMonday) != 1) {
		0 ignored issues – show Duplication introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		$weekMonday = mktime(0, 0, 0, date('n', $weekMonday), date('j', $weekMonday) + 1, date('Y', $weekMonday));
127		}
128		$week = date('W', $weekMonday);
129		$yearOfWeek = date('Y', $weekMonday);
130		if ($month == 1) {
131		if ($week == 1 && $yearOfWeek == $year - 1) {
132		$yearOfWeek++;
133		} elseif ($week >= 52 && $yearOfWeek == $year) {
134		$yearOfWeek--;
135		}
136		} elseif ($month == 12 && $week == 1) {
137		$yearOfWeek++;
138		}
139
140		$weeks[] = array('week' => $week, 'yearOfWeek' => $yearOfWeek, 'month' => $month, 'yearOfMonth' => $year);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$weeks` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$weeks = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
141		$weekFirstDate = mktime(0, 0, 0, date('n', $weekFirstDate), date('j', $weekFirstDate) + 7, date('Y', $weekFirstDate));
142		}
143
144		return $weeks;
		0 ignored issues – show Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The variable `$weeks` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
145		}
146
147		// Other Functions
148
149	View Code Duplication	public function getCustomisedTitle($month, $year)
		0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Duplication introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
150		{
151		$date = mktime(0, 0, 0, $month, 1, $year);
		0 ignored issues – show Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$date` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
152		$result = eval($this->viewTitle);
		0 ignored issues – show Coding Style introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
153		if ($this->number > 1) {
154		$date = mktime(0, 0, 0, $month + $this->number - 1, 1, $year);
		0 ignored issues – show Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$date` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
155		$result .= $this->viewTitleDelimiter . eval($this->viewTitle);
		0 ignored issues – show Coding Style introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
156		}
157		return $result;
158		}
159		}
160

sunnysideup / silverstripe-calendar

CalendarMonthView::MonthWeeks() C last analyzed 2018-03-20 00:56 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

CalendarMonthView::MonthWeeks() C
last analyzed 2018-03-20 00:56 UTC