CalendarDayView::init() - Code Metrics - sunnysideup/silverstripe-calendar - Measure and Improve Code Quality continuously with Scrutinizer

CalendarDayView::init() A
last analyzed 2018-03-20 00:56 UTC

↳ Parent: CalendarDayView

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

class CalendarDayView extends CalendarAbstractTimeView
namespace YourVendor;

class YourClass { }
{
        
    // Abstract Functions Implemented

    public function init()
    {
        parent::init();
        $this->containerClass = 'dayView';
        $this->innerClass = 'day';
        $this->viewTitle = 'return date(\'l jS F Y\', $date);';
    }
    
    public function prevLinkParams(Calendar $calendar)
    {
        $date = mktime(0, 0, 0, $calendar->getMonth(), $calendar->getDay() - $this->number, $calendar->getYear());
        return $this->getLinkParams($date);
    }
    
    public function nextLinkParams(Calendar $calendar)
    {
        $date = mktime(0, 0, 0, $calendar->getMonth(), $calendar->getDay() + $this->number, $calendar->getYear());
        return $this->getLinkParams($date);
    }
    
    public function title()

    {
        return $this->number == 1 ? 'day' : "$this->number days";
    }
    
    public function Dates(Calendar $calendar)
    {
        $year = $calendar->getYear();
        $month = $calendar->getMonth();
        $day = $calendar->getDay();
        
        for ($i = 0; $i < $this->number; $i++) {
            if ($i == 0) {
                $lastDate = mktime(0, 0, 0, $month, $day, $year);
            } else {
                $lastDate = mktime(0, 0, 0, date('n', $lastDate), date('j', $lastDate) + 1, date('Y', $lastDate));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
            $datesGroups[] = array($lastDate);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        
        return $datesGroups;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }
    
    public function getCustomisedTitle($day, $month, $year)

    {
        $date = mktime(0, 0, 0, $month, $day, $year);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $result = eval($this->viewTitle);

        if ($this->number > 1) {
            $date = mktime(0, 0, 0, $month, $day + $this->number - 1, $year);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $result .= $this->viewTitleDelimiter . eval($this->viewTitle);

        }
        return $result;
    }
}


1			<?php
2
3			class CalendarDayView extends CalendarAbstractTimeView
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			// Abstract Functions Implemented
7
8			public function init()
9			{
10			parent::init();
11			$this->containerClass = 'dayView';
12			$this->innerClass = 'day';
13			$this->viewTitle = 'return date(\'l jS F Y\', $date);';
14			}
15
16			public function prevLinkParams(Calendar $calendar)
17			{
18			$date = mktime(0, 0, 0, $calendar->getMonth(), $calendar->getDay() - $this->number, $calendar->getYear());
19			return $this->getLinkParams($date);
20			}
21
22			public function nextLinkParams(Calendar $calendar)
23			{
24			$date = mktime(0, 0, 0, $calendar->getMonth(), $calendar->getDay() + $this->number, $calendar->getYear());
25			return $this->getLinkParams($date);
26			}
27
28			public function title()
			0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
29			{
30			return $this->number == 1 ? 'day' : "$this->number days";
31			}
32
33			public function Dates(Calendar $calendar)
34			{
35			$year = $calendar->getYear();
36			$month = $calendar->getMonth();
37			$day = $calendar->getDay();
38
39			for ($i = 0; $i < $this->number; $i++) {
40			if ($i == 0) {
41			$lastDate = mktime(0, 0, 0, $month, $day, $year);
42			} else {
43			$lastDate = mktime(0, 0, 0, date('n', $lastDate), date('j', $lastDate) + 1, date('Y', $lastDate));
			0 ignored issues – show Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The variable `$lastDate` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
44			}
45			$datesGroups[] = array($lastDate);
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$datesGroups` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$datesGroups = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
46			}
47
48			return $datesGroups;
			0 ignored issues – show Bug introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report The variable `$datesGroups` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
49			}
50
51			public function getCustomisedTitle($day, $month, $year)
			0 ignored issues – show Documentation introduced 2018-02-21 03:48 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
52			{
53			$date = mktime(0, 0, 0, $month, $day, $year);
			0 ignored issues – show Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$date` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
54			$result = eval($this->viewTitle);
			0 ignored issues – show Coding Style introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
55			if ($this->number > 1) {
56			$date = mktime(0, 0, 0, $month, $day + $this->number - 1, $year);
			0 ignored issues – show Unused Code introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report `$date` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
57			$result .= $this->viewTitleDelimiter . eval($this->viewTitle);
			0 ignored issues – show Coding Style introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report It is generally not recommended to use `eval` unless absolutely required. On one hand, `eval` might be exploited by malicious users if they somehow manage to inject dynamic content. On the other hand, with the emergence of faster PHP runtimes like the HHVM, `eval` prevents some optimization that they perform. Loading history...
58			}
59			return $result;
60			}
61			}
62

sunnysideup / silverstripe-calendar

CalendarDayView::init() A last analyzed 2018-03-20 00:56 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

CalendarDayView::init() A
last analyzed 2018-03-20 00:56 UTC