Calendar::initValues() - Code Metrics - sunnysideup/silverstripe-calendar - Measure and Improve Code Quality continuously with Scrutinizer

Calendar::initValues() F
last analyzed 2018-03-20 00:56 UTC

↳ Parent: Calendar

Complexity

Conditions	56
Paths	> 20000

Size

Total Lines	156
Code Lines	101

Duplication

Lines	12
Ratio	7.69 %

Importance

Changes

Metric	Value
dl	12
loc	156
rs	2
c	0
b	0
f	0
cc	56
eloc	101
nc	65258545
nop	0

How to fix Long Method Complexity

<?php

class Calendar extends ViewableData
namespace YourVendor;

class YourClass { }
{

    // Static

    private static $names = array();

    public static $session_calendars = 'Calendars';

    // Attributes

    protected $controller;

    protected $name;

    protected $initDone = false;

    protected $views = array();

    protected $view;

    protected $year;
    protected $month;
    protected $day;

    protected $defaultView;
    protected $defaultYear;
    protected $defaultMonth;
    protected $defaultDay;

    protected $sessionMode = false;

    protected $navigationBarTemplate;
    protected $viewBarTemplate;

    // Constructor

    public function __construct($controller, $name, $views = null)
    {
        parent::__construct();

        // 1) Controller Setting

        $this->controller = $controller;

        // 2) Name Setting

        if (is_string($name)) {

            if (! in_array($name, self::$names)) {
                $this->name = $name;
                self::$names[] = $name;
            } else {
                user_error("Calendar::__construct() : you cannot set the \$name attribute with the value '$name' because an other calendar with this name already exists", E_USER_ERROR);
            }
        } else {
            user_error('Calendar::__construct() : you cannot set the $name attribute with a non string value', E_USER_ERROR);
        }

        // 3) Views Setting

        if ($views != null) {
            $this->addViews($views);
        }
    }

    public function initValues()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($this->initDone) {
            return;
        }

        $sessionName = self::$session_calendars . ".$this->name";
        $sessionValues = Session::get($sessionName);
        if ($sessionValues) {
            $sessionValues = unserialize($sessionValues);
        }

        // 1) View Setting

        $views = array();
        if (isset($_REQUEST[$this->name]['view'])) {
            $views[] = $_REQUEST[$this->name]['view'];
        }
        if ($this->sessionMode && $sessionValues && isset($sessionValues['view'])) {
            $views[] = $sessionValues['view'];
        }
        if ($this->defaultView) {
            $views[] = is_a($this->defaultView, 'CalendarAbstractView') ? $this->defaultView->getName() : $this->defaultView;
        }
        foreach ($views as $view) {
            $view = $this->getView($view);
            if ($view) {
                $this->view = $view;
                break;
            }
        }
        if (! $this->view) {
            if (count($this->views) > 0) {
                $this->view = $this->views[0];
            } else {
                return;
            }
        }

        // 2) Year Setting

        $years = array();
        if (isset($_REQUEST[$this->name]['year'])) {

            $years[] = $_REQUEST[$this->name]['year'];
        }
        if ($this->sessionMode && $sessionValues && isset($sessionValues['year'])) {

            $years[] = $sessionValues['year'];
        }
        if ($this->defaultYear) {
            $years[] = $this->defaultYear;
        }
        foreach ($years as $year) {
            if (is_numeric($year) && is_int($year + 0) && $year >= 1) {
                $this->year = $year;
                break;
            }
        }
        if (! $this->year) {
            $this->year = date('Y');
        }

        // 3) Month Setting

        if ($this->view->needsMonth()) {
            $months = array();
            if (isset($_REQUEST[$this->name]['month'])) {
                $months[] = $_REQUEST[$this->name]['month'];
            }
            if ($this->sessionMode && $sessionValues && isset($sessionValues['month'])) {
                $months[] = $sessionValues['month'];
            }
            if ($this->defaultMonth) {
                $months[] = $this->defaultMonth;
            }
            foreach ($months as $month) {
                if (is_numeric($month) && is_int($month + 0)) {
                    if ($month >= 1 && $month <= 12) {
                        $this->month = $month;
                    } elseif ($month < 1) {
                        $this->year = $this->year > 1 ?    $this->year - 1 : date('Y');
                        $this->month = 12;
                    } else {
                        $this->year++;
                        $this->month = 1;
                    }
                    break;
                }
            }
            if (! $this->month) {
                $this->month = date('n');
            }
        }

        // 4) Day Setting

        if ($this->view->needsDay()) {
            if (isset($_REQUEST[$this->name]['day'])) {

                $days[] = $_REQUEST[$this->name]['day'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            }
            if ($this->sessionMode && $sessionValues && isset($sessionValues['day'])) {

                $days[] = $sessionValues['day'];
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            }
            if ($this->defaultDay) {
                $days[] = $this->defaultDay;
            }
            $days[] = date('j');
            foreach ($days as $day) {
                if (is_numeric($day) && is_int($day + 0)) {
                    if ($day >= 1 && $day <= 28) {
                        $this->day = $day;
                    } elseif ($day < 1) {
                        if ($this->month == 1) {
                            $this->year = $this->year > 1 ?    $this->year - 1 : date('Y');
                            $this->month = 12;
                        } else {
                            $this->month--;
                        }
                        $dayAfter = mktime(0, 0, 0, $this->month + 1, 1, $this->year);
                        $this->day = date('j', mktime(0, 0, 0, date('n', $dayAfter), date('j', $dayAfter) - 1, date('Y', $dayAfter)));
                    } else {
                        $date = mktime(0, 0, 0, $this->month, $day, $this->year);
                        if (date('n', $date) == $this->month && date('j', $date) == $day && date('Y', $date) == $this->year) {
                            $this->day = $day;
                        } else {
                            if ($this->month == 12) {
                                $this->year++;
                                $this->month = 1;
                            } else {
                                $this->month++;
                            }
                            $this->day = 1;
                        }
                    }
                    break;
                }
            }
        }

        $this->initDone = true;

        // Session Mode

        if ($this->sessionMode) {
            list($sessionValues, $title) = $this->view->viewLinkParamsAndTitle($this);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
            $sessionValues = array_merge(array('view' => $this->view->getName()), $sessionValues);
            $sessionValues = serialize($sessionValues);
            Session::set($sessionName, $sessionValues);
        } else {
            Session::clear($sessionName);
        }

        // Css Requirements
        Requirements::javascript(SAPPHIRE_DIR .'/thirdparty/jquery/jquery.js');
        Requirements::javascript('calendar/javascript/Calendar.js');
        Requirements::themedCSS('calendar', 'calendar');
    }

    // Field Functions

    public function addViews($views)

    {
        if (! is_array($views)) {
            $views = array($views);
        }
        foreach ($views as $view) {
            if (is_a($view, 'CalendarAbstractView')) {
                if (! in_array($view, $this->views)) {
                    $this->views[] = $view;
                }
            } else {
                user_error('Calendar::addViews() : you cannot add a view which class does not extend \'CalendarAbstractView\'', E_USER_ERROR);
            }
        }
    }

    private function getView($viewName)

    {
        foreach ($this->views as $view) {
            if ($view->getName() == $viewName) {
                return $view;
            }
        }
    }

    public function removeViews($views)

    {
        if (! is_array($views)) {
            $views = array($views);
        }
        foreach ($views as $view) {
            if (is_a($view, 'CalendarAbstractView')) {
                $index = array_search($view, $this->views);
                if ($index) {
                    unset($this->views[$index]);
                }
            } else {
                user_error('Calendar::removeViews() : you cannot remove a view which class does not extend \'CalendarAbstractView\'', E_USER_ERROR);
            }
        }
    }

    public function forTemplate()

    {
        $this->initValues();
        if ($this->view) {
            return $this->view->showCalendar($this);
        }
    }

    public function NavigationBar()
    {
        if ($this->navigationBarTemplate) {
            $templates[] = $this->navigationBarTemplate;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $templates[] = 'CalendarNavigationBar';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        return $this->renderWith($templates);
    }

    public function ViewBar()
    {
        if ($this->viewBarTemplate) {
            $templates[] = $this->viewBarTemplate;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        $templates[] = 'CalendarViewBar';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        return $this->renderWith($templates);
    }

    public function ID()

    {
        return "{$this->class}_{$this->name}";
    }
    public function NavigationBarID()

    {
        return "{$this->ID()}_NavigationBar";
    }
    public function ViewBarID()

    {
        return "{$this->ID()}_ViewBar";
    }

    public function ViewTitle()

    {
        return $this->view->title();
    }
    public function ViewDateTitle()

    {
        $this->initValues();
        return $this->view->DateTitle($this);
    }

    public function Views()
    {
        $this->initValues();
        foreach ($this->views as $view) {
            list($params, $title) = $view->viewLinkParamsAndTitle($this);
            $link = $this->Link($this->controller, $view, $params);
            $views[] = new ArrayData(array('Title' => $title, 'Link' => $link, 'Current' => $view->getName() == $this->view->getName()));
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
        return new ArrayList($views);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    public function PrevLink()

    {
        $this->initValues();
        $params = $this->view->prevLinkParams($this);
        return $this->Link($this->controller, $this->view, $params);
    }

    public function NextLink()

    {
        $this->initValues();
        $params = $this->view->nextLinkParams($this);
        return $this->Link($this->controller, $this->view, $params);
    }

    public function Link($controller, CalendarAbstractView $view, array $params)

    {
        $link = is_string($controller) ? $controller : $controller->URLSegment;
        $params = array_merge(array('view' => $view->getName()), $params);
        foreach ($params as $id => $val) {
            $link = HTTP::RAW_setGetVar("$this->name[$id]", $val, $link);
        }
        return $link;
    }

    public function getController()

    {
        return $this->controller;
    }
    public function getYear()
    {
        return $this->year;
    }
    public function getMonth()
    {
        return $this->month;
    }
    public function getDay()
    {
        return $this->day;
    }

    public function setDefaultView($view)
    {
        $this->defaultView = $view;
    }
    public function setDefaultYear($year)
    {
        $this->defaultYear = $year;
    }
    public function setDefaultMonth($month)
    {
        $this->defaultMonth = $month;
    }
    public function setDefaultDay($day)
    {
        $this->defaultDay = $day;
    }

    public function setSessionMode($value)
    {
        $this->sessionMode = $value;
    }

    public function setNavigationBarTemplate($template)
    {
        $this->navigationBarTemplate = $template;
    }
    public function setViewBarTemplate($template)
    {
        $this->viewBarTemplate = $template;
    }
}


Calendar::initValues() F
last analyzed 2018-03-20 00:56 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			class Calendar extends ViewableData
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 00:26 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5
6			// Static
7
8			private static $names = array();
9
10			public static $session_calendars = 'Calendars';
11
12			// Attributes
13
14			protected $controller;
15
16			protected $name;
17
18			protected $initDone = false;
19
20			protected $views = array();
21
22			protected $view;
23
24			protected $year;
25			protected $month;
26			protected $day;
27
28			protected $defaultView;
29			protected $defaultYear;
30			protected $defaultMonth;
31			protected $defaultDay;
32
33			protected $sessionMode = false;
34
35			protected $navigationBarTemplate;
36			protected $viewBarTemplate;
37
38			// Constructor
39

sunnysideup / silverstripe-calendar

Calendar::initValues() F last analyzed 2018-03-20 00:56 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Calendar::initValues() F
last analyzed 2018-03-20 00:56 UTC