CalendarAbstractView

Complexity

Total Complexity

16

Size/Duplication

Total Lines	127
Duplicated Lines	7.87 %

Coupling/Cohesion

Components	2
Dependencies	3

Importance

Changes

0

20 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	10	24	5
	init()	0	1	?
	needsMonth()	0	1	?
	needsDay()	0	1	?
	Calendars()	0	1	?
	prevLinkParams()	0	1	?
	nextLinkParams()	0	1	?
	viewLinkParamsAndTitle()	0	1	?
	getLinkParams()	0	1	?
	title()	0	1	?
	DateTitle()	0	1	?
A	getName()	0	4	1
A	setContainerClass()	0	4	1
A	setInnerClass()	0	4	1
A	setViewTitle()	0	4	1
A	setTemplate()	0	4	1
A	getTemplates()	0	12	3
A	setViewTitleDelimiter()	0	4	1
A	NameClass()	0	6	1
A	showCalendar()	0	7	1

<?php

abstract class CalendarAbstractView extends ViewableData

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    // Static

    private static $names = array();

    // Attributes

    private $name;
    protected $number;

    protected $containerClass;
    protected $innerClass;

    protected $viewTitle;

    protected $template;
    protected $viewTitleDelimiter = ' - ';

    // Contructor

    public function __construct($name, $number = 1)
    {
        parent::__construct();
        if (is_string($name)) {

This code seems to be duplicated across your project.

            if (! in_array($name, self::$names)) {
                $this->name = $name;
                self::$names[] = $name;
            } else {
                user_error("CalendarAbstractView::__construct() : you cannot set the \$name attribute with the value '$name' because an other view with this name already exists", E_USER_ERROR);
            }
        } else {
            user_error('CalendarAbstractView::__construct() : you cannot set the $name attribute with a non string value', E_USER_ERROR);
        }
        if (is_int($number + 0)) {
            if ($number >= 1) {
                $this->number = $number;
            } else {
                user_error('CalendarAbstractView::__construct() : you cannot set the $number attribute with a value less than 1', E_USER_ERROR);
            }
        } else {
            user_error('CalendarAbstractView::__construct() : you cannot set the $number attribute with a non integer value', E_USER_ERROR);
        }
        $this->init();
    }

    // Abstract Functions

    abstract public function init();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function needsMonth();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function needsDay();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function Calendars(Calendar $calendar);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function prevLinkParams(Calendar $calendar);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function nextLinkParams(Calendar $calendar);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function viewLinkParamsAndTitle(Calendar $calendar);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function getLinkParams($date);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function title();

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    abstract public function DateTitle(Calendar $calendar);

For interfaces and abstract methods it is generally a good practice to add a @return annotation even if it is just @return void or @return null, so that implementors know what to do in the overridden method.

    // Functions

    public function getName()
    {
        return $this->name;
    }

    public function setContainerClass($containerClass)
    {
        $this->containerClass = $containerClass;
    }
    public function setInnerClass($innerClass)
    {
        $this->innerClass = $innerClass;
    }

    public function setViewTitle($viewTitle)
    {
        $this->viewTitle = $viewTitle;
    }

    // Template Functions

    public function setTemplate($template)
    {
        $this->template = $template;
    }

    public function getTemplates()
    {
        if ($this->template) {
            $templates[] = $this->template;

$templates was never initialized. Although not strictly required by PHP, it is generally a good practice to add $templates = array(); before regardless.

        }
        $class = get_class($this);
        while ($class != 'CalendarAbstractView') {
            $templates[] = $class;

The variable $templates does not seem to be defined for all execution paths leading up to this point.

            $class = get_parent_class($class);
        }
        return $templates;
    }

    public function setViewTitleDelimiter($viewTitleDelimiter)
    {
        $this->viewTitleDelimiter = $viewTitleDelimiter;
    }

    public function NameClass()
    {
        $class = "{$this->class}_{$this->name}";
        $class[0] = strtolower($class[0]);
        return $class;
    }

    public function showCalendar(Calendar $calendar)
    {
        $calendars = $this->Calendars($calendar);
        $templates = $this->getTemplates();

        return $this->customise(array('ID' => $calendar->ID(), 'ContainerClass' => $this->containerClass, 'Calendars' => $calendars))->renderWith($templates);
    }
}