BlogPostSharedCategoriesExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	37.93 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	UsedCategories()	0	4	1
A	UsedTags()	0	4	1
B	updateCMSFields()	22	26	3

<?php

/**
 * extends BlogPost
 *
 */

class BlogPostSharedCategoriesExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $categories_checkboxes = true;

The property $categories_checkboxes is not used and could be removed.

    private static $tags_checkboxes = true;

The property $tags_checkboxes is not used and could be removed.

    /**
     * overrules has_many method
     * to return ALL categories
     *
     * @return DataList
     */
    public function UsedCategories()
    {
        return $this->owner->Parent()->UsedCategories();
    }

    /**
     * overrules has_many method
     * to return ALL categories
     *
     * @return DataList
     */
    public function UsedTags()
    {
        return $this->owner->Parent()->UsedTags();
    }

    /**
     * Update Fields
     * @return FieldList
     */
    public function updateCMSFields(FieldList $fields)
    {
        if (Config::inst()->get("BlogPostSharedCategoriesExtension", "categories_checkboxes") == true) {

This code seems to be duplicated across your project.

            $fields->replaceField(
                "Categories",
                CheckboxSetField::create(
                    'Categories',
                    _t('BlogPost.Categories', 'Categories'),
                    BlogCategory::get()->sort(array('Title'=>'ASC'))->map("ID", "Title"),
                    $this->owner->Categories()
                )
            );
        }
        if (Config::inst()->get("BlogPostSharedCategoriesExtension", "tags_checkboxes") == true) {

This code seems to be duplicated across your project.

            $fields->replaceField(
                "Tags",
                CheckboxSetField::create(
                    'Tags',
                    _t('BlogPost.Tags', 'Tags'),
                    BlogTag::get()->sort(array('Title'=>'ASC'))->map("ID", "Title"),
                    $this->owner->Tags()
                )
            );
        }
        return $fields;
    }
}