sunnysideup / silverstripe-assets_overview

src/Traits/FilesystemRelatedTraits.php

<?php

namespace Sunnysideup\AssetsOverview\Traits;

use SilverStripe\Assets\File;
use SilverStripe\Control\Director;

trait FilesystemRelatedTraits
{
    /**
     * @var string
     */
    protected $baseFolder = '';

    /**
     * @var string
     */
    protected $publicBaseFolder = '';

    /**
     * @var string
     */
    protected $assetsBaseFolder = '';

    protected function humanFileSize(int $bytes, int $decimals = 0): string

The parameter $decimals is not used and could be removed.

    {
        return File::format_size($bytes);
        // $size = ['B', 'kB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB'];
        // $factor = floor((strlen( (string) $bytes) - 1) / 3);
        //
        // return sprintf("%.{$decimals}f", $bytes / pow(1024, $factor)) . @$size[$factor];
    }

    protected function getExtension(string $path): string
    {
        return pathinfo($path, PATHINFO_EXTENSION);

The expression return pathinfo($path, Sunnysideup\AssetsOverview\Traits\PATHINFO_EXTENSION) could return the type array which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    protected function getBaseFolder(): string
    {
        if (! $this->baseFolder) {
            $this->baseFolder = rtrim(Director::baseFolder(), DIRECTORY_SEPARATOR);
        }

        return $this->baseFolder;
    }

    protected function getPublicBaseFolder(): string
    {
        if (! $this->publicBaseFolder) {
            $this->publicBaseFolder = rtrim(Director::publicFolder(), DIRECTORY_SEPARATOR);
        }

        return $this->publicBaseFolder;
    }

    protected function getAssetsBaseFolder(): string
    {
        if (! $this->assetsBaseFolder) {
            $this->assetsBaseFolder = rtrim(ASSETS_PATH, DIRECTORY_SEPARATOR);
        }

        return $this->assetsBaseFolder;
    }
}