AdvertisementController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	removealladvertisements()	0	15	2
A	deletealladvertisements()	0	8	1

<?php


class AdvertisementController extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        "removealladvertisements" => "ADMIN",
        "deletealladvertisements" => "ADMIN"
    );

    public function removealladvertisements($request)
    {
        $id = intval($request->param("ID"))-0;
        $page = SiteTree::get()->byID($id);
        if (!$page) {
            return "this page does not exist";
        }
        DB::query("DELETE FROM SiteTree_Advertisements WHERE SiteTreeID = ".$id);
        DB::query("UPDATE SiteTree SET AdvertisementsFolderID = 0 WHERE SiteTree.ID = ".$id);
        DB::query("UPDATE SiteTree_Live SET AdvertisementsFolderID = 0 WHERE SiteTree_Live.ID = ".$id);
        return sprintf(
            _t("AdvertisementController.REMOVEDALL", 'Removed all %1$s from this page, please reload page to see results.'),
            Config::inst()->get("Advertisement", "plural_name")
        );
    }

    public function deletealladvertisements($request)

The parameter $request is not used and could be removed.

    {
        DB::query("DELETE FROM \"Advertisement\"");
        return sprintf(
            _t("AdvertisementController.DELETEDALL", 'Deleted all %1$s from this website, please reload page to see results.'),
            Config::inst()->get("Advertisement", "plural_name")
        );
    }
}