Issues in UserController.php (master) - Issues in master - sumocoders/FrameworkUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/UserController.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SumoCoders\FrameworkUserBundle\Controller;

use SumoCoders\FrameworkUserBundle\Entity\User;
use SumoCoders\FrameworkUserBundle\Form\OtherUserType;
use SumoCoders\FrameworkUserBundle\Form\OwnUserType;
use SumoCoders\FrameworkUserBundle\Form\UserType;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

class UserController extends Controller

{
    /**
     * Show an overview of all the users
     *
     * @Route("/")
     * @Method({"GET"})
     * @Template()
     */
    public function indexAction()
    {
        /** @var $userManager \SumoCoders\FrameworkUserBundle\Model\FrameworkUserManager */
        $userManager = $this->container->get('fos_user.user_manager');
        $users = $userManager->findUsers();

        /** @var $paginator \Knp\Component\Pager\Paginator */
        $paginator = $this->get('knp_paginator');
        $paginatedUsers = $paginator->paginate(
            $users,
            $this->get('request_stack')->getCurrentRequest()->query->get('page', 1)
        );

        return array(
            'dgUsers' => $paginatedUsers,
        );
    }

    /**
     * Add a user
     *
     * @Route("/new")
     * @Method({"GET|POST"})
     * @Template()
     *
     * @param Request $request
     * @return array
     */
    public function newAction(Request $request)
    {
        // fix the breadCrumb
        $this->get('framework.breadcrumb_builder')
            ->extractItemsBasedOnUri(
                $this->generateUrl('sumocoders_frameworkuser_user_index'),
                $request->getLocale()
            )
            ->addSimpleItem(
                'user.breadcrumb.new',
                $this->generateUrl('sumocoders_frameworkuser_user_new')
            );

        $form = $this->createForm(
            new UserType('\SumoCoders\FrameworkUserBundle\Entity\User')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
        $form->add('roles', 'choice', array(
            'choices' => $this->getExistingRoles(),
            'data' => array(),
            'label' => 'Roles',
            'expanded' => true,
            'multiple' => true,
            'mapped' => true,
        ));

        $form->handleRequest($request);

        if ($form->isValid()) {
            /** @var \SumoCoders\FrameworkUserBundle\Model\FrameworkUserManager $userManager */
            $userManager = $this->container->get('fos_user.user_manager');
            /** @var \SumoCoders\FrameworkUserBundle\Entity\User $user */
            $user = $form->getData();
            $user->setEnabled(true);
            $userManager->updateUser($user);

            /** @var \Symfony\Component\HttpFoundation\Session\Session $session */
            $session = $this->get('session');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            /** @var \Symfony\Bundle\FrameworkBundle\Translation\Translator $translator */
            $translator = $this->get('translator');

            $this->addFlash(
                'success',
                $translator->trans('user.flash.success.add', array('%username%' => $user->getUsername()))
            );

            // @todo move this in an event!
            if (array_key_exists(

                'SumoCodersFrameworkSearchBundle',
                $this->container->getParameter('kernel.bundles')
            )
            ) {
                $searchIndexItems = \SumoCoders\FrameworkSearchBundle\Entity\IndexItem::createMultipleObjectsBasedOnProperties(

                    'SumoCoders\FrameworkUserBundle\Entity\User',
                    $user->getId(),
                    array('username', 'email'),
                    $user
                );

                $event = new \SumoCoders\FrameworkSearchBundle\Event\IndexUpdateEvent();
                $event->setObjects($searchIndexItems);
                $this->get('event_dispatcher')->dispatch('framework_search.index_update', $event);
            }

            return $this->redirect(
                $this->generateUrl(
                    'sumocoders_frameworkuser_user_index'
                )
            );
        }

        return array(
            'form' => $form->createView(),
        );
    }

    /**
     * Edit a user
     *
     * @Route("/{id}/edit", requirements={"id"= "\d+"})
     * @Method({"GET|POST"})
     * @Template()
     *
     * @param Request $request
     * @param int     $id
     * @return array
     */
    public function editAction(Request $request, $id)
    {
        // fix the breadCrumb
        $this->get('framework.breadcrumb_builder')
            ->extractItemsBasedOnUri(
                $this->generateUrl('sumocoders_frameworkuser_user_index'),
                $request->getLocale()
            )
            ->addSimpleItem(
                'user.breadcrumb.edit',
                $this->generateUrl(
                    'sumocoders_frameworkuser_user_edit',
                    array('id' => $id)
                )
            );

        $csrfProvider = $this->get('security.csrf.token_manager');
        /** @var \Symfony\Component\HttpFoundation\Session\Session $session */
        $session = $this->get('session');
        /** @var \Symfony\Bundle\FrameworkBundle\Translation\Translator $translator */
        $translator = $this->get('translator');

        /** @var \SumoCoders\FrameworkUserBundle\Model\FrameworkUserManager $userManager */
        $userManager = $this->container->get('fos_user.user_manager');
        /** @var \SumoCoders\FrameworkUserBundle\Entity\User $user */
        $user = $userManager->findUserBy(array('id' => $id));
        /** @var \SumoCoders\FrameworkUserBundle\Entity\User $currentUser */
        $currentUser = $this->get('security.context')->getToken()->getUser();

        // validate the user
        if (!$user) {
            throw new NotFoundHttpException(
                $translator->trans('core.errors.notFound')
            );
        }

        // if the current user is editing itself it should see the password field
        if ($currentUser->getId() == $user->getId()) {
            $type = new OwnUserType('\SumoCoders\FrameworkUserBundle\Entity\User');
        } else {
            $type = new OtherUserType('\SumoCoders\FrameworkUserBundle\Entity\User');
        }

        $form = $this->createForm($type, $user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->add(
            'roles',
            'choice',
            array(
                'choices' => $this->getExistingRoles(),
                'data' => $user->getRoles(),
                'label' => 'Roles',
                'expanded' => true,
                'multiple' => true,
            )
        );

        $form->handleRequest($request);

        if ($form->isValid()) {
            $user = $form->getData();
            $userManager->updateUser($user);

            if (array_key_exists(

                'SumoCodersFrameworkSearchBundle',
                $this->container->getParameter('kernel.bundles')
            )
            ) {
                $searchIndexItems = \SumoCoders\FrameworkSearchBundle\Entity\IndexItem::createMultipleObjectsBasedOnProperties(

                    'SumoCoders\FrameworkUserBundle\Entity\User',
                    $user->getId(),
                    array('username', 'email'),
                    $user
                );

                $event = new \SumoCoders\FrameworkSearchBundle\Event\IndexUpdateEvent();
                $event->setObjects($searchIndexItems);
                $this->get('event_dispatcher')->dispatch('framework_search.index_update', $event);
            }

            $session->getFlashBag()->add(
                'success',
                $translator->trans('user.flash.success.edit', array('%username%' => $user->getUsername()))
            );

            return $this->redirect(
                $this->generateUrl(
                    'sumocoders_frameworkuser_user_index'
                )
            );
        }

        if ($user->isEnabled()) {
            $blockUnblockForm = $this->createBlockUnblockForm($user, 'block');
        } else {
            $blockUnblockForm = $this->createBlockUnblockForm($user, 'unblock');
        }

        return array(
            'form' => $form->createView(),
            'token' => $csrfProvider->getToken('block_unblock'),
            'user' => $user,
            'form_block_unblock' => $blockUnblockForm->createView(),
        );
    }

    /**
     * Creates a form to block a user.
     *
     * @param User $user The entity
     * @return \Symfony\Component\Form\Form The form
     */
    private function createBlockUnblockForm(User $user, $action = 'block')
    {
        $allowedActions = array(
            'block',
            'unblock',
        );

        if (!in_array($action, $allowedActions)) {
            throw new \InvalidArgumentException(
                'Invalid action, possible values are: ' . implode(', ', $allowedActions)
            );
        }

        if ('block' === $action) {
            $route = 'sumocoders_frameworkuser_user_block';
            $label = 'user.forms.buttons.block';
            $message = 'user.dialogs.messages.confirmBlock';
            $class = 'btn-danger';
            $icon = 'fa fa-remove';
        }
        if ('unblock' === $action) {
            $route = 'sumocoders_frameworkuser_user_unblock';
            $label = 'user.forms.buttons.unblock';
            $message = 'user.dialogs.messages.confirmUnblock';
            $class = 'btn-success';
            $icon = 'fa fa-check';
        }

        return $this->createFormBuilder()
            ->setAction(
                $this->generateUrl(
                    $route,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    array(
                        'id' => $user->getId(),
                    )
                )
            )
            ->setMethod('POST')
            ->add(
                'submit',
                'submit',
                array(
                    'icon' => $icon,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    'label' => ucfirst($this->get('translator')->trans($label)),
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    'attr' => array(
                        'class' => 'confirm ' . $class,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        'data-message' => $this->get('translator')->trans(
                            $message,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                            array(
                                '%entity%' => $user,
                            )
                        ),
                    ),
                )
            )
            ->getForm();
    }

    /**
     * Block a user
     *
     * We won't delete users, as users can/will be linked through other stuff
     * in our application.
     *
     * @Route("/{id}/block", requirements={"id"= "\d+"})
     * @Method({"POST"})
     * @Template()
     *
     * @param User $user
     * @return array
     */
    public function blockAction(User $user)
    {
        return $this->handleBlockUnBlock('block', $user);
    }

    /**
     * Unblock a user
     *
     * @Route("/{id}/unblock", requirements={"id"= "\d+"})
     * @Method({"POST"})
     * @Template()
     *
     * @param User $user
     * @return array
     */
    public function unblockAction(User $user)
    {
        return $this->handleBlockUnBlock('unblock', $user);
    }

    /**
     * @param string $type
     * @param User   $user
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     * @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
     */
    private function handleBlockUnBlock($type, User $user)
    {
        /** @var \Symfony\Bundle\FrameworkBundle\Translation\Translator $translator */
        $translator = $this->get('translator');

        if ($type == 'unblock') {
            $enabled = true;
            $message = 'user.flash.success.unblocked';
        } else {
            $enabled = false;
            $message = 'user.flash.success.blocked';
        }

        $user->setEnabled($enabled);
        $this->container->get('fos_user.user_manager')->updateUser($user);

        $this->addFlash(
            'success',
            $translator->trans($message, array('%username%' => $user->getUsername()))
        );

        return $this->redirect(
            $this->generateUrl(
                'sumocoders_frameworkuser_user_edit',
                array(
                    'id' => $user->getId(),
                )
            )
        );
    }

    /**
     * Fetches all possible roles stated in our role_hierarchy setting
     *
     * @return array
     */
    protected function getExistingRoles()
    {
        $roleHierarchy = $this->container->getParameter('security.role_hierarchy.roles');
        $roles = array_keys($roleHierarchy);

        $cleanedUpRoles = array();
        foreach ($roles as $role) {
            $cleanedUpRoles[$role] = $role;
        }

        return $cleanedUpRoles;
    }
}


Issues (15)

Security Analysis not enabled

Controller/UserController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

sumocoders / FrameworkUserBundle

Issues (15)

Security Analysis not enabled

Controller/UserController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like