RequestPasswordResetHandler::__construct() - Code Metrics - Inspection of "54 add forgot password" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2016-06-29 15:31 UTC

RequestPasswordResetHandler::__construct() A

↳ Parent: RequestPasswordResetHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	5
nc	1
nop	2

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Command;

use SumoCoders\FrameworkMultiUserBundle\Event\PasswordResetTokenCreated;
use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
use Swift_Mailer;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class RequestPasswordResetHandler
{
    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    /**
     * @var EventDispatcher
     */
    private $dispatcher;

    /**
     * PasswordResetRequestHandler constructor.
     *
     * @param UserRepositoryCollection $userRepositoryCollection
     * @param EventDispatcherInterface $dispatcher
     */
    public function __construct(
        UserRepositoryCollection $userRepositoryCollection,
        EventDispatcherInterface $dispatcher
    ) {
        $this->userRepositoryCollection = $userRepositoryCollection;
        $this->dispatcher = $dispatcher;

    }

    /**
     * Creates a password reset token and sends an email to the user.
     *
     * @param RequestPasswordReset $command
     */
    public function handle(RequestPasswordReset $command)
    {
        $user = $command->getUser();
        $user->generatePasswordResetToken();
        $repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
        $repository->save($user);

        $this->sendPasswordResetToken($user);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Sends the password reset token to the user.
     *
     * @param UserPasswordReset $user
     */
    private function sendPasswordResetToken(UserPasswordReset $user)
    {
        $event = new PasswordResetTokenCreated($user);
        $this->dispatcher->dispatch(PasswordResetTokenCreated::NAME, $event);
    }
}


1			<?php
2
3			namespace SumoCoders\FrameworkMultiUserBundle\Command;
4
5			use SumoCoders\FrameworkMultiUserBundle\Event\PasswordResetTokenCreated;
6			use SumoCoders\FrameworkMultiUserBundle\User\PasswordReset as UserPasswordReset;
7			use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
8			use Swift_Mailer;
9			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
10
11			class RequestPasswordResetHandler
12			{
13			/**
14			* @var UserRepositoryCollection
15			*/
16			private $userRepositoryCollection;
17
18			/**
19			* @var EventDispatcher
20			*/
21			private $dispatcher;
22
23			/**
24			* PasswordResetRequestHandler constructor.
25			*
26			* @param UserRepositoryCollection $userRepositoryCollection
27			* @param EventDispatcherInterface $dispatcher
28			*/
29			public function __construct(
30			UserRepositoryCollection $userRepositoryCollection,
31			EventDispatcherInterface $dispatcher
32			) {
33			$this->userRepositoryCollection = $userRepositoryCollection;
34			$this->dispatcher = $dispatcher;
			0 ignored issues – show Documentation Bug introduced 2016-06-15 12:41 UTC by Report Bug Copy Issue Report It seems like `$dispatcher` of type `object<Symfony\Component...entDispatcherInterface>` is incompatible with the declared type `object<SumoCoders\Framew...ommand\EventDispatcher>` of property `$dispatcher`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			}
36
37			/**
38			* Creates a password reset token and sends an email to the user.
39			*
40			* @param RequestPasswordReset $command
41			*/
42			public function handle(RequestPasswordReset $command)
43			{
44			$user = $command->getUser();
45			$user->generatePasswordResetToken();
46			$repository = $this->userRepositoryCollection->findRepositoryByClassName(get_class($user));
47			$repository->save($user);
48
49			$this->sendPasswordResetToken($user);
			0 ignored issues – show Documentation introduced 2016-06-15 07:06 UTC by Report Bug Copy Issue Report `$user` is of type `object<SumoCoders\Framew...dle\User\UserInterface>`, but the function expects a `object<SumoCoders\Framew...dle\User\PasswordReset>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50			}
51
52			/**
53			* Sends the password reset token to the user.
54			*
55			* @param UserPasswordReset $user
56			*/
57			private function sendPasswordResetToken(UserPasswordReset $user)
58			{
59			$event = new PasswordResetTokenCreated($user);
60			$this->dispatcher->dispatch(PasswordResetTokenCreated::NAME, $event);
61			}
62			}
63

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#12)

RequestPasswordResetHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like