DeleteUserCommand::execute() - Code Metrics - Inspection of "51 add a cli tool to easily add manage users" - sumocoders/FrameworkMultiUserBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

unknown

created 2016-06-09 13:59 UTC

DeleteUserCommand::execute() A

↳ Parent: DeleteUserCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	22
Code Lines	12

Duplication

Lines	22
Ratio	100 %

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	22
loc	22
rs	9.2
cc	2
eloc	12
nc	2
nop	2

<?php

namespace SumoCoders\FrameworkMultiUserBundle\Command;

use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

final class DeleteUserCommand extends ContainerAwareCommand
{
    /**
     * @var UserRepositoryCollection
     */
    private $userRepositoryCollection;

    /**
     * @param UserRepositoryCollection $userRepositoryCollection
     */
    public function __construct(UserRepositoryCollection $userRepositoryCollection)
    {
        parent::__construct();
        $this->userRepositoryCollection = $userRepositoryCollection;
    }
    
    protected function configure()
    {
        $this
            ->setName('sumocoders:multiuser:delete')
            ->setDescription('Delete a user entity')
            ->addArgument(
                'username',
                InputArgument::REQUIRED,
                'The username of the user'
            )
            ->addOption(
                'class',
                null,
                InputOption::VALUE_OPTIONAL,
                'The class off the user',
                'SumoCoders\FrameworkMultiUserBundle\User\User'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)

    {
        $userClass = $input->getOption('class');

        $repository = $this->getRepository($userClass);

        $handler = new DeleteUserHandler($repository);

        $username = $input->getArgument('username');
        $user = $repository->findByUsername($username);

        if (!$user) {
            $output->writeln('<error>'.$username.' doesn\'t exists');
            exit;

        }

        $command = new DeleteUser($user);


        $handler->handle($command);

        $output->writeln($username . ' has been deleted');
    }

    /**
     * Get the repository for the user's Class.
     *
     * @param $userClass
     *
     * @return UserRepository
     */
    private function getRepository($userClass)
    {
        return $this->userRepositoryCollection->findRepositoryByClassName($userClass);
    }
}


1		<?php
2
3		namespace SumoCoders\FrameworkMultiUserBundle\Command;
4
5		use SumoCoders\FrameworkMultiUserBundle\User\UserRepository;
6		use SumoCoders\FrameworkMultiUserBundle\User\UserRepositoryCollection;
7		use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
8		use Symfony\Component\Console\Input\InputArgument;
9		use Symfony\Component\Console\Input\InputInterface;
10		use Symfony\Component\Console\Input\InputOption;
11		use Symfony\Component\Console\Output\OutputInterface;
12
13		final class DeleteUserCommand extends ContainerAwareCommand
14		{
15		/**
16		* @var UserRepositoryCollection
17		*/
18		private $userRepositoryCollection;
19
20		/**
21		* @param UserRepositoryCollection $userRepositoryCollection
22		*/
23		public function __construct(UserRepositoryCollection $userRepositoryCollection)
24		{
25		parent::__construct();
26		$this->userRepositoryCollection = $userRepositoryCollection;
27		}
28
29		protected function configure()
30		{
31		$this
32		->setName('sumocoders:multiuser:delete')
33		->setDescription('Delete a user entity')
34		->addArgument(
35		'username',
36		InputArgument::REQUIRED,
37		'The username of the user'
38		)
39		->addOption(
40		'class',
41		null,
42		InputOption::VALUE_OPTIONAL,
43		'The class off the user',
44		'SumoCoders\FrameworkMultiUserBundle\User\User'
45		)
46		;
47		}
48
49	View Code Duplication	protected function execute(InputInterface $input, OutputInterface $output)
		0 ignored issues – show Duplication introduced 2016-06-08 07:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		{
51		$userClass = $input->getOption('class');
52
53		$repository = $this->getRepository($userClass);
54
55		$handler = new DeleteUserHandler($repository);
56
57		$username = $input->getArgument('username');
58		$user = $repository->findByUsername($username);
59
60		if (!$user) {
61		$output->writeln('<error>'.$username.' doesn\'t exists');
62		exit;
		0 ignored issues – show Coding Style Compatibility introduced 2016-06-07 11:45 UTC by Report Bug Copy Issue Report The method `execute()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
63		}
64
65		$command = new DeleteUser($user);
		0 ignored issues – show Compatibility introduced 2016-06-09 09:27 UTC by Report Bug Copy Issue Report `$user` of type `object<Symfony\Component...ore\User\UserInterface>` is not a sub-type of `object<SumoCoders\Framew...tiUserBundle\User\User>`. It seems like you assume a concrete implementation of the interface `Symfony\Component\Security\Core\User\UserInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
66
67		$handler->handle($command);
68
69		$output->writeln($username . ' has been deleted');
70		}
71
72		/**
73		* Get the repository for the user's Class.
74		*
75		* @param $userClass
76		*
77		* @return UserRepository
78		*/
79		private function getRepository($userClass)
80		{
81		return $this->userRepositoryCollection->findRepositoryByClassName($userClass);
82		}
83		}
84

sumocoders / FrameworkMultiUserBundle

Pull Request — master (#10)

DeleteUserCommand::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like